PigeonProtocolConsortium/Pigeon-Ruby
PigeonProtocolConsortium
/
Pigeon-Ruby
3
1
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Begin singleton removal

This commit is contained in:
Netscape Navigator 2020-04-15 07:46:49 -05:00
parent 9fba00c48b
commit 21ec42dbd7
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -56,6 +56,7 @@ Eg: `pigeon identity show` becomes `./pigeon-cli show`.
- [X] Make all methods private except those required for the CLI. - [X] Make all methods private except those required for the CLI.
- [X] Add Lipmaa links like the Bamboo folks do. - [X] Add Lipmaa links like the Bamboo folks do.
- [X] Set a max message size. - [X] Set a max message size.
- [ ] Remove all `.current` "singletons" / hacks
- [ ] Make the switch to LevelDB, RocksDB, [UNQLite](https://unqlite.org/features.html) or similar (currently using Ruby PStore). - [ ] Make the switch to LevelDB, RocksDB, [UNQLite](https://unqlite.org/features.html) or similar (currently using Ruby PStore).
- [ ] Make CLI names consistent with API names. Eg: find vs. read. - [ ] Make CLI names consistent with API names. Eg: find vs. read.
- [ ] Create regexes in ::Lexer using strings and Regexp.new() for cleaner regexes. - [ ] Create regexes in ::Lexer using strings and Regexp.new() for cleaner regexes.
@ -65,7 +66,6 @@ Eg: `pigeon identity show` becomes `./pigeon-cli show`.
- [ ] Check block list before ingesting bundles. - [ ] Check block list before ingesting bundles.
- [ ] Handle the three outcomes of bundle ingestion: `ok`, `blocked`, `already_saved`. - [ ] Handle the three outcomes of bundle ingestion: `ok`, `blocked`, `already_saved`.
- [ ] add parsers and validators for all CLI inputs - [ ] add parsers and validators for all CLI inputs
- [ ] Remove all `.current` "singletons" / hacks
- [ ] Reduce whole darn repo into single module to aide portability. `::Helpers` module is OK. - [ ] Reduce whole darn repo into single module to aide portability. `::Helpers` module is OK.
- [ ] Use URNs instead of multihash? - [ ] Use URNs instead of multihash?
- [ ] Ensure all disks writes perform verification! - [ ] Ensure all disks writes perform verification!

2
spec/pigeon/message_spec.rb
View File

@ -93,8 +93,6 @@ RSpec.describe Pigeon::Message do
expect(m4.prev).to be expect(m4.prev).to be
end end
it "verifies accuracy of Lipmaa links"
it "does not allow message with more than 64 keys" do it "does not allow message with more than 64 keys" do
error = "Messages cannot have more than 64 keys. Got 65." error = "Messages cannot have more than 64 keys. Got 65."
body = {} body = {}