From 5e7968852f4a5fed2febbdb7967c5c5c1089ad30 Mon Sep 17 00:00:00 2001 From: Yaksh Bariya Date: Tue, 11 Oct 2022 14:01:46 +0530 Subject: [PATCH] chore(CONTRIBUTING.md): Remove unnecessary message for update and downgrade Earlier convention: upgpkg(/): update to Newer convention: upgpkg(/): Similarly same for dwnpkg. Thanks to @truboxl for the suggestion --- CONTRIBUTING.md | 6 +++--- scripts/bin/update-checksum | 4 ++-- scripts/updates/utils/termux_pkg_upgrade_version.sh | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 29f2c6d8b6..fd5b14ef95 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -351,17 +351,17 @@ Any line in the commit **should not exceed 80 characters**. In case it does, con Examples of good commit messages: 1. ``` - upgpkg(main/nodejs): upgrade to v18.2.0 + upgpkg(main/nodejs): v18.2.0 ``` 2. ``` - dwnpkg(main/htop): downgrade to v2.2.0 + dwnpkg(main/htop): v2.2.0 v3.x needs access to /proc/stat which is now restricted by Android ``` 3. ``` - enhance,upgpkg(main/nodejs): update to v18.2.0 and use shared libuv + enhance,upgpkg(main/nodejs): v18.2.0 and use shared libuv # Describe the technical reasons of how using shared libuv is beneficial ``` diff --git a/scripts/bin/update-checksum b/scripts/bin/update-checksum index 988ab3b568..9bf093713e 100755 --- a/scripts/bin/update-checksum +++ b/scripts/bin/update-checksum @@ -93,13 +93,13 @@ for package in "${@}"; do git --no-pager diff --patch "${buildsh_path}" echo "--------------------" echo - echo "upgpkg(${repo}/${package}): update to $(. "${buildsh_path}"; echo "${TERMUX_PKG_VERSION}" | cut -d: -f2-)" + echo "upgpkg(${repo}/${package}): $(. "${buildsh_path}"; echo "${TERMUX_PKG_VERSION}" | cut -d: -f2-)" echo read -re -p "Do you want to commit changes ? (y/n) " CHOICE echo if [[ ${CHOICE} =~ (Y|y) ]]; then git add "${buildsh_path}" - git commit -m "upgpkg(${repo}/${package}): update to $(. "${buildsh_path}"; echo "${TERMUX_PKG_VERSION}" | cut -d: -f2-)" + git commit -m "upgpkg(${repo}/${package}): $(. "${buildsh_path}"; echo "${TERMUX_PKG_VERSION}" | cut -d: -f2-)" else echo "Not committing to Git!" fi diff --git a/scripts/updates/utils/termux_pkg_upgrade_version.sh b/scripts/updates/utils/termux_pkg_upgrade_version.sh index 0acc9d51b1..be700db259 100755 --- a/scripts/updates/utils/termux_pkg_upgrade_version.sh +++ b/scripts/updates/utils/termux_pkg_upgrade_version.sh @@ -70,7 +70,7 @@ termux_pkg_upgrade_version() { echo "INFO: Committing package." stderr="$( git add "${TERMUX_PKG_BUILDER_DIR}" 2>&1 >/dev/null - git commit -m "upgpkg(${repo}/${TERMUX_PKG_NAME}): update to ${LATEST_VERSION}" \ + git commit -m "upgpkg(${repo}/${TERMUX_PKG_NAME}): ${LATEST_VERSION}" \ -m "This commit has been automatically submitted by Github Actions." 2>&1 >/dev/null )" || { termux_error_exit <<-EndOfError