aewens
/
tilde.news
forked from tildeverse/tilde.news
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
tilde.news/.rubocop.yml

224 lines
4.6 KiB
YAML
Raw Normal View History

warn against style churn because folks aren't seeing #460
2018-11-27 00:10:47 +00:00
# Please do not 'fix' style issues without a compelling, metrics-driven
# argument that a style change will materially improve cod equality.
# https://github.com/lobsters/lobsters/pull/460
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
# Project setup:
whitespace; shallow name
2018-11-24 22:43:43 +00:00
require: ./extras/prohibit_safe_navigation
Migrate deprecated form_tag and form_for to form_with See next commit for note on running view style checks.
2018-12-09 15:51:30 +00:00
require: ./extras/prohibit_form_for_and_form_tag
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
Rails:
Enabled: true
AllCops:
Include:
bump rubocop
2018-08-15 14:44:11 +00:00
- '**/*.rb'
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
- '**/Rakefile'
- '**/config.ru'
bump rubocop
2018-08-15 14:44:11 +00:00
- '**/*.rake'
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
Exclude:
rubocop: Gemfile, 46
2018-03-19 21:21:52 +00:00
- Gemfile
rubocop: Layout/EmptyLines*, 4797
2018-03-02 04:50:11 +00:00
- 'bin/**/*'
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
- 'db/**/*'
Ignore vendor directory Travis puts all the gems into vendor/ and then rubocop sees and complains about them.
2018-03-21 21:43:37 +00:00
- 'vendor/**/*'
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
# Cop configuration:
# Bundler
# Gemspec
# Layout
Layout/AccessModifierIndentation:
EnforcedStyle: outdent
rubocop: Layout/AlignArray, 127
2018-03-19 18:49:26 +00:00
Layout/AlignArray:
Enabled: false
rubocop: Layout/AlignHash, 468
2018-03-18 05:45:43 +00:00
Layout/AlignHash:
Enabled: false
rubocop: Style/NegatedIf, 3214
2018-03-02 15:25:26 +00:00
Layout/CaseIndentation:
EnforcedStyle: end
Layout/ElseAlignment:
Enabled: false
bump gems * Disabling a new linter that rubocop added * CommonMarker made SAFE the default * The FK support or the bump left some test data around between runs
2018-10-18 13:25:06 +00:00
Layout/EmptyLineAfterGuardClause:
Enabled: false
rubocop: Layout/EmptyLines*, 4797
2018-03-02 04:50:11 +00:00
Layout/EmptyLinesAroundExceptionHandlingKeywords:
Enabled: false
Merge branch 'rubocop'
2018-03-21 20:19:48 +00:00
Layout/EndAlignment:
EnforcedStyleAlignWith: variable
rubocop: Layout/IndentHash, 564
2018-03-18 00:10:04 +00:00
Layout/IndentHash:
EnforcedStyle: consistent
rubocop: Layout/MultilineMethodCallBraceLayout, 119
2018-03-19 18:57:21 +00:00
Layout/MultilineMethodCallBraceLayout:
Enabled: false
rubocop: Layout/SpaceBeforeBlockBraces and SpaceInsideBlockBraces, 2977
2018-03-13 02:47:24 +00:00
Layout/MultilineMethodCallIndentation:
Enabled: false
rubocop: Layout/SpaceAroundOperators, 150
2018-03-19 02:13:00 +00:00
Layout/SpaceAroundOperators:
Enabled: false
rubocop: Layout/SpaceBeforeBlockBraces and SpaceInsideBlockBraces, 2977
2018-03-13 02:47:24 +00:00
Layout/SpaceInsideBlockBraces:
EnforcedStyle: space
SpaceBeforeBlockParameters: false
rubocop: Layout/SpaceInsideRangeLiteral, 106
2018-03-19 19:17:02 +00:00
Layout/SpaceInsideRangeLiteral:
Enabled: false
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
# Lint
rubocop: Lint/HandleExceptions, 692 These are all parsing random input where ignoring errors is the right thing.
2018-03-14 16:59:32 +00:00
Lint/HandleExceptions:
Enabled: false
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
# Metrics
rubocop: Metrics/*, 655 Turned off everything but LineLength, which I bumped to 100 and manually tidied.
2018-03-14 15:47:35 +00:00
Metrics/AbcSize:
Enabled: false
Metrics/BlockLength:
Enabled: false
Metrics/BlockNesting:
Enabled: false
Metrics/ClassLength:
Enabled: false
Metrics/CyclomaticComplexity:
Enabled: false
Metrics/LineLength:
Max: 100
Metrics/MethodLength:
Enabled: false
Metrics/ModuleLength:
Enabled: false
Metrics/ParameterLists:
Enabled: false
Metrics/PerceivedComplexity:
Enabled: false
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
# Naming
rubocop: Naming/AccessorMethodName, 92
2018-03-19 19:43:20 +00:00
Naming/AccessorMethodName:
Enabled: false
Merge branch 'rubocop'
2018-03-21 20:19:48 +00:00
Naming/MemoizedInstanceVariableName:
Enabled: false
rubocop: Naming/PredicateName, 422
2018-03-18 05:49:40 +00:00
Naming/PredicateName:
Enabled: false
rubocop: Naming/VariableName, 85
2018-03-19 19:46:09 +00:00
# disabled until class vaiables in extras become constants
Merge branch 'rubocop'
2018-03-21 20:19:48 +00:00
Naming/UncommunicativeMethodParamName:
Enabled: false
rubocop: Naming/VariableName, 85
2018-03-19 19:46:09 +00:00
Naming/VariableName:
Enabled: false
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
# Performance
rubocop: Performance/HashEachMethods and Casecmp, 53
2018-03-19 21:20:13 +00:00
Performance/Casecmp:
Enabled: false
rubocop: Performance/RedundantMatch, 200 Absent a performance test, not worth the churn.
2018-03-19 01:10:32 +00:00
Performance/RedundantMatch:
Enabled: false
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
# Rails
rubocop: Rails/Blank, 278
2018-03-19 00:30:53 +00:00
Rails/Blank:
Enabled: false
rubocop: Rails/FilePath, 3303 We only know of running on Linux/BSD. Strange warning, even Windows supports using /.
2018-03-02 13:31:44 +00:00
Rails/FilePath:
Enabled: false
Merge branch 'rubocop'
2018-03-21 20:19:48 +00:00
Rails/HttpStatus:
Enabled: false
rubocop: Rails/OutputSafety, 268
2018-03-19 00:32:55 +00:00
Rails/OutputSafety:
Enabled: false
rubocop: Rails/Present, 252
2018-03-19 00:42:02 +00:00
Rails/Present:
UnlessBlank: false
rubocop: Rails/SkipsModelValidations, 253 We're intentionally calling these for performance reasons.
2018-03-19 00:39:06 +00:00
Rails/SkipsModelValidations:
Enabled: false
add rubocop, 4849 offenses
2018-03-02 04:30:57 +00:00
# Security
# Style
Merge branch 'rubocop'
2018-03-21 20:19:48 +00:00
Style/AndOr:
EnforcedStyle: conditionals
rubocop: Style/BlockDelimiters, 2861 Rubocop doesn't have an option for our style, which is semantic (braces when mapping) except for DSL usage.
2018-03-13 02:54:59 +00:00
Style/BlockDelimiters:
rubocop: Style/RedundantSelf, 2419 Disabling. The codebase almost always uses an explicit self receiver.
2018-03-13 03:16:53 +00:00
Enabled: false
update to current rspec-rails integration style
2018-03-21 20:36:49 +00:00
Style/BlockComments:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/CommentedKeyword:
Enabled: false
rubocop: Style/ClassVars, 135 This prevents bugs, but we avoid inheritance and I don't want a larger edit. Looks like all of these should just be replaced with comments naming constants the class needs from production.rb.
2018-03-19 17:27:06 +00:00
Style/ClassVars:
Enabled: false
rubocop: Style/ConditionalAssignment, 549
2018-03-18 00:22:35 +00:00
Style/ConditionalAssignment:
Enabled: false
rubocop: Style/Documentation, 2270
2018-03-14 13:01:14 +00:00
# It would be nice to have this on, but I'm not up for writing 66 of these in
# the process of addressing the initial 4,489 cop warnings.
Style/Documentation:
Enabled: false
Exclude: [db/migrate/**/*, spec/**/*, test/**/*]
rubocop: Style/DoubleNegation, 57
2018-03-19 21:18:04 +00:00
Style/DoubleNegation:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/EachWithObject:
Enabled: false
Merge branch 'rubocop'
2018-03-21 20:19:48 +00:00
Style/ExpandPathArguments:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/FormatString:
Enabled: false
rubocop: Style/FrozenStringLiteralComment, 1396 It's a transitional thing, let future me suffer with Ruby 3.0.
2018-03-14 14:11:03 +00:00
Style/FrozenStringLiteralComment:
EnforcedStyle: never
rubocop: Style/GuardClause, 620 Many false positives where the supposed guard clause has an else.
2018-03-16 22:55:39 +00:00
Style/GuardClause:
Enabled: false
rubocop: Style/HashSyntax, 1604 I'm endlessly amused that we had 666 offenses against the default style.
2018-03-14 14:06:28 +00:00
Style/HashSyntax:
EnforcedStyle: no_mixed_keys
Merge branch 'rubocop'
2018-03-21 20:19:48 +00:00
Style/IfInsideElse:
Enabled: false
rubocop: Style/IfUnlessModifier, 3303 Codebase doesn't use these often and definitely doesn't prefer them.
2018-03-03 05:35:08 +00:00
Style/IfUnlessModifier:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/InverseMethods:
Enabled: false
Style/Lambda:
Enabled: false
rubocop: Style/RegexpLiteral, 534
2018-03-18 00:26:56 +00:00
Style/LineEndConcatenation:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/MethodDefParentheses:
Enabled: false
Style/MultilineBlockChain:
Enabled: false
Style/MultilineTernaryOperator:
Enabled: false
rubocop: Style/IfUnlessModifier, 3303 Codebase doesn't use these often and definitely doesn't prefer them.
2018-03-03 05:35:08 +00:00
Style/NegatedIf:
EnforcedStyle: postfix
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/NegatedWhile:
Enabled: false
Style/Next:
Enabled: false
Style/NonNilCheck:
Enabled: false
rubocop: Style/NumericPredicate, 444
2018-03-18 05:47:10 +00:00
Style/NumericPredicate:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/ParallelAssignment:
Enabled: false
Style/PercentLiteralDelimiters:
Enabled: false
rubocop: Style/PerlBackrefs, 63
2018-03-19 21:14:05 +00:00
Style/PerlBackrefs:
Enabled: false
rubocop: Style/RaiseArgs, 158
2018-03-19 02:07:20 +00:00
Style/RaiseArgs:
EnforcedStyle: compact
rubocop: Style/IdenticalConditionalBranches, 65
2018-03-19 21:08:54 +00:00
Style/RedundantBegin:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/RedundantParentheses:
Enabled: false
rubocop: Style/RedundantReturn, 3307
2018-03-02 13:27:49 +00:00
Style/RedundantReturn:
Enabled: false
rubocop: Style/RedundantSelf, 2419 Disabling. The codebase almost always uses an explicit self receiver.
2018-03-13 03:16:53 +00:00
Style/RedundantSelf:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/RescueModifier:
Enabled: false
rubocop: Style/RescueStandardError, 401
2018-03-18 05:50:41 +00:00
Style/RescueStandardError:
EnforcedStyle: implicit
rubocop: Style/RegexpLiteral, 534
2018-03-18 00:26:56 +00:00
Style/RegexpLiteral:
AllowInnerSlashes: true
rubocop: Style/SafeNavigation, 305 nil is supposed to hurt
2018-03-19 00:15:55 +00:00
Style/SafeNavigation:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/SignalException:
Enabled: false
rubocop: Style/StringLiterals, 3382
2018-03-02 05:07:29 +00:00
Style/StringLiterals:
Enabled: false
rubocop: Style/SymbolArray, 357
2018-03-18 06:05:29 +00:00
Style/SymbolArray:
EnforcedStyle: brackets
rubocop: Style/TrailingCommaInArguments, 211 Doesn't have an option for "required, except on a one-line multiline call.
2018-03-19 01:06:44 +00:00
Style/TrailingCommaInArguments:
Enabled: false
Merge branch 'rubocop'
2018-03-21 20:19:48 +00:00
Style/TrailingCommaInArrayLiteral:
EnforcedStyleForMultiline: consistent_comma
Style/TrailingCommaInHashLiteral:
rubocop: Style/Documentation, 2270
2018-03-14 13:01:14 +00:00
EnforcedStyleForMultiline: consistent_comma
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/WhileUntilDo:
Enabled: false
Style/WhileUntilModifier:
Enabled: false
Style/WordArray:
Enabled: false
rubocop: disable Style/YodaCondition Redundant with https://github.com/rubocop-hq/ruby-style-guide#safe-assignment-in-condition
2018-09-06 16:07:04 +00:00
Style/YodaCondition:
Enabled: false
rubocop: Style, 0
2018-03-19 21:53:47 +00:00
Style/ZeroLengthPredicate:
Enabled: false