aewens
/
tilde.news
forked from tildeverse/tilde.news
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,733 Commits 3 Branches 0 Tags 2.8 MiB
Commit Graph

56 Commits

Author SHA1 Message Date
Abdullah Samman 089f3475ba Migrate deprecated form_tag and form_for to form_with 
See next commit for note on running view style checks.
 2018-12-09 09:51:30 -06:00
Peter Bhat Harkins 922ef94cb7 warn against style churn because folks aren't seeing #460 2018-11-26 18:12:40 -06:00
Peter Bhat Harkins 1e5a7fc81f whitespace; shallow name 2018-11-24 16:43:43 -06:00
SengMing Tan 0b6476e4ce add rubocop cop to prevent the safe navigation operator 
Close #596
 2018-11-24 16:41:09 -06:00
Peter Bhat Harkins 4620a9221b bump gems 
* Disabling a new linter that rubocop added
 * CommonMarker made SAFE the default
 * The FK support or the bump left some test data around between runs
 2018-10-18 08:25:06 -05:00
Peter Bhat Harkins e553d9c7fd rubocop: disable Style/YodaCondition 
Redundant with https://github.com/rubocop-hq/ruby-style-guide#safe-assignment-in-condition
 2018-09-06 11:07:04 -05:00
Thomas Dziedzic 998a721d72 bump rubocop 2018-08-15 14:44:11 +00:00
Hunter Madison d49968f57a Ignore vendor directory 
Travis puts all the gems into vendor/ and then rubocop sees and complains about them.
 2018-03-21 16:43:37 -05:00
Peter Bhat Harkins c0393457a4 update to current rspec-rails integration style 2018-03-21 15:37:41 -05:00
Peter Bhat Harkins 604713e97c Merge branch 'rubocop' 2018-03-21 15:19:48 -05:00
Peter Bhat Harkins 7b5bfdd75d rubocop: Style, 0 2018-03-19 16:53:47 -05:00
Peter Bhat Harkins 664cc829f0 rubocop: Gemfile, 46 2018-03-19 16:21:52 -05:00
Peter Bhat Harkins 1ce59c2482 rubocop: Performance/HashEachMethods and Casecmp, 53 2018-03-19 16:20:13 -05:00
Peter Bhat Harkins 3ef5f6c16f rubocop: Style/DoubleNegation, 57 2018-03-19 16:18:04 -05:00
Peter Bhat Harkins ceb1284d34 rubocop: Style/PerlBackrefs, 63 2018-03-19 16:15:04 -05:00
Peter Bhat Harkins 62da0b0165 rubocop: Style/IdenticalConditionalBranches, 65 2018-03-19 16:11:36 -05:00
Peter Bhat Harkins 8f8b19a162 rubocop: Naming/VariableName, 85 2018-03-19 14:46:09 -05:00
Peter Bhat Harkins ad8a8b7a0c rubocop: Naming/AccessorMethodName, 92 2018-03-19 14:43:20 -05:00
Peter Bhat Harkins 1bc23c7f6b rubocop: Layout/SpaceInsideRangeLiteral, 106 2018-03-19 14:17:02 -05:00
Peter Bhat Harkins 21e12dcd89 rubocop: Layout/MultilineMethodCallBraceLayout, 119 2018-03-19 13:57:21 -05:00
Peter Bhat Harkins ff7db7c34d rubocop: Layout/AlignArray, 127 2018-03-19 13:49:26 -05:00
Peter Bhat Harkins 9fb32cb3e4 rubocop: Style/ClassVars, 135 
This prevents bugs, but we avoid inheritance and I don't want a larger edit.
Looks like all of these should just be replaced with comments naming constants
the class needs from production.rb.
 2018-03-19 12:27:06 -05:00
Peter Bhat Harkins 970955d7e5 rubocop: Layout/SpaceAroundOperators, 150 2018-03-19 10:00:27 -05:00
Peter Bhat Harkins e594a47c91 rubocop: Style/RaiseArgs, 158 2018-03-19 10:00:27 -05:00
Peter Bhat Harkins d59e3017f5 rubocop: Performance/RedundantMatch, 200 
Absent a performance test, not worth the churn.
 2018-03-19 10:00:27 -05:00
Peter Bhat Harkins 746b5fb0fd rubocop: Style/TrailingCommaInArguments, 211 
Doesn't have an option for "required, except on a one-line multiline call.
 2018-03-19 10:00:27 -05:00
Peter Bhat Harkins f381d1d553 rubocop: Rails/Present, 252 2018-03-18 19:42:02 -05:00
Peter Bhat Harkins dab0b933c9 rubocop: Rails/SkipsModelValidations, 253 
We're intentionally calling these for performance reasons.
 2018-03-18 19:39:06 -05:00
Peter Bhat Harkins a82abe4412 rubocop: Rails/OutputSafety, 268 2018-03-18 19:32:55 -05:00
Peter Bhat Harkins b41116c825 rubocop: Rails/Blank, 278 2018-03-18 19:30:53 -05:00
Peter Bhat Harkins b7ca092238 rubocop: Style/SafeNavigation, 305 
nil is supposed to hurt
 2018-03-18 19:15:55 -05:00
Peter Bhat Harkins ccca17b045 rubocop: Style/SymbolArray, 357 2018-03-18 01:07:08 -05:00
Peter Bhat Harkins 52c8c2258d rubocop: Style/RescueStandardError, 401 2018-03-18 01:07:05 -05:00
Peter Bhat Harkins cea37fd613 rubocop: Naming/PredicateName, 422 2018-03-18 00:49:40 -05:00
Peter Bhat Harkins 091798a0a7 rubocop: Style/NumericPredicate, 444 2018-03-18 00:47:10 -05:00
Peter Bhat Harkins f237cefeaa rubocop: Layout/AlignHash, 468 2018-03-18 00:45:43 -05:00
Peter Bhat Harkins 7998e6f0a0 rubocop: Style/RegexpLiteral, 534 2018-03-17 19:26:56 -05:00
Peter Bhat Harkins 7e72b8db13 rubocop: Style/ConditionalAssignment, 549 2018-03-17 19:22:35 -05:00
Peter Bhat Harkins 470ebc9d43 rubocop: Layout/IndentHash, 564 2018-03-17 19:10:04 -05:00
Peter Bhat Harkins 41887aa915 rubocop: Style/GuardClause, 620 
Many false positives where the supposed guard clause has an else.
 2018-03-17 14:07:44 -05:00
Peter Bhat Harkins 8785d2d327 rubocop: Lint/HandleExceptions, 692 
These are all parsing random input where ignoring errors is the right thing.
 2018-03-17 14:07:15 -05:00
Peter Bhat Harkins a15c5d540e rubocop: Metrics/*, 655 
Turned off everything but LineLength, which I bumped to 100 and manually
tidied.
 2018-03-17 14:05:46 -05:00
Peter Bhat Harkins 6a8629009c rubocop: Style/LineEndConcatenation, 1281 2018-03-17 14:05:21 -05:00
Peter Bhat Harkins 8138d9e7a4 rubocop: Style/FrozenStringLiteralComment, 1396 
It's a transitional thing, let future me suffer with Ruby 3.0.
 2018-03-17 14:04:59 -05:00
Peter Bhat Harkins 69df281738 rubocop: Style/HashSyntax, 1604 
I'm endlessly amused that we had 666 offenses against the default style.
 2018-03-17 14:04:35 -05:00
Peter Bhat Harkins 7a4a4a738f rubocop: Style/Documentation, 2270 2018-03-17 14:04:07 -05:00
Peter Bhat Harkins 4eb6c5cfdc rubocop: Style/RedundantSelf, 2419 
Disabling. The codebase almost always uses an explicit self receiver.
 2018-03-17 14:03:21 -05:00
Peter Bhat Harkins 123851b821 rubocop: Style/BlockDelimiters, 2861 
Rubocop doesn't have an option for our style, which is semantic (braces when
mapping) except for DSL usage.
 2018-03-17 14:02:53 -05:00
Peter Bhat Harkins b1f83f545f rubocop: Layout/SpaceBeforeBlockBraces and SpaceInsideBlockBraces, 2977 2018-03-16 16:41:09 -06:00
Peter Bhat Harkins 564e593862 rubocop: Style/IfUnlessModifier, 3303 
Codebase doesn't use these often and definitely doesn't prefer them.
 2018-03-02 23:35:08 -06:00