Commit Graph

96 Commits

Author SHA1 Message Date
Brian Kung
efe3505811 Replace images in story description with text links
Fix #645
2019-03-20 08:04:26 -05:00
Peter Bhat Harkins
c6759f3780 meet the new cop, same as the old cop 2018-12-22 10:42:41 -06:00
Abdullah Samman
089f3475ba Migrate deprecated form_tag and form_for to form_with
See next commit for note on running view style checks.
2018-12-09 09:51:30 -06:00
Guillaume Briday
70e8eef8d8 don't try to load rubocop in prod
Fix #599
2018-12-05 08:24:46 -06:00
Peter Bhat Harkins
1e5a7fc81f whitespace; shallow name 2018-11-24 16:43:43 -06:00
SengMing Tan
0b6476e4ce add rubocop cop to prevent the safe navigation operator
Close #596
2018-11-24 16:41:09 -06:00
Peter Bhat Harkins
0724c706fc name exceptions so we can ignore most of them
Now that we've had this in prod a while I've collected a few transient DNS
issues. Because webmentions are a nice-to-have, we can just drop the mention
if someone's DNS is flaking on us. We let BadIPsError hit logs because it
might be someone attempting to use this to enumerate our internal network
(tho it's most likely misconfiguration).
2018-11-20 08:18:10 -06:00
Peter Bhat Harkins
4620a9221b bump gems
* Disabling a new linter that rubocop added
 * CommonMarker made SAFE the default
 * The FK support or the bump left some test data around between runs
2018-10-18 08:25:06 -05:00
Peter Bhat Harkins
5e6f1e6455 send webmentions
Merge #535
2018-10-03 10:16:50 -05:00
Christian Wesselhoeft
d25ecf41a0 EmailParser: Make content-type regex case-insensitive 2018-09-26 08:19:05 -05:00
Peter Bhat Harkins
01f4b8d614 update to jump through new twitter hoop
https://twittercommunity.com/t/action-required-sign-in-with-twitter-users-must-whitelist-callback-urls/105342
2018-06-19 09:45:35 -05:00
Peter Bhat Harkins
ebaf658819 new tweet length 2018-06-19 09:26:20 -05:00
Peter Bhat Harkins
cc81559610 Fix feed validation errors
W3C's feed validator service said:
1. Author should be an email address
2. Don't use relative links in <description>
3. Include a link with rel="self"
2018-04-04 09:48:25 -05:00
Peter Bhat Harkins
9554e41cee rubocop: Metrics/LineLength, 71 2018-03-19 16:01:05 -05:00
Peter Bhat Harkins
688974e059 rubocop: Lint/UriEscapeUnescape, 81 2018-03-19 15:11:00 -05:00
Peter Bhat Harkins
4e7ed9a7a4 rubocop: Layout/IndentationWidth, 94 2018-03-19 14:34:27 -05:00
Peter Bhat Harkins
e916cf73eb rubocop: Layout/FirstParameterIndentation, 98 2018-03-19 14:26:14 -05:00
Peter Bhat Harkins
6ae3b6b241 rubocop: Layout/BlockEndNewline, 102 2018-03-19 14:20:24 -05:00
Peter Bhat Harkins
deab0e7967 rubocop: Layout/ExtraSpacing, 142 2018-03-19 10:00:27 -05:00
Peter Bhat Harkins
e594a47c91 rubocop: Style/RaiseArgs, 158 2018-03-19 10:00:27 -05:00
Peter Bhat Harkins
5b3478dee9 rubocop: Layout/SpaceAfterComma, 189
We had a space after comma in block args the same number of times as not (11),
and having this on enforces where we're consistent in args, arrays, and hashes.
2018-03-19 10:00:27 -05:00
Peter Bhat Harkins
bf1885d87c rubocop: Style/SymbolProc, 374
There were 18 &:foo and 19 {|x| x.foo}, so I updated to the new idiom.
2018-03-18 01:07:08 -05:00
Peter Bhat Harkins
52c8c2258d rubocop: Style/RescueStandardError, 401 2018-03-18 01:07:05 -05:00
Peter Bhat Harkins
a896094b85 rubocop: Style/MutableConstant, 513
We didn't do this anywhere, but it's a cheap way to prevent some bugs.
2018-03-17 19:37:50 -05:00
Peter Bhat Harkins
1dabae1d0f rubocop: Style/BracesAroundHashParameters, 527 2018-03-17 19:31:06 -05:00
Peter Bhat Harkins
fb0a4424e5 rubocop: Lint/AssignmentInCondition, 669 2018-03-17 14:07:35 -05:00
Peter Bhat Harkins
5ac4c48223 rubocop: Lint/UselessAssignment, 685 2018-03-17 14:07:26 -05:00
Peter Bhat Harkins
23671c154d rubocop: Lint/StringConversionInInterpolation, 707 2018-03-17 14:06:34 -05:00
Peter Bhat Harkins
bf4327de49 rubocop: Layout/AlignParameters, 708
Seriously considered renaming vote_thusly_on_story_or_comment_for_user_because
just becaues of how many weird linewraps it causes.
2018-03-17 14:06:21 -05:00
Peter Bhat Harkins
a15c5d540e rubocop: Metrics/*, 655
Turned off everything but LineLength, which I bumped to 100 and manually
tidied.
2018-03-17 14:05:46 -05:00
Peter Bhat Harkins
113bb5e9cc rubocop: Layout/MultilineOperationIndentation, 1208 2018-03-17 14:05:32 -05:00
Peter Bhat Harkins
8138d9e7a4 rubocop: Style/FrozenStringLiteralComment, 1396
It's a transitional thing, let future me suffer with Ruby 3.0.
2018-03-17 14:04:59 -05:00
Peter Bhat Harkins
7a4a4a738f rubocop: Style/Documentation, 2270 2018-03-17 14:04:07 -05:00
Peter Bhat Harkins
b1f83f545f rubocop: Layout/SpaceBeforeBlockBraces and SpaceInsideBlockBraces, 2977 2018-03-16 16:41:09 -06:00
Peter Bhat Harkins
5476a77aef rubocop: Layout/EmptyLines*, 4797 2018-03-01 22:50:11 -06:00
Peter Bhat Harkins
83b0cced0a remove dead Countinual code 2017-11-27 10:16:18 -05:00
joshua stein
1f5d2d4587 Markdowner: html doc might have no body
In the case of some bogus markdown, like just "<script>..." text
2017-09-20 09:16:45 -05:00
Adam Hess
28c8217652 Upgrade rails 5 1 (#367)
* Upgrade to rails 5.1

- Update versions of dependencies
- Switch before_filter to before_action
- Use render plain rather than render text

* Generate new rails 5.1 scripts
2017-06-18 11:04:32 -05:00
joshua stein
ac6b9f5963 countinual: new ip for api.countinual.com 2017-06-07 15:51:42 -05:00
joshua stein
32aa58fc98 Sponge: set limit on get/post time 2017-06-05 11:18:43 -05:00
joshua stein
138e4e37cc users: re-enable username '@' linking in user profiles
now there is a separate twitter section so users can use that
2017-04-19 21:02:31 -05:00
joshua stein
8b446fadae add twitter oauth linking 2017-04-13 15:32:32 -05:00
Yuki Izumi
e4de78ac95
Default to nofollow if URI parse fails 2017-04-13 11:28:42 +10:00
Yuki Izumi
f2695faf1f
Add nofollow when host is missing 2017-04-13 11:26:43 +10:00
Yuki Izumi
555de9e243
Extract username regex 2017-04-13 11:26:32 +10:00
Yuki Izumi
bcbb9939f4
We want strikethrough too 2017-04-12 23:33:17 +10:00
Yuki Izumi
6894ac5116
Fix up user links 2017-04-12 23:33:17 +10:00
Yuki Izumi
fa70ab147c
Simple replacement with CommonMarker 2017-04-12 22:53:51 +10:00
joshua stein
af6466e600 Story: move archive URL to model, escape URL in case it has query params 2017-04-11 16:49:26 -05:00
joshua stein
fcb2443938 settings: add github integration, move pushover to external accounts 2017-03-24 16:31:25 -05:00