akkartik
/
mu
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bug: null address messing up instruction decode 

Leads to a bad error message.
This commit is contained in:
Kartik Agaram 2019-07-09 18:02:44 -07:00
parent 4a96b659ff
commit 58d03e437a
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
subx/014indirect_addressing.cc
View File

@ -874,7 +874,7 @@ void test_add_r32_to_mem_at_r32_plus_disp8() {
}
:(before "End Mod Special-cases(addr)")
case 1: // indirect + disp8 addressing
case 1: { // indirect + disp8 addressing
switch (rm) {
default:
addr = Reg[rm].u;
@ -882,11 +882,16 @@ case 1: // indirect + disp8 addressing
break;
// End Mod 1 Special-cases(addr)
}
int8_t displacement = static_cast<int8_t>(next());
if (addr > 0) {
addr += static_cast<int8_t>(next());
addr += displacement;
trace(Callstack_depth+1, "run") << "effective address is 0x" << HEXWORD << addr << " (after adding disp8)" << end();
}
else {
trace(Callstack_depth+1, "run") << "null address; skipping displacement" << end();
}
break;
}
:(code)
void test_add_r32_to_mem_at_r32_plus_negative_disp8() {