From aa09f294192e7c481f40b1fd4660a67f4076a339 Mon Sep 17 00:00:00 2001
From: Kartik Agaram <vc@akkartik.com>
Date: Fri, 28 Jun 2019 18:24:44 -0700
Subject: [PATCH] .

---
 subx/apps/assort.subx | 2 ++
 subx/apps/survey.subx | 1 +
 2 files changed, 3 insertions(+)

diff --git a/subx/apps/assort.subx b/subx/apps/assort.subx
index 55f0c9a8..cb34120a 100644
--- a/subx/apps/assort.subx
+++ b/subx/apps/assort.subx
@@ -82,6 +82,7 @@ $main:end:
 
 # data structure:
 #   table: (address stream {string, (address stream byte)})     (8 bytes per row)
+# inefficient; uses sequential search for looking up segments by name
 
 convert:  # in : (address buffered-file), out : (address buffered-file) -> <void>
     # pseudocode:
@@ -433,6 +434,7 @@ test-convert:
     5d/pop-to-EBP
     c3/return
 
+# beware: leaks memory (one name per segment read)
 read-segments:  # in : (address buffered-file), table : (address stream {string, (address stream byte)})
     # pseudocode:
     #   var curr-segment = null
diff --git a/subx/apps/survey.subx b/subx/apps/survey.subx
index 579dfbad..cf13b0b2 100644
--- a/subx/apps/survey.subx
+++ b/subx/apps/survey.subx
@@ -106,6 +106,7 @@ $main:end:
 #   segments: (address stream {string, segment-info})     (16 bytes per row)
 #   label-info: {segment-name, segment-offset, address}   (12 bytes)
 #   labels: (address stream {string, label-info})         (16 bytes per row)
+# these are all inefficient; use sequential scans for lookups
 
 convert:  # in : (address buffered-file), out : (address buffered-file) -> <void>
     # pseudocode