4a943d4ed3
I've been saying for a while[1][2][3] that adding extra abstractions makes things harder for newcomers, and adding new notations doubly so. And then I notice this DSL in my own backyard. Makes me feel like a hypocrite. [1] https://news.ycombinator.com/item?id=13565743#13570092 [2] https://lobste.rs/s/to8wpr/configuration_files_are_canary_warning [3] https://lobste.rs/s/mdmcdi/little_languages_by_jon_bentley_1986#c_3miuf2 The implementation of the DSL was also highly hacky: a) It was happening in the tangle/ tool, but was utterly unrelated to tangling layers. b) There were several persnickety constraints on the different kinds of lines and the specific order they were expected in. I kept finding bugs where the translator would silently do the wrong thing. Or the error messages sucked, and readers may be stuck looking at the generated code to figure out what happened. Fixing error messages would require a lot more code, which is one of my arguments against DSLs in the first place: they may be easy to implement, but they're hard to design to go with the grain of the underlying platform. They require lots of iteration. Is that effort worth prioritizing in this project? On the other hand, the DSL did make at least some readers' life easier, the ones who weren't immediately put off by having to learn a strange syntax. There were fewer quotes to parse, fewer backslash escapes. Anyway, since there are also people who dislike having to put up with strange syntaxes, we'll call that consideration a wash and tear this DSL out. --- This commit was sheer drudgery. Hopefully it won't need to be redone with a new DSL because I grow sick of backslashes.
80 lines
1.5 KiB
C++
80 lines
1.5 KiB
C++
//: A few literal constants.
|
|
|
|
:(before "End Mu Types Initialization")
|
|
put(Type_ordinal, "literal-boolean", 0);
|
|
|
|
//: 'true'
|
|
|
|
:(code)
|
|
void test_true() {
|
|
load(
|
|
"def main [\n"
|
|
" 1:boolean <- copy true\n"
|
|
"]\n"
|
|
);
|
|
CHECK_TRACE_CONTENTS(
|
|
"parse: ingredient: {true: \"literal-boolean\"}\n"
|
|
);
|
|
}
|
|
|
|
:(before "End Parsing reagent")
|
|
if (name == "true") {
|
|
if (type != NULL) {
|
|
raise << "'true' is a literal and can't take a type\n" << end();
|
|
return;
|
|
}
|
|
type = new type_tree("literal-boolean");
|
|
set_value(1);
|
|
}
|
|
|
|
//: 'false'
|
|
|
|
:(code)
|
|
void test_false() {
|
|
load(
|
|
"def main [\n"
|
|
" 1:boolean <- copy false\n"
|
|
"]\n"
|
|
);
|
|
CHECK_TRACE_CONTENTS(
|
|
"parse: ingredient: {false: \"literal-boolean\"}\n"
|
|
);
|
|
}
|
|
|
|
:(before "End Parsing reagent")
|
|
if (name == "false") {
|
|
if (type != NULL) {
|
|
raise << "'false' is a literal and can't take a type\n" << end();
|
|
return;
|
|
}
|
|
type = new type_tree("literal-boolean");
|
|
set_value(0);
|
|
}
|
|
|
|
//: 'null'
|
|
|
|
:(before "End Mu Types Initialization")
|
|
put(Type_ordinal, "literal-address", 0);
|
|
|
|
:(code)
|
|
void test_null() {
|
|
load(
|
|
"def main [\n"
|
|
" 1:address:number <- copy null\n"
|
|
"]\n"
|
|
);
|
|
CHECK_TRACE_CONTENTS(
|
|
"parse: ingredient: {null: \"literal-address\"}\n"
|
|
);
|
|
}
|
|
|
|
:(before "End Parsing reagent")
|
|
if (name == "null") {
|
|
if (type != NULL) {
|
|
raise << "'null' is a literal and can't take a type\n" << end();
|
|
return;
|
|
}
|
|
type = new type_tree("literal-address");
|
|
set_value(0);
|
|
}
|