From c4333b8da5db1c0daf6aa2e1f2e06da1efb3c707 Mon Sep 17 00:00:00 2001 From: "Kartik K. Agaram" Date: Thu, 7 Dec 2023 01:06:19 -0800 Subject: [PATCH 1/2] minor tweaks to manual tests while pushing to all forks --- Manual_tests.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Manual_tests.md b/Manual_tests.md index 582de20..650bc76 100644 --- a/Manual_tests.md +++ b/Manual_tests.md @@ -17,8 +17,9 @@ Initializing settings: - start out editing source, move window, press ctrl+e twice; window is editing source in same position+dimensions - no log file; switching to source works - - run with an untested version. Error message pops up and waits for a key. The app attempts to continue, and doesn't receive the key. + - run with an untested version of LÖVE. Error message pops up and waits for a key. The app attempts to continue, and doesn't receive the key. - run with a LÖVE v12 release candidate. No errors; it is a supported version. All tests pass. + - create a couple of spuriously failing tests. Run with an untested version of LÖVE. Error message includes message about untested version. Code loading: * run love with directory; text editor runs @@ -30,8 +31,7 @@ Code loading: - analogously, how a shape precisely looks as you draw it * start out running the text editor, press ctrl+e to edit source, make a change to the source, press ctrl+e twice to return to the source editor; the change should be preserved. -* run with an untested version. Error message pops up. Press a key. Text editor comes up, and doesn't receive the key. Press ctrl+e. Error pops up. Press a key. Source editor opens up. Press ctrl+e. Error pops up. Press a key. Text editor returns. -* create a couple of spuriously failing tests. Run with an untested version. Error message includes message about untested version. +* run with an untested version of LÖVE. Error message pops up. Press a key. Text editor comes up, and doesn't receive the key. Press ctrl+e. Error pops up. Press a key. Source editor opens up. Press ctrl+e. Error pops up. Press a key. Text editor returns. ### Other compromises From 366d806515a724d2ad46900de235e42349d181d0 Mon Sep 17 00:00:00 2001 From: "Kartik K. Agaram" Date: Thu, 7 Dec 2023 01:08:09 -0800 Subject: [PATCH 2/2] copy correct warning message Not really useful here, but other forks might make use of it. --- main.lua | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/main.lua b/main.lua index cf76a19..82a8f2d 100644 --- a/main.lua +++ b/main.lua @@ -219,7 +219,7 @@ function App.keychord_press(chord, key) Skip_rest_of_key_events = nil if current_app_is_warning() then if chord == 'C-c' then - love.system.setClipboardText(Error_message) + love.system.setClipboardText(warning_message()) else clear_warning() Skip_rest_of_key_events = true @@ -367,3 +367,8 @@ function clear_warning() assert(type(Current_app) == 'table') Current_app = Current_app.next_app end + +function warning_message() + assert(type(Current_app) == 'table') + return Current_app.message +end