Commit Graph

700 Commits

Author SHA1 Message Date
Kartik K. Agaram 826207a54a link to export tool 2022-07-02 15:23:44 -07:00
Kartik K. Agaram df5b7a8245 deemphasize the terminal in Readme 2022-07-01 20:34:13 -07:00
Kartik K. Agaram 9fd82439ec drop stale flag from documentation 2022-07-01 20:28:05 -07:00
Kartik K. Agaram 53c35241fb ugh, handle absolute as well as relative paths 2022-07-01 13:56:17 -07:00
Kartik K. Agaram f311013200 include CWD when saving filename 2022-07-01 12:31:23 -07:00
Kartik K. Agaram 914d9c6f98 bugfix: clicking on empty lines 2022-07-01 12:16:43 -07:00
Kartik K. Agaram 79df3da04b enforce press/release state only processed once
bugfix scenario:
  press pageup
  click somewhere near the bottom

Before this change the selection was flickering when doing this.
2022-07-01 11:42:54 -07:00
Kartik K. Agaram e839c3036a bugfix: manage screen_top and cursor when resizing 2022-07-01 11:01:20 -07:00
Kartik K. Agaram 37c5ab87ec bugfix: enable resize when loading settings 2022-06-30 23:02:24 -07:00
Kartik K. Agaram 429a42eb1c right margin 2022-06-30 22:54:34 -07:00
Kartik K. Agaram da3f6c65b3 start loading settings as applicable 2022-06-30 22:46:45 -07:00
Kartik K. Agaram b40dab67f2 start saving some settings to disk on quit
We're still not reading them anywhere.
2022-06-30 22:20:16 -07:00
Kartik K. Agaram 2025172e52 initialize screen width to something reasonable 2022-06-30 22:04:27 -07:00
Kartik K. Agaram 0cd678581b rip out geometry commandline arg
Let's try really hard to ignore the terminal.
2022-06-30 22:02:31 -07:00
Kartik K. Agaram 86cef33630 use the background color
I'd hoped this would reduce the blocks of black while resizing, but it
doesn't seem to have made a difference.
2022-06-30 21:59:17 -07:00
Kartik K. Agaram e1a49c216e stop blanking screen while resizing 2022-06-30 21:56:21 -07:00
Kartik K. Agaram 8c7bea8f76 rip out notion of Line_width 2022-06-30 19:50:27 -07:00
Kartik K. Agaram 08a50b7fff rip out the line-width slider
New plan:
  - render text across the whole window
  - let people resize the window to the desired line width
  - save window size settings between sessions
2022-06-30 19:36:37 -07:00
Kartik K. Agaram 510b0d1dc3 bugfix: lines that aren't drawn from the start
I can't believe I didn't catch this until now. All I had to do is open
MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout,
press page-down and click on the top screen line (or any screen line
containing the same line as the top screen line). Easy to catch with any
file containing lots of overly long lines, as happens in particular at
the start of Moby Dick.

I _had_ seen this problem before, but it seemed to disappear after
unrelated changes, and I convinced myself I'd fixed it as a side-effect.
The bug just failed to manifest if the top line happened to start at the
top of the screen. Scroll down a few pages in Moby Dick and the dialogue
starts and line length drops precipitously.
2022-06-30 18:14:48 -07:00
Kartik K. Agaram 98fa46bf99 some redundant calls 2022-06-30 17:44:31 -07:00
Kartik K. Agaram d009390cc4 bugfix: save previous file when dropping a new one on 2022-06-29 17:58:58 -07:00
Kartik K. Agaram bfbe73e0ef new test: dragging and dropping a file on lines.love 2022-06-29 17:52:40 -07:00
Kartik K. Agaram 9410cccb08 avoid redundant writes on exit 2022-06-29 17:36:56 -07:00
Kartik K. Agaram feba7bf3c2 clarify what "large files" means 2022-06-29 17:34:44 -07:00
Kartik K. Agaram ea4aa0999c clicking to the right of a line within line width 2022-06-29 09:30:23 -07:00
Kartik K. Agaram d07a336131 . 2022-06-29 09:17:38 -07:00
Kartik K. Agaram 8d3adfa36d bugfix: clicking past end of screen line
I could swear I checked this at some point. But I didn't have a test!
2022-06-29 09:17:38 -07:00
Kartik K. Agaram b49ff8dde9 bugfix: scrolling in left/right movements
I'd always had a funny feeling there was something missing there but
somehow never thought of the right failing test.
2022-06-28 18:48:59 -07:00
Kartik K. Agaram 938e3ca1bb when naming points, allow backspacing back to '' 2022-06-27 17:36:10 -07:00
Kartik K. Agaram e63878897e undo commit 861c57b533
Turns out ctrl+ makes it into lua.textinput. Thanks John Blommers for
the report. This should fix https://github.com/akkartik/lines.love/issues/6.
2022-06-27 17:32:52 -07:00
Kartik K. Agaram 83ba9e61d1 bugfix: typing a capital letter deletes selection 2022-06-26 17:07:27 -07:00
Kartik K. Agaram 44fb3ecd55 bugfix: deleting a selection spanning pages 2022-06-26 16:34:06 -07:00
Kartik K. Agaram 2233066409 bugfix: clear selection in a couple more places 2022-06-23 12:06:44 -07:00
Kartik K. Agaram 84875f3c43 bugfix: don't delete selection when moving cursor 2022-06-23 12:05:36 -07:00
Kartik K. Agaram da9d948615 record one more case I can't automatically detect 2022-06-23 11:41:29 -07:00
Kartik K. Agaram cb99ac300c fix a failing test
I deployed this without even running it once :/ Production was broken
for 9 minutes until I rolled back.
2022-06-23 11:40:00 -07:00
Kartik K. Agaram 009c7abb60 extract a function 2022-06-23 11:09:49 -07:00
Kartik K. Agaram 5a06c1286d bugfix: recompute screen lines in backspace/delete
Scenario: backspacing until a line takes up fewer screen lines, then
pressing `down`.

I've gone through and checked that fragments and screen_line_starting_pos
are now cleared together everywhere.
2022-06-23 11:03:46 -07:00
Kartik K. Agaram 515dad95f9 keep drawings within the line width slider as well 2022-06-22 21:08:17 -07:00
Kartik K. Agaram 39913ddbb8 show the line width when dragging the slider 2022-06-22 18:00:53 -07:00
Kartik K. Agaram 54eefbbf2d turns out super- chords to get to textinput 2022-06-22 17:37:26 -07:00
Kartik K. Agaram 8e68c699f5 bugfix: delete selection before pasting 2022-06-21 09:56:04 -07:00
Kartik K. Agaram 9c8285bf08 bugfix
State changes when inserting return are now in sync with other
characters.
2022-06-21 07:24:44 -07:00
Kartik K. Agaram 5a0b6c6a58 better fix for commit 3ffc2ed8f
I'm giving up finding a more generalized solution. The issue is that we
need the correct selection state right up to the point where we modify
Lines, in order to capture precise undo state.

Hopefully there aren't any other keychords that should clear the
selection.
2022-06-20 13:30:54 -07:00
Kartik K. Agaram 0d1e6aacd9 revert selection logic to before commit 3ffc2ed8f
We still have a failing test, but now it's the one we introduced in
commit 3ffc2ed8f.
2022-06-20 13:12:29 -07:00
Kartik K. Agaram 978c143397 snapshot: test for a new regression
Caused by commit 3ffc2ed8f.

We might need to bring back a lot of complexity for this.
2022-06-20 12:12:09 -07:00
Kartik K. Agaram 7508a70ed5 selection bugfix 2022-06-20 12:02:51 -07:00
Kartik K. Agaram c1b6bac187 much simpler
We just need to ensure textinput events never make use of selection
state.

All tests are passing, but I'm aware of a couple of issues. But now we
can keep all the special cases in one place.
2022-06-20 11:58:26 -07:00
Kartik K. Agaram 861c57b533 some early returns should be asserts 2022-06-20 11:51:07 -07:00
Kartik K. Agaram 809dae205d move Selection1 clearing past business logic
Now all the cases that clear Selection1 do so in a very consistent way
at the end of each case. And cases that set Selection1 symmetrically do
so at the start of each case.
2022-06-20 11:35:27 -07:00