Commit Graph

1288 Commits

Author SHA1 Message Date
Kartik K. Agaram 48b0075cf4 Merge text.love 2024-03-10 21:37:14 -07:00
Kartik K. Agaram 732ae69382 Merge lines.love 2024-03-10 21:36:01 -07:00
Kartik K. Agaram 093da1e7f8 add a mirror and reorg mirrors 2024-03-10 20:15:46 -07:00
Kartik K. Agaram 9f11452c0b Merge text.love 2024-02-16 21:29:03 -08:00
Kartik K. Agaram 28aac52235 Merge lines.love 2024-02-16 21:28:08 -08:00
Kartik K. Agaram 219ee11686 ensure tapping on editor brings up soft keyboard 2024-02-16 21:16:29 -08:00
Kartik K. Agaram 9d1bea2941 Merge text.love 2024-02-08 02:54:28 -08:00
Kartik K. Agaram 6b33c9e223 Merge lines.love 2024-02-08 02:52:55 -08:00
Kartik K. Agaram 4e9298dda1 bugfix in cursor positioning
scenario:
- create a long wrapping line
- tap past end of first screen line

Before this commit the cursor would be positioned not quite at the end
of the screen line but one character before. In effect there was no way
to position cursor at end of a wrapping line.

I'm not sure how this bug has lasted so long. It was introduced in
commit 8d3adfa36 back in June 2022, which was itself billed as a bugfix
for "clicking past end of screen line". But when I go back to it this
bug exists even back then. How did I miss it?! I wrote a test back then
-- and the test was wrong, has always been wrong.
2024-02-08 02:37:12 -08:00
Kartik K. Agaram d27c03373c Merge text.love 2024-02-04 17:39:15 -08:00
Kartik K. Agaram 77e1b57446 Merge lines.love 2024-02-04 17:36:01 -08:00
Kartik K. Agaram 1dbd734abb fix yet another place 2024-02-04 17:19:39 -08:00
Kartik K. Agaram 95be13f9db more realism in one more helper 2024-02-04 17:15:35 -08:00
Kartik K. Agaram 83722db5e4 bugfix: don't clear selection on M-arrow
We now treat all arrow chords as cursor movement.

Many thanks to Ryan Kessler (https://tone.support) for reporting this
issue.
2024-02-04 09:31:36 -08:00
Kartik K. Agaram 1d1a829d5b more carefully pass the 'key' arg around 2024-02-04 09:30:48 -08:00
Kartik K. Agaram dedb843535 Merge text.love 2024-01-15 01:45:35 -08:00
Kartik K. Agaram 348852ee2b Merge lines.love 2024-01-15 01:38:38 -08:00
Kartik K. Agaram 95d88a8298 use editor state font for width calculations 2024-01-12 05:23:06 -08:00
Kartik K. Agaram 4121613fc6 don't save settings on error in source editor 2024-01-12 03:51:34 -08:00
Kartik K. Agaram 5d4fd4aa93 fix still more issues with the previous scenario
- source editor always expects relative paths
- refresh mocked data

There's still one issue after this: the font size saved in the config
file is the one we use in tests. More broadly, Editor_state is
completely wrong.

Ideally I'd just not save any settings for the source editor if the
tests fail.
2024-01-12 03:35:22 -08:00
Kartik K. Agaram 57fb2d4b57 clean up test mocks before aborting
Scenario:
  modify a test to fail in the source editor
  delete any settings in the 'config' file in the save dir
  start lines.love
  press C-e to switch to source editor

Before this commit, this scenario led to the following events:
  the C-e keypress invokes App.run_tests_and_initialize()
  the failing test results in a call to error()
  the call to error() is trapped by the xpcall around the event handler in love.run
  handle_error runs
  Current_app is 'source', so love.event.quit() is triggered
  love.quit() is invoked
  source.settings() is invoked
  App.screen.position() is invoked, which calls the test mock
  Since App.screen.move was never invoked, App.screen.position() returns nil
  The 'config' file is written without values for source.x and source.y

As a result, future runs fail to open.

This is likely a corner case only I will ever run into, since I'm
careful to never commit failing unit tests. Still, I spent some time
trying to figure out the best place to fix this. Options:
* don't write config if Error_message is set
  but we do want config written in this scenario:
  * we hit an error, source editor opens
  * we spend some time debugging and don't immediately fix the issue
  * we quit, with some new files opened in various places
* hardcode source.settings() to call love.window.getPosition() rather
  than App.screen.position().
  drawback: weird special case
* clean up test mocks before aborting
  this seems like something we always want

I'm not very sure of my choice.
This bug doesn't leave me feeling very great about my whole app.
Arguably everything I've done is bullshit hacks piled on hacks.

Perhaps the issue is:
  - naked error() in LÖVE apps never invokes love.quit(), but
  - an unhandled error within my handle_error invokes love.quit() (via
    love.event.quit)
Perhaps LÖVE should provide a way to abort without invoking the quit
handler. There's literally no other way in LÖVE to request a quit.
2024-01-12 03:22:43 -08:00
Kartik K. Agaram 6c568c6ef0 Merge text.love 2023-12-29 14:30:35 -08:00
Kartik K. Agaram 6bd2086b51 Merge lines.love 2023-12-29 14:29:18 -08:00
Kartik K. Agaram aa6bfb4b15 moar bugfix X-( 2023-12-29 12:02:45 -08:00
Kartik K. Agaram bd2179d8aa bugfix
scenario: run without config file, quit, run again
expected: font size remains the same on second run

Before this commit it was increasing on each run.
It turns out the font height that you pass into love.graphics.newFont()
is not the result of font:getHeight().
2023-12-29 11:52:28 -08:00
Kartik K. Agaram 6601c9fad8 update doc 2023-12-29 11:26:24 -08:00
Kartik K. Agaram 0f4aea6db7 pull font into editor
Now it adjusts the current font for itself.
And it's up to the caller to adjust the current font after.
2023-12-29 11:18:41 -08:00
Kartik K. Agaram 320f68ba43 Merge text.love 2023-12-26 11:30:56 -08:00
Kartik K. Agaram 2b1c48c08e Merge lines.love 2023-12-26 11:29:52 -08:00
Kartik K. Agaram e36559d264 bugfix: utf-8 2023-12-26 11:19:23 -08:00
Kartik K. Agaram 25f16f2a88 Merge text.love 2023-12-19 17:38:19 -08:00
Kartik K. Agaram 35bc6106aa Merge lines.love 2023-12-19 17:36:13 -08:00
Kartik K. Agaram 3520682605 document a missing editor API 2023-12-19 10:41:53 -08:00
Kartik K. Agaram 92af2dee02 Merge text.love 2023-12-18 21:57:01 -08:00
Kartik K. Agaram 4b6a8aaba6 Merge lines.love 2023-12-18 21:55:14 -08:00
Kartik K. Agaram 81883d7dca bugfix :( 2023-12-18 21:39:01 -08:00
Kartik K. Agaram 0c4730dffc make button backgrounds optional 2023-12-18 21:33:59 -08:00
Kartik K. Agaram 607366e2e8 Merge text.love 2023-12-18 12:39:31 -08:00
Kartik K. Agaram 02966ebb0b Merge lines.love 2023-12-18 12:38:12 -08:00
Kartik K. Agaram 445ce2d220 add a helper and update some docs 2023-12-18 11:59:08 -08:00
Kartik K. Agaram d6b2b52006 Merge text.love 2023-12-16 23:52:14 -08:00
Kartik K. Agaram aa4d80f157 Merge lines.love 2023-12-16 23:49:20 -08:00
Kartik K. Agaram c29be0ffce streamline button.lua 2023-12-16 23:41:10 -08:00
Kartik K. Agaram 3752993b34 Merge text.love 2023-12-09 10:00:27 -08:00
Kartik K. Agaram 67e3a43b52 Merge lines.love 2023-12-09 09:59:09 -08:00
Kartik K. Agaram 961f296131 fix a couple of asserts missed in the recent audit 2023-12-09 09:22:45 -08:00
Kartik K. Agaram 56e904499b Merge text.love 2023-12-07 01:17:51 -08:00
Kartik K. Agaram 17810bf766 Merge lines.love 2023-12-07 01:17:11 -08:00
Kartik K. Agaram 366d806515 copy correct warning message
Not really useful here, but other forks might make use of it.
2023-12-07 01:08:09 -08:00
Kartik K. Agaram c4333b8da5 minor tweaks to manual tests while pushing to all forks 2023-12-07 01:06:19 -08:00