audacia
/
audacia
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix rounding error in ChangePitchDialog::Calc_ToPitchIndex().

This commit is contained in:
v.audacity 2013-05-14 02:49:56 +00:00
parent a7d0ddc49a
commit 4134d73125
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/effects/ChangePitch.cpp
View File

@ -432,7 +432,7 @@ bool ChangePitchDialog::TransferDataFromWindow()
m_PercentChange = newDouble;
}
// Ignore Slider_PercentChange because TextCtrl_PercentChange
// No need to update Slider_PercentChange here because TextCtrl_PercentChange
// always tracks it & is more precise (decimal points).
@ -449,7 +449,9 @@ void ChangePitchDialog::Calc_ToFrequency()
void ChangePitchDialog::Calc_ToPitchIndex()
{
m_ToPitchIndex = (m_FromPitchIndex + (int)m_SemitonesChange) % 12;
int nSemitonesChange =
(int)(m_SemitonesChange + ((m_SemitonesChange < 0.0) ? -0.5 : 0.5));
m_ToPitchIndex = (m_FromPitchIndex + nSemitonesChange) % 12;
if (m_ToPitchIndex < 0)
m_ToPitchIndex += 12;
}
@ -605,8 +607,6 @@ void ChangePitchDialog::OnText_PercentChange(wxCommandEvent & WXUNUSED(event))
this->Update_Slider_PercentChange();
m_bLoopDetect = false;
//v Probably better to override wxTextValidator to disallow negative values.
// See comment in ChangePitchDialog::ChangePitchDialog.
this->FindWindow(wxID_OK)->Enable(m_PercentChange > -100.0);
}
}