audacia
/
audacia
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ThomasFeher - Unused parameters clean up.

This commit is contained in:
James Crook 2016-09-11 20:30:06 +01:00
parent e8bf7a41eb
commit 65c7e8051a
25 changed files with 52 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/AudacityApp.cpp
View File

@ -478,10 +478,10 @@ typedef void (*_gnome_interaction_key_return_fn)(gint, gboolean);
static _gnome_client_request_interaction_fn gnome_client_request_interaction;
static _gnome_interaction_key_return_fn gnome_interaction_key_return;
static void interact_cb(GnomeClient *client,
static void interact_cb(GnomeClient * /* client */,
gint key,
GnomeDialogType type,
gpointer data)
GnomeDialogType /* type */,
gpointer /* data */)
{
wxCloseEvent e(wxEVT_QUERY_END_SESSION, wxID_ANY);
e.SetEventObject(&wxGetApp());
@ -493,12 +493,12 @@ static void interact_cb(GnomeClient *client,
}
static gboolean save_yourself_cb(GnomeClient *client,
gint phase,
GnomeSaveStyle style,
gint /* phase */,
GnomeSaveStyle /* style */,
gboolean shutdown,
GnomeInteractStyle interact,
gboolean fast,
gpointer user_data)
gboolean /* fast */,
gpointer /* user_data */)
{
if (!shutdown || interact != GNOME_INTERACT_ANY) {
return TRUE;
@ -888,7 +888,7 @@ void AudacityApp::OnTimer(wxTimerEvent& WXUNUSED(event))
if (ShouldShowMissingAliasedFileWarning()) {
// find which project owns the blockfile
// note: there may be more than 1, but just go with the first one.
size_t numProjects = gAudacityProjects.size();
//size_t numProjects = gAudacityProjects.size();
AudacityProject *offendingProject {};
wxString missingFileName;
@ -1110,6 +1110,7 @@ void AudacityApp::GenerateCrashReport(wxDebugReport::Context ctx)
int AudacityApp::FilterEvent(wxEvent & event)
{
(void)event;// compiler food (stops unused parameter warning)
#if !wxCHECK_VERSION(3, 0, 0) && defined(__WXGTK__)
// On wxGTK, there's a focus issue where dialogs do not automatically pass focus
// to the first child. This means that you can use the keyboard to navigate within
@ -1844,7 +1845,7 @@ bool AudacityApp::CreateSingleInstanceChecker(const wxString &dir)
}
#if defined(__UNIX__)
void AudacityApp::OnServerEvent(wxSocketEvent & evt)
void AudacityApp::OnServerEvent(wxSocketEvent & /* evt */)
{
wxSocketBase *sock;
@ -2061,7 +2062,7 @@ int AudacityApp::OnExit()
// and skip the event unless none are open (which should only happen
// on the Mac, at least currently.)
void AudacityApp::OnMenuAbout(wxCommandEvent & event)
void AudacityApp::OnMenuAbout(wxCommandEvent & /*event*/)
{
// This function shadows a similar function
// in Menus.cpp, but should only be used on the Mac platform.

1
src/Diags.cpp
View File

@ -42,6 +42,7 @@ static bool bStopWatchStarted = false;
void diagnostics_do_diag( t_diag_struct * pDiag ){
wxLog * pLog = wxLog::SetActiveTarget(NULL);
// this macro is empty if wxWidgets is not compiled in debug mode
wxLogDebug( wxT("%s"), pDiag->pMessage );
wxLog::SetActiveTarget(pLog);
}

2
src/LabelDialog.cpp
View File

@ -562,7 +562,7 @@ void LabelDialog::OnRemove(wxCommandEvent & WXUNUSED(event))
}
// Remove the row
RowData &rd = mData[row];
//RowData &rd = mData[row];
mData.erase(mData.begin() + row);
// Repopulate the grid

2
src/Menus.cpp
View File

@ -1909,7 +1909,7 @@ void AudacityProject::ModifyToolbarMenus()
// checkActive is a temporary hack that should be removed as soon as we
// get multiple effect preview working
void AudacityProject::UpdateMenus(bool checkActive)
void AudacityProject::UpdateMenus(bool /*checkActive*/)
{
//ANSWER-ME: Why UpdateMenus only does active project?
//JKC: Is this test fixing a bug when multiple projects are open?

5
src/Project.cpp
View File

@ -1652,7 +1652,7 @@ void AudacityProject::OnScrollRight()
///
/// This handles the event when the left direction button on the scrollbar is depresssed
///
void AudacityProject::OnScrollLeftButton(wxScrollEvent & event)
void AudacityProject::OnScrollLeftButton(wxScrollEvent & /*event*/)
{
wxInt64 pos = mHsbar->GetThumbPosition();
// move at least one scroll increment
@ -1671,7 +1671,7 @@ void AudacityProject::OnScrollLeftButton(wxScrollEvent & event)
///
/// This handles the event when the right direction button on the scrollbar is depresssed
///
void AudacityProject::OnScrollRightButton(wxScrollEvent & event)
void AudacityProject::OnScrollRightButton(wxScrollEvent & /*event*/)
{
wxInt64 pos = mHsbar->GetThumbPosition();
// move at least one scroll increment
@ -2276,6 +2276,7 @@ void AudacityProject::OnUpdateUI(wxUpdateUIEvent & WXUNUSED(event))
void AudacityProject::MacShowUndockedToolbars(bool show)
{
(void)show;//compiler food
#ifdef __WXMAC__
// Find all the floating toolbars, and show or hide them
const auto &children = GetChildren();

2
src/Tags.h
View File

@ -142,7 +142,7 @@ class TagsEditor final : public wxDialogWrapper
virtual ~TagsEditor();
bool IsEscapeKey(const wxKeyEvent& event) override { return false; }
bool IsEscapeKey(const wxKeyEvent& /*event*/) override { return false; }
void PopulateOrExchange(ShuttleGui & S);

2
src/blockfile/SimpleBlockFile.cpp
View File

@ -606,7 +606,7 @@ auto SimpleBlockFile::GetSpaceUsage() const -> DiskByteCount
void SimpleBlockFile::Recover(){
wxFFile file(mFileName.GetFullPath(), wxT("wb"));
int i;
//int i;
if( !file.IsOpened() ){
// Can't do anything else.

2
src/commands/Command.cpp
View File

@ -105,6 +105,7 @@ void CommandImplementation::TypeCheck(const wxString &typeName,
const wxString &paramName,
const wxVariant &param)
{
// this macro is empty if wxWidgets is not compiled in debug mode
wxASSERT_MSG(param.IsType(typeName),
GetName()
+ wxT("command tried to get '")
@ -116,6 +117,7 @@ void CommandImplementation::TypeCheck(const wxString &typeName,
void CommandImplementation::CheckParam(const wxString &paramName)
{
// this macro is empty if wxWidgets is not compiled in debug mode
wxASSERT_MSG(mParams.find(paramName) != mParams.end(),
GetName()
+ wxT("command tried to get '")

5
src/commands/Keyboard.cpp
View File

@ -43,12 +43,13 @@ wxString KeyStringNormalize(const wxString & key)
#endif
}
wxString KeyStringDisplay(const wxString & key, bool useSspecialChars)
wxString KeyStringDisplay(const wxString & key, bool usesSpecialChars)
{
(void)usesSpecialChars;//compiler food
wxString newkey = KeyStringNormalize(key);
#if defined(__WXMAC__)
if (!useSspecialChars) {
if (!usesSpecialChars) {
// Compose user-visible keystroke names, all ASCII
newkey.Replace(wxT("XCtrl+"), wxT("Control+"));
newkey.Replace(wxT("Alt+"), wxT("Option+"));

2
src/effects/BassTreble.cpp
View File

@ -488,7 +488,7 @@ void EffectBassTreble::OnGainSlider(wxCommandEvent & evt)
EnableApply(mUIParent->Validate());
}
void EffectBassTreble::OnLinkCheckbox(wxCommandEvent& evt)
void EffectBassTreble::OnLinkCheckbox(wxCommandEvent& /*evt*/)
{
mLink = mLinkCheckBox->GetValue();
}

2
src/effects/Contrast.cpp
View File

@ -542,7 +542,7 @@ void ContrastDialog::OnExport(wxCommandEvent & WXUNUSED(event))
f.Close();
}
void ContrastDialog::OnReset(wxCommandEvent & event)
void ContrastDialog::OnReset(wxCommandEvent & /*event*/)
{
mForegroundStartT->SetValue(0.0);
mForegroundEndT->SetValue(0.0);

14
src/effects/Distortion.cpp
View File

@ -578,21 +578,21 @@ sampleCount EffectDistortion::InstanceProcess(EffectDistortionState& data, float
return blockLen;
}
void EffectDistortion::OnTypeChoice(wxCommandEvent& evt)
void EffectDistortion::OnTypeChoice(wxCommandEvent& /*evt*/)
{
mTypeChoiceCtrl->GetValidator()->TransferFromWindow();
UpdateUI();
}
void EffectDistortion::OnDCBlockCheckbox(wxCommandEvent& evt)
void EffectDistortion::OnDCBlockCheckbox(wxCommandEvent& /*evt*/)
{
mParams.mDCBlock = mDCBlockCheckBox->GetValue();
mbSavedFilterState = mParams.mDCBlock;
}
void EffectDistortion::OnThresholdText(wxCommandEvent& evt)
void EffectDistortion::OnThresholdText(wxCommandEvent& /*evt*/)
{
mThresholdT->GetValidator()->TransferFromWindow();
mThreshold = DB_TO_LINEAR(mParams.mThreshold_dB);
@ -607,7 +607,7 @@ void EffectDistortion::OnThresholdSlider(wxCommandEvent& evt)
mThresholdT->GetValidator()->TransferToWindow();
}
void EffectDistortion::OnNoiseFloorText(wxCommandEvent& evt)
void EffectDistortion::OnNoiseFloorText(wxCommandEvent& /*evt*/)
{
mNoiseFloorT->GetValidator()->TransferFromWindow();
mNoiseFloorS->SetValue((int) floor(mParams.mNoiseFloor + 0.5));
@ -620,7 +620,7 @@ void EffectDistortion::OnNoiseFloorSlider(wxCommandEvent& evt)
}
void EffectDistortion::OnParam1Text(wxCommandEvent& evt)
void EffectDistortion::OnParam1Text(wxCommandEvent& /*evt*/)
{
mParam1T->GetValidator()->TransferFromWindow();
mParam1S->SetValue((int) floor(mParams.mParam1 + 0.5));
@ -632,7 +632,7 @@ void EffectDistortion::OnParam1Slider(wxCommandEvent& evt)
mParam1T->GetValidator()->TransferToWindow();
}
void EffectDistortion::OnParam2Text(wxCommandEvent& evt)
void EffectDistortion::OnParam2Text(wxCommandEvent& /*evt*/)
{
mParam2T->GetValidator()->TransferFromWindow();
mParam2S->SetValue((int) floor(mParams.mParam2 + 0.5));
@ -644,7 +644,7 @@ void EffectDistortion::OnParam2Slider(wxCommandEvent& evt)
mParam2T->GetValidator()->TransferToWindow();
}
void EffectDistortion::OnRepeatsText(wxCommandEvent& evt)
void EffectDistortion::OnRepeatsText(wxCommandEvent& /*evt*/)
{
mRepeatsT->GetValidator()->TransferFromWindow();
mRepeatsS->SetValue(mParams.mRepeats);

2
src/effects/FindClipping.cpp
View File

@ -96,7 +96,7 @@ bool EffectFindClipping::Process()
{
std::shared_ptr<AddedAnalysisTrack> addedTrack;
Maybe<ModifiedAnalysisTrack> modifiedTrack;
Track *original = NULL;
//Track *original = NULL;
const wxString name{ _("Clipping") };
LabelTrack *lt = NULL;

2
src/effects/ladspa/LadspaEffect.cpp
View File

@ -1411,7 +1411,7 @@ bool LadspaEffect::PopulateUI(wxWindow *parent)
item = safenew wxStaticText(w, 0, labelText + wxT(":"));
gridSizer->Add(item, 0, wxALIGN_CENTER_VERTICAL | wxALIGN_RIGHT | wxALL, 5);
LADSPA_PortRangeHint hint = mData->PortRangeHints[p];
//LADSPA_PortRangeHint hint = mData->PortRangeHints[p];
wxString bound;
float lower = 0.0;

2
src/export/ExportFFmpeg.cpp
View File

@ -651,7 +651,7 @@ static int encode_audio(AVCodecContext *avctx, AVPacket *pkt, int16_t *audio_sam
bool ExportFFmpeg::Finalize()
{
int i, nEncodedBytes;
int nEncodedBytes;
// Flush the audio FIFO and encoder.
for (;;)

2
src/export/ExportMP3.cpp
View File

@ -519,7 +519,7 @@ void ExportMP3Options::OnQuality(wxCommandEvent& WXUNUSED(event))
}
}
void ExportMP3Options::OnMono(wxCommandEvent& evt)
void ExportMP3Options::OnMono(wxCommandEvent& /*evt*/)
{
bool mono = false;
mono = mMono->GetValue();

2
src/export/ExportPCM.cpp
View File

@ -414,7 +414,7 @@ int ExportPCM::Export(AudacityProject *project,
wxString formatStr;
SF_INFO info;
int err;
//int err;
//This whole operation should not occur while a file is being loaded on OD,
//(we are worried about reading from a file being written to,) so we block.

2
src/prefs/RecordingPrefs.cpp
View File

@ -244,7 +244,7 @@ bool RecordingPrefs::Apply()
return true;
}
void RecordingPrefs::OnToggleCustomName(wxCommandEvent & Evt)
void RecordingPrefs::OnToggleCustomName(wxCommandEvent & /* Evt */)
{
mUseCustomTrackName = !mUseCustomTrackName;
mToggleCustomName->Enable(mUseCustomTrackName);

2
src/prefs/RecordingPrefs.h
View File

@ -31,7 +31,7 @@ class RecordingPrefs final : public PrefsPanel
private:
void Populate();
void PopulateOrExchange(ShuttleGui & S);
void OnToggleCustomName(wxCommandEvent & Evt);
void OnToggleCustomName(wxCommandEvent & /* Evt */);
wxTextCtrl *mToggleCustomName;
bool mUseCustomTrackName;

2
src/toolbars/ControlToolBar.cpp
View File

@ -444,7 +444,7 @@ void ControlToolBar::EnableDisableButtons()
mRewind->SetEnabled(!playing && !recording);
mFF->SetEnabled(tracks && !playing && !recording);
auto pProject = GetActiveProject();
//auto pProject = GetActiveProject();
mPause->SetEnabled(CanStopAudioStream());
}

4
src/tracks/ui/Scrubbing.cpp
View File

@ -385,7 +385,7 @@ bool Scrubber::MaybeStartScrubbing(wxCoord xx)
// ? ControlToolBar::PlayAppearance::Seek
// : ControlToolBar::PlayAppearance::Scrub;
ControlToolBar::PlayAppearance::Straight;
const bool cutPreview = false;
// const bool cutPreview = false;
const bool backwards = time1 < time0;
#ifdef EXPERIMENTAL_SCRUBBING_SCROLL_WHEEL
static const double maxScrubSpeedBase =
@ -686,7 +686,7 @@ void Scrubber::OnActivateOrDeactivateApp(wxActivateEvent &event)
void Scrubber::Forwarder::OnMouse(wxMouseEvent &event)
{
auto ruler = scrubber.mProject->GetRulerPanel();
//auto ruler = scrubber.mProject->GetRulerPanel();
auto isScrubbing = scrubber.IsScrubbing();
if (isScrubbing && !event.HasAnyModifiers()) {
if(event.LeftDown() && scrubber.MayDragToSeek()) {

2
src/widgets/NumericTextCtrl.cpp
View File

@ -1750,7 +1750,7 @@ void NumericTextCtrl::OnKeyDown(wxKeyEvent &event)
}
}
void NumericTextCtrl::SetFieldFocus(int digit)
void NumericTextCtrl::SetFieldFocus(int digit)
{
#if wxUSE_ACCESSIBILITY
if (mDigits.GetCount() == 0)

2
src/widgets/NumericTextCtrl.h
View File

@ -164,7 +164,7 @@ class NumericTextCtrl final : public wxControl, public NumericConverter
void SetFormatString(const wxString & formatString);
void SetFormatName(const wxString & formatName);
void SetFieldFocus(int digit);
void SetFieldFocus(int /* digit */);
void SetReadOnly(bool readOnly = true);
void EnableMenu(bool enable = true);

2
src/widgets/ProgressDialog.cpp
View File

@ -1076,7 +1076,7 @@ bool ProgressDialog::Create(const wxString & title,
// Set this boolean to indicate if we are using the "Elapsed" labels
m_bShowElapsedTime = !(flags & pdlgHideElapsedTime);
// Set this boolean to indicate if we confirm the Cancel/Stop actions
m_bConfirmAction = (flags & pdlgConfirmStopCancel);
m_bConfirmAction = (flags & pdlgConfirmStopCancel)!=0;
bool success = wxDialogWrapper::Create(parent,
wxID_ANY,

12
src/widgets/Ruler.cpp
View File

@ -1778,14 +1778,14 @@ AdornedRulerPanel *QuickPlayRulerOverlay::GetRuler() const
return mPartner.mProject->GetRulerPanel();
}
std::pair<wxRect, bool> QuickPlayRulerOverlay::DoGetRectangle(wxSize size)
std::pair<wxRect, bool> QuickPlayRulerOverlay::DoGetRectangle(wxSize /*size*/)
{
const auto x = mOldQPIndicatorPos;
if (x >= 0) {
// These dimensions are always sufficient, even if a little
// excessive for the small triangle:
const int width = IndicatorBigWidth() * 3 / 2;
const auto height = IndicatorHeightForWidth(width);
//const auto height = IndicatorHeightForWidth(width);
const int indsize = width / 2;
@ -1802,7 +1802,7 @@ std::pair<wxRect, bool> QuickPlayRulerOverlay::DoGetRectangle(wxSize size)
return { {}, mNewQPIndicatorPos >= 0 };
}
void QuickPlayRulerOverlay::Draw(OverlayPanel &panel, wxDC &dc)
void QuickPlayRulerOverlay::Draw(OverlayPanel & /*panel*/, wxDC &dc)
{
mOldQPIndicatorPos = mNewQPIndicatorPos;
if (mOldQPIndicatorPos >= 0) {
@ -2108,7 +2108,7 @@ void AdornedRulerPanel::InvalidateRuler()
}
namespace {
const wxString StartScrubbingMessage(const Scrubber &scrubber)
const wxString StartScrubbingMessage(const Scrubber &/*scrubber*/)
{
/* i18n-hint: These commands assist the user in finding a sound by ear. ...
"Scrubbing" is variable-speed playback, ...
@ -2571,7 +2571,7 @@ void AdornedRulerPanel::HandleQPClick(wxMouseEvent &evt, wxCoord mousePosX)
CaptureMouse();
}
void AdornedRulerPanel::HandleQPDrag(wxMouseEvent &event, wxCoord mousePosX)
void AdornedRulerPanel::HandleQPDrag(wxMouseEvent &/*event*/, wxCoord mousePosX)
{
bool isWithinClick = (mLeftDownClick >= 0) && IsWithinMarker(mousePosX, mLeftDownClick);
bool isWithinStart = IsWithinMarker(mousePosX, mOldPlayRegionStart);
@ -2876,7 +2876,7 @@ void AdornedRulerPanel::UpdateButtonStates()
}
}
void AdornedRulerPanel::OnTogglePinnedState(wxCommandEvent & event)
void AdornedRulerPanel::OnTogglePinnedState(wxCommandEvent & /*event*/)
{
mProject->OnTogglePinnedHead();
UpdateButtonStates();