Fix some warnings on mac

These are mostly missing 'overrides'

src/AudacityApp.h

@@ -65,7 +65,7 @@ class AudacityApp final : public wxApp {
    void OnFatalException() override;
    bool OnExceptionInMainLoop() override;
 
-   int FilterEvent(wxEvent & event);
+   int FilterEvent(wxEvent & event) override;
 
    // Returns the language actually used which is not lang if lang cannot be found.
    wxString InitLang( const wxString & lang );

src/AudioIO.cpp

@@ -992,7 +992,7 @@ static double SystemTime(bool usingAlsa)
       return (now.tv_sec + now.tv_nsec * 0.000000001) - streamStartTime;
    }
 #else
-   usingAlsa;//compiler food.
+   static_cast<void>(usingAlsa);//compiler food.
 #endif
 
    return PaUtil_GetTime() - streamStartTime;
@@ -4421,7 +4421,7 @@ void AudioIO::AllNotesOff(bool looping)
    bool doDelay = !looping;
 #else
    bool doDelay = false;
-   looping;// compiler food.
+   static_cast<void>(looping);// compiler food.
 #endif
 
    // to keep track of when MIDI should all be delivered,

src/LabelDialog.h

@@ -64,7 +64,7 @@ class LabelDialog final : public wxDialogWrapper
 
    bool TransferDataToWindow() override;
    bool TransferDataFromWindow() override;
-   bool Validate();
+   bool Validate() override;
    void FindAllLabels();
    void AddLabels(const LabelTrack *t);
    void FindInitialRow();

src/Menus.cpp

@@ -6820,7 +6820,7 @@ void AudacityProject::OnZoomToggle(const CommandContext &WXUNUSED(context) )
    double Zoom1 = GetZoomOfPreset( TracksPrefs::Zoom1Choice() );
    double Zoom2 = GetZoomOfPreset( TracksPrefs::Zoom2Choice() );
    double Z = mViewInfo.GetZoom();// Current Zoom.
-   double ChosenZoom = abs(log(Zoom1 / Z)) > abs(log( Z / Zoom2)) ? Zoom1:Zoom2;
+   double ChosenZoom = fabs(log(Zoom1 / Z)) > fabs(log( Z / Zoom2)) ? Zoom1:Zoom2;
 
    Zoom(ChosenZoom);
    mTrackPanel->Refresh(false);

src/Project.h

@@ -226,7 +226,7 @@ class AUDACITY_DLL_API AudacityProject final : public wxFrame,
    bool IsAudioActive() const;
    void SetAudioIOToken(int token);
 
-   bool IsActive();
+   bool IsActive() override;
 
    // File I/O
 

src/WaveTrack.h

@@ -105,14 +105,14 @@ private:
     *
     * @return time in seconds, or zero if there are no clips in the track
     */
-   double GetStartTime() const;
+   double GetStartTime() const override;
 
    /** @brief Get the time at which the last clip in the track ends, plus
     * recorded stuff
     *
     * @return time in seconds, or zero if there are no clips in the track.
     */
-   double GetEndTime() const;
+   double GetEndTime() const override;
 
    //
    // Identifying the type of track

src/blockfile/ODPCMAliasBlockFile.h

@@ -96,10 +96,10 @@ class ODPCMAliasBlockFile final : public PCMAliasBlockFile
    sampleCount GetStart() const {return mStart;}
 
    /// Locks the blockfile only if it has a file that exists.
-   void Lock();
+   void Lock() override;
 
    /// Unlocks the blockfile only if it has a file that exists.
-   void Unlock();
+   void Unlock() override;
 
    ///sets the amount of samples the clip associated with this blockfile is offset in the wavetrack (non effecting)
    void SetClipOffset(sampleCount numSamples){mClipOffset= numSamples;}

src/blockfile/SimpleBlockFile.cpp

@@ -543,11 +543,11 @@ auto SimpleBlockFile::GetSpaceUsage() const -> DiskByteCount
       file.Close();
    }
 
-   return {
+   return (
           sizeof(auHeader) +
           mSummaryInfo.totalSummaryBytes +
           (GetLength() * SAMPLE_SIZE_DISK(mFormat))
-   };
+   );
 }
 
 void SimpleBlockFile::Recover(){

src/commands/AudacityCommand.h

@@ -70,9 +70,9 @@ class AUDACITY_DLL_API AudacityCommand /* not final */ : public wxEvtHandler,
    //  virtual wxString GetFamily();
 
    //These two must be implemented by instances.
-   virtual wxString GetSymbol()
+   virtual wxString GetSymbol() override
    { wxFAIL_MSG( "Implement a Symbol for this command");return "FAIL";};
-   virtual wxString GetDescription()
+   virtual wxString GetDescription() override
    {wxFAIL_MSG( "Implement a Description for this command");return "FAIL";};
 
    // Name of page in the Audacity alpha manual

src/commands/Command.h

@@ -105,7 +105,7 @@ public:
    virtual ~CommandImplementation();
 
    /// An instance method for getting the command name (for consistency)
-   wxString GetName();
+   wxString GetName() override;
 
    /// Get the signature of the command
    CommandSignature &GetSignature() override;

src/commands/Validators.h

@@ -153,7 +153,7 @@ public:
 class BoolArrayValidator final : public Validator
 {
 public:
-   virtual bool Validate(const wxVariant &v)
+   virtual bool Validate(const wxVariant &v) override
    {
       wxString val;         // Validate a string of chars containing only 0, 1 and x.
       if (!v.Convert(&val))

src/effects/NoiseReduction.cpp

@@ -366,7 +366,7 @@ public:
        wxWindow *parent, bool bHasProfile,
        bool bAllowTwiddleSettings);
 
-   void PopulateOrExchange(ShuttleGui & S);
+   void PopulateOrExchange(ShuttleGui & S) override;
    bool TransferDataToWindow() override;
    bool TransferDataFromWindow() override;
 
@@ -386,7 +386,7 @@ private:
 #ifdef ADVANCED_SETTINGS
    void OnMethodChoice(wxCommandEvent &);
 #endif
-   void OnPreview(wxCommandEvent &event);
+   void OnPreview(wxCommandEvent &event) override;
    void OnReduceNoise( wxCommandEvent &event );
    void OnCancel( wxCommandEvent &event );
    void OnHelp( wxCommandEvent &event );

src/effects/Phaser.h

@@ -80,7 +80,7 @@ public:
 
    // Effect implementation
 
-   void PopulateOrExchange(ShuttleGui & S);
+   void PopulateOrExchange(ShuttleGui & S) override;
    bool TransferDataToWindow() override;
    bool TransferDataFromWindow() override;
 

src/effects/Reverb.h

@@ -71,8 +71,8 @@ public:
 
    // Effect implementation
 
-   bool Startup();
+   bool Startup() override;
-   void PopulateOrExchange(ShuttleGui & S);
+   void PopulateOrExchange(ShuttleGui & S) override;
    bool TransferDataToWindow() override;
    bool TransferDataFromWindow() override;
 

src/effects/ToneGen.h

@@ -52,7 +52,7 @@ public:
 
    // Effect implementation
 
-   void PopulateOrExchange(ShuttleGui & S);
+   void PopulateOrExchange(ShuttleGui & S) override;
    bool TransferDataFromWindow() override;
    bool TransferDataToWindow() override;
 

src/effects/VST/VSTEffect.h

@@ -247,7 +247,8 @@ private:
 
    // VST methods
 
-   intptr_t callDispatcher(int opcode, int index, intptr_t value, void *ptr, float opt);
+   intptr_t callDispatcher(int opcode, int index,
+                           intptr_t value, void *ptr, float opt) override;
    void callProcessReplacing(float **inputs, float **outputs, int sampleframes);
    void callSetParameter(int index, float value);
    float callGetParameter(int index);

src/export/ExportMP3.cpp

@@ -1599,7 +1599,7 @@ class ExportMP3 final : public ExportPlugin
 public:
 
    ExportMP3();
-   bool CheckFileName(wxFileName & filename, int format);
+   bool CheckFileName(wxFileName & filename, int format) override;
 
    // Required
 

src/export/ExportPCM.cpp

@@ -329,7 +329,7 @@ public:
                const Tags *metadata = NULL,
                int subformat = 0) override;
    // optional
-   wxString GetExtension(int index);
+   wxString GetExtension(int index) override;
    bool CheckFileName(wxFileName &filename, int format) override;
 
 private:

src/import/ImportFLAC.cpp

@@ -139,8 +139,8 @@ class FLACImportPlugin final : public ImportPlugin
 
    ~FLACImportPlugin() { }
 
-   wxString GetPluginStringID() { return wxT("libflac"); }
+   wxString GetPluginStringID() override { return wxT("libflac"); }
-   wxString GetPluginFormatDescription();
+   wxString GetPluginFormatDescription() override;
    std::unique_ptr<ImportFileHandle> Open(const wxString &Filename)  override;
 };
 
@@ -225,7 +225,7 @@ void MyFLACFile::metadata_callback(const FLAC__StreamMetadata *metadata)
 
       // FIXME: not declared when compiling on Ubuntu.
       //case FLAC__MAX_METADATA_TYPE: // quiet compiler warning with this line
-
+      default:
       break;
    }
 }

src/import/ImportMP3.cpp

@@ -116,8 +116,8 @@ public:
 
    ~MP3ImportPlugin() { }
 
-   wxString GetPluginStringID() { return wxT("libmad"); }
+   wxString GetPluginStringID() override { return wxT("libmad"); }
-   wxString GetPluginFormatDescription();
+   wxString GetPluginFormatDescription() override;
    std::unique_ptr<ImportFileHandle> Open(const wxString &Filename) override;
 };
 

src/import/ImportOGG.cpp

@@ -92,8 +92,8 @@ public:
 
    ~OggImportPlugin() { }
 
-   wxString GetPluginStringID() { return wxT("liboggvorbis"); }
+   wxString GetPluginStringID() override { return wxT("liboggvorbis"); }
-   wxString GetPluginFormatDescription();
+   wxString GetPluginFormatDescription() override;
    std::unique_ptr<ImportFileHandle> Open(const wxString &Filename) override;
 };
 

src/import/ImportPCM.cpp

@@ -80,8 +80,8 @@ public:
 
    ~PCMImportPlugin() { }
 
-   wxString GetPluginStringID() { return wxT("libsndfile"); }
+   wxString GetPluginStringID() override { return wxT("libsndfile"); }
-   wxString GetPluginFormatDescription();
+   wxString GetPluginFormatDescription() override;
    std::unique_ptr<ImportFileHandle> Open(const wxString &Filename) override;
 };
 

src/ondemand/ODDecodeFlacTask.cpp

@@ -83,7 +83,7 @@ void ODFLACFile::metadata_callback(const FLAC__StreamMetadata *metadata)
 
       // FIXME: not declared when compiling on Ubuntu.
       //case FLAC__MAX_METADATA_TYPE: // quiet compiler warning with this line
-
+      default:
       break;
    }
 }

src/toolbars/ToolBar.h

@@ -109,7 +109,7 @@ class ToolBar /* not final */ : public wxPanelWrapper
    wxString GetSection();
    ToolDock *GetDock();
 
-   void SetLabel(const wxString & label);
+   void SetLabel(const wxString & label) override;
    void SetDock( ToolDock *dock);
 
    void SetDocked(ToolDock *dock, bool pushed);

src/tracks/playabletrack/notetrack/ui/NoteTrackVZoomHandle.cpp

@@ -194,7 +194,7 @@ private:
       mpData = nullptr;
    }
 
-   virtual void InitMenu(Menu *pMenu, void *pUserData);
+   virtual void InitMenu(Menu *pMenu, void *pUserData) override;
 
    void OnWaveformScaleType(wxCommandEvent &evt);
 };

src/tracks/playabletrack/wavetrack/ui/WaveTrackVZoomHandle.cpp

@@ -412,7 +412,7 @@ public:
    static WaveformVRulerMenuTable &Instance();
 
 private:
-   virtual void InitMenu(Menu *pMenu, void *pUserData);
+   virtual void InitMenu(Menu *pMenu, void *pUserData) override;
 
    void OnWaveformScaleType(wxCommandEvent &evt);
 };
@@ -499,7 +499,7 @@ public:
    static SpectrumVRulerMenuTable &Instance();
 
 private:
-   void InitMenu(Menu *pMenu, void *pUserData);
+   void InitMenu(Menu *pMenu, void *pUserData) override;
 
    void OnSpectrumScaleType(wxCommandEvent &evt);
 };

src/widgets/ASlider.h

@@ -307,7 +307,7 @@ class ASlider /* not final */ : public wxPanel
    void OnTimer(wxTimerEvent & event);
 
    // Overrides of the wxWindow functions with the same semantics
-   bool Enable(bool enable = true);
+   bool Enable(bool enable = true) override;
    bool IsEnabled() const;
 
 private:

src/widgets/Grid.h

@@ -140,22 +140,18 @@ public:
                        wxWindowID id,
                        wxEvtHandler *evtHandler) override;
 
-   void SetSize(const wxRect &rect);
+   void SetSize(const wxRect &rect) override;
-
+   void BeginEdit(int row, int col, wxGrid *grid) override;
-   void BeginEdit(int row, int col, wxGrid *grid);
-
    bool EndEdit(int row, int col, wxGrid *grid);
-
+   bool EndEdit(int row, int col, const wxGrid *grid,
-   bool EndEdit(int row, int col, const wxGrid *grid, const wxString &oldval, wxString *newval);
+                const wxString &oldval, wxString *newval) override;
-
+   void ApplyEdit(int row, int col, wxGrid *grid) override;
-   void ApplyEdit(int row, int col, wxGrid *grid);
+   void Reset() override;
-
-   void Reset();
 
    wxGridCellEditor *Clone() const override;
 
    void SetChoices(const wxArrayString &choices);
-   wxString GetValue() const;
+   wxString GetValue() const override;
 
  protected:
 

src/widgets/Ruler.h

@@ -297,9 +297,9 @@ class AUDACITY_DLL_API RulerPanel final : public wxPanelWrapper {
    void SetTickColour( wxColour & c){ ruler.SetTickColour( c );}
 
    // We don't need or want to accept focus.
-   bool AcceptsFocus() const { return false; }
+   bool AcceptsFocus() const override  { return false; }
    // So that wxPanel is not included in Tab traversal - see wxWidgets bug 15581
-   bool AcceptsFocusFromKeyboard() const { return false; }
+   bool AcceptsFocusFromKeyboard() const override { return false; }
 
  public: