Remove wx/{app,statbmp,spinctrl,scrolbar,dynlib,dcmemory}.h from *.h

src/AboutDialog.h

@@ -13,7 +13,6 @@
 
 #include "MemoryX.h"
 #include <vector>
-#include <wx/statbmp.h>
 #include <wx/bitmap.h>
 #include "widgets/wxPanelWrapper.h"
 
@@ -21,6 +20,8 @@ extern const wxString VerCheckArgs();
 extern const wxString VerCheckUrl();
 extern const wxString VerCheckHtml();
 
+class wxStaticBitmap;
+
 class ShuttleGui;
 
 struct AboutDialogCreditItem {

src/AdornedRulerPanel.h

@@ -16,7 +16,6 @@
 
 #include "MemoryX.h"
 #include <wx/bitmap.h>
-#include <wx/dcmemory.h>
 
 class ViewInfo;
 class AudacityProject;

src/AudacityApp.h

@@ -20,7 +20,7 @@
 #include "Experimental.h"
 
 #include "MemoryX.h"
-#include <wx/app.h>
+#include <wx/app.h> // to inherit
 #include <wx/cmdline.h>
 #include <wx/dir.h>
 #include <wx/docview.h>

src/AudacityException.h

@@ -17,7 +17,7 @@
  **********************************************************************/
 
 #include "MemoryX.h"
-#include <wx/app.h>
+#include <wx/app.h> // used in inline function template
 #include <exception>
 
 #include "Internat.h"

src/FFmpeg.cpp

@@ -26,6 +26,7 @@ License: GPL v2.  See License.txt.
 #include "widgets/ErrorDialog.h"
 
 #include <wx/checkbox.h>
+#include <wx/dynlib.h>
 #include <wx/file.h>
 #include <wx/filedlg.h>
 

src/FFmpeg.h

@@ -150,7 +150,6 @@ extern "C" {
 
 /* rather earlier than normal, but pulls in config*.h and other program stuff
  * we need for the next bit */
-#include <wx/dynlib.h>
 #include <wx/log.h>      // for wxLogNull
 #include <wx/utils.h>
 #include "widgets/LinkingHtmlWindow.h"
@@ -159,6 +158,8 @@ extern "C" {
 
 #include "audacity/Types.h"
 
+class wxDynamicLibrary;
+
 // if you needed them, any other audacity header files would go here
 
 /// Callback function to catch FFmpeg log messages.

src/FreqWindow.cpp

@@ -57,6 +57,7 @@ and in the spectrogram spectral selection.
 #include <wx/file.h>
 #include <wx/filedlg.h>
 #include <wx/intl.h>
+#include <wx/scrolbar.h>
 #include <wx/sizer.h>
 #include <wx/slider.h>
 #include <wx/statbmp.h>

src/FreqWindow.h

@@ -14,18 +14,18 @@
 #include "MemoryX.h"
 #include <vector>
 #include <wx/brush.h>
-#include <wx/dcmemory.h>
 #include <wx/panel.h>
 #include <wx/dialog.h>
 #include <wx/gdicmn.h>
 #include <wx/pen.h>
 #include <wx/font.h> // member variable
-#include <wx/scrolbar.h>
 #include <wx/statusbr.h> // to inherit
 #include <wx/utils.h>
 #include "SampleFormat.h"
 #include "widgets/wxPanelWrapper.h"
 
+class wxMemoryDC;
+class wxScrollBar;
 class wxSlider;
 class wxTextCtrl;
 class wxButton;

src/HistoryWindow.cpp

@@ -28,6 +28,7 @@ undo memory so as to free up space.
 #include <wx/intl.h>
 #include <wx/listctrl.h>
 #include <wx/settings.h>
+#include <wx/spinctrl.h>
 #include <wx/stattext.h>
 #include <wx/textctrl.h>
 

src/HistoryWindow.h

@@ -12,11 +12,11 @@
 #define __AUDACITY_HISTORY_WINDOW__
 
 #include <wx/listctrl.h>
-#include <wx/spinctrl.h>
 
 #include "widgets/wxPanelWrapper.h"
 
 class wxButton;
+class wxSpinCtrl;
 class wxTextCtrl;
 class AudacityProject;
 class ShuttleGui;

src/LabelDialog.cpp

@@ -24,6 +24,7 @@
 #include <wx/filedlg.h>
 #include <wx/grid.h>
 #include <wx/intl.h>
+#include <wx/scrolbar.h>
 #include <wx/settings.h>
 #include <wx/sizer.h>
 #include <wx/stattext.h>

src/MixerBoard.h

@@ -18,7 +18,6 @@
 #include <wx/hashmap.h>
 #include <wx/image.h>
 #include <wx/scrolwin.h>
-#include <wx/statbmp.h>
 
 #include "widgets/ASlider.h"
 #include "widgets/wxPanelWrapper.h"

src/ModuleManager.h

@@ -12,8 +12,6 @@
 #ifndef __AUDACITY_MODULEMANAGER_H__
 #define __AUDACITY_MODULEMANAGER_H__
 
-#include <wx/dynlib.h>
-
 #include "MemoryX.h"
 #include <map>
 #include <vector>
@@ -21,6 +19,7 @@
 #include "audacity/ModuleInterface.h"
 
 class wxArrayString;
+class wxDynamicLibrary;
 class CommandHandler;
 
 wxWindow *  MakeHijackPanel();

src/ShuttleGui.h

@@ -359,7 +359,8 @@ extern void SetIfCreated( wxStaticText *&Var, wxStaticText * Val );
 class GuiWaveTrack;
 class AttachableScrollBar;
 class ViewInfo;
-#include <wx/scrolbar.h>  // to get wxSB_HORIZONTAL
+
+#include <wx/defs.h>  // to get wxSB_HORIZONTAL
 
 // CreateStdButtonSizer defs...should probably move to widgets subdir
 enum

src/SplashDialog.h

@@ -15,7 +15,6 @@
 #include <wx/dialog.h>
 #include "widgets/wxPanelWrapper.h"
 
-class wxStaticBitmap;
 class wxBitmap;
 class ShuttleGui;
 class AudacityProject;

src/Tags.cpp

@@ -60,6 +60,7 @@
 #include <wx/listctrl.h>
 #include <wx/notebook.h>
 #include <wx/radiobut.h>
+#include <wx/scrolbar.h>
 #include <wx/sizer.h>
 #include <wx/stattext.h>
 #include <wx/string.h>

src/TranslatableStringArray.h

@@ -11,7 +11,7 @@ Paul Licameli
 #ifndef __AUDACITY_TRANSLATABLE_STRING_ARRAY__
 #define __AUDACITY_TRANSLATABLE_STRING_ARRAY__
 
-#include <wx/app.h>
+#include <wx/app.h> // used in inline function template
 
 class wxArrayStringEx;
 

src/commands/Command.h

@@ -17,7 +17,6 @@
 #ifndef __COMMAND__
 #define __COMMAND__
 
-#include <wx/app.h>
 #include "../MemoryX.h"
 
 #include "CommandMisc.h"

src/effects/ChangePitch.cpp

@@ -31,6 +31,7 @@ the pitch without changing the tempo.
 #include <wx/choice.h>
 #include <wx/intl.h>
 #include <wx/slider.h>
+#include <wx/spinctrl.h>
 #include <wx/valtext.h>
 
 #include "../PitchName.h"

src/effects/ChangePitch.h

@@ -25,14 +25,13 @@ the pitch without changing the tempo.
 #include "SBSMSEffect.h"
 #endif
 
-#include <wx/spinctrl.h>
-
 #include "SoundTouchEffect.h"
 
 class wxSlider;
 class wxChoice;
 class wxCheckBox;
 class wxTextCtrl;
+class wxSpinCtrl;
 class ShuttleGui;
 
 #define CHANGEPITCH_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Change Pitch") }

src/effects/Reverb.cpp

@@ -21,6 +21,7 @@
 #include <wx/checkbox.h>
 #include <wx/intl.h>
 #include <wx/slider.h>
+#include <wx/spinctrl.h>
 
 #include "../Prefs.h"
 #include "../Shuttle.h"

src/effects/Reverb.h

@@ -12,12 +12,11 @@
 #ifndef __AUDACITY_EFFECT_REVERB__
 #define __AUDACITY_EFFECT_REVERB__
 
-#include <wx/spinctrl.h>
-
 #include "Effect.h"
 
 class wxCheckBox;
 class wxSlider;
+class wxSpinCtrl;
 class ShuttleGui;
 
 #define REVERB_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Reverb") }

src/effects/ladspa/LadspaEffect.h

@@ -15,7 +15,7 @@ class wxCheckBox;
 
 #include "../../MemoryX.h"
 #include <wx/dialog.h>
-#include <wx/dynlib.h>
+#include <wx/dynlib.h> // member variable
 
 #include "audacity/EffectInterface.h"
 #include "audacity/ModuleInterface.h"

src/toolbars/MixerToolBar.h

@@ -17,7 +17,6 @@
 class wxImage;
 class wxSize;
 class wxPoint;
-class wxStaticBitmap;
 
 class ASlider;
 

src/widgets/AttachableScrollBar.h

@@ -17,7 +17,7 @@
 #ifndef __AUDACITY_ATTACHABLE_SCROLL_BAR__
 #define __AUDACITY_ATTACHABLE_SCROLL_BAR__
 
-#include <wx/scrolbar.h>
+#include <wx/scrolbar.h> // to inherit
 
 class ViewInfo;
 

src/widgets/BackedPanel.h

@@ -10,7 +10,7 @@
 #define __AUDACITY_BACKED_PANEL__
 
 #include "../MemoryX.h"
-#include <wx/dcmemory.h>
+#include <wx/dcmemory.h> // member variable
 #include "wxPanelWrapper.h"
 
 

src/widgets/Grabber.h

@@ -33,7 +33,7 @@ flicker-free use.
 
 #include <wx/defs.h>
 #include <wx/gdicmn.h>
-#include <wx/statbmp.h>
+#include <wx/statbmp.h> // to inherit
 
 ////////////////////////////////////////////////////////////
 /// Grabber Class