Make Effect::PopulateUI final (no special case for Equalization)

src/effects/Effect.h

@@ -158,7 +158,7 @@ class AUDACITY_DLL_API Effect /* not final */ : public wxEvtHandler,
    // EffectUIClientInterface implementation
 
    void SetHostUI(EffectUIHostInterface *host) override;
-   bool PopulateUI(wxWindow *parent) override;
+   bool PopulateUI(wxWindow *parent) final;
    bool IsGraphicalUI() override;
    bool ValidateUI() override;
    bool HideUI() override;

src/effects/Equalization.cpp

@@ -723,19 +723,6 @@ bool EffectEqualization::Process()
    return bGoodResult;
 }
 
-bool EffectEqualization::PopulateUI(wxWindow *parent)
-{
-   mUIParent = parent;
-   mUIParent->PushEventHandler(this);
-
-   LoadUserPreset(GetCurrentSettingsGroup());
-
-   ShuttleGui S(mUIParent, eIsCreating);
-   PopulateOrExchange(S);
-
-   return true;
-}
-
 bool EffectEqualization::CloseUI()
 {
    mCurve = NULL;
@@ -746,6 +733,9 @@ bool EffectEqualization::CloseUI()
 
 void EffectEqualization::PopulateOrExchange(ShuttleGui & S)
 {
+   if ( S.GetMode() == eIsCreating )
+      LoadUserPreset(GetCurrentSettingsGroup());
+
    //LoadCurves();
 
    auto trackList = inputTracks();

src/effects/Equalization.h

@@ -131,7 +131,6 @@ public:
    bool Init() override;
    bool Process() override;
 
-   bool PopulateUI(wxWindow *parent) override;
    bool CloseUI() override;
    void PopulateOrExchange(ShuttleGui & S) override;
    bool TransferDataToWindow() override;