audacia/audacia
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make TypeToCreateLabel off by default.

Browse Source 
Following a lengthen discussion on the quality list, consensus is this option
should always have been off by default.  The main argument for not changing
it now was that 'on' is what users have come to expect.
This commit is contained in:
James Crook 2019-04-12 17:30:18 +01:00
parent 5e2a426cb3
commit f4aa75f4fc
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/LabelTrack.cpp
View File

@ -1749,7 +1749,7 @@ bool LabelTrack::DoCaptureKey(wxKeyEvent & event)
}
else {
bool typeToCreateLabel;
gPrefs->Read(wxT("/GUI/TypeToCreateLabel"), &typeToCreateLabel, true);
gPrefs->Read(wxT("/GUI/TypeToCreateLabel"), &typeToCreateLabel, false);
if (IsGoodLabelFirstKey(event) && typeToCreateLabel) {
AudacityProject * pProj = GetActiveProject();

2
src/Menus.cpp
View File

@ -636,7 +636,7 @@ void MenuManager::ModifyToolbarMenus(AudacityProject &project)
gPrefs->Read(wxT("/GUI/SyncLockTracks"), &active, false);
project.SetSyncLock(active);
commandManager.Check(wxT("SyncLock"), active);
gPrefs->Read(wxT("/GUI/TypeToCreateLabel"),&active, true);
gPrefs->Read(wxT("/GUI/TypeToCreateLabel"),&active, false);
commandManager.Check(wxT("TypeToCreateLabel"), active);
}

2
src/menus/LabelMenus.cpp
View File

@ -346,7 +346,7 @@ void OnPasteNewLabel(const CommandContext &context)
void OnToggleTypeToCreateLabel(const CommandContext &WXUNUSED(context) )
{
bool typeToCreateLabel;
gPrefs->Read(wxT("/GUI/TypeToCreateLabel"), &typeToCreateLabel, true);
gPrefs->Read(wxT("/GUI/TypeToCreateLabel"), &typeToCreateLabel, false);
gPrefs->Write(wxT("/GUI/TypeToCreateLabel"), !typeToCreateLabel);
gPrefs->Flush();
MenuManager::ModifyAllProjectToolbarMenus();

2
src/prefs/TracksBehaviorsPrefs.cpp
View File

@ -82,7 +82,7 @@ void TracksBehaviorsPrefs::PopulateOrExchange(ShuttleGui & S)
false);
S.TieCheckBox(_("&Type to create a label"),
wxT("/GUI/TypeToCreateLabel"),
true);
false);
S.TieCheckBox(_("Use dialog for the &name of a new label"),
wxT("/GUI/DialogForNameNewLabel"),
false);