Commit Graph

9686 Commits

Author SHA1 Message Date
SteveDaulton f207f5f7af Fix uninitialised variables
When importing an AUP project, selLow and selHigh may not be defined
in the project. If not defined, this causes an error on initialising
Nyquist. See: https://forum.audacityteam.org/viewtopic.php?f=48&t=118940
2021-07-04 20:02:12 +01:00
Paul Licameli 4b02e562b3 Eliminate mention of wxString from ErrorDialog.h ...
... whether std::wstring is the best alternative type, or whether we should
use UTF8 encoded std::string -- I wish to defer that, and revisit it later
2021-07-01 13:37:40 -04:00
Paul Licameli 132f04d272 ManualPageID is a new type; rewrite HelpSystem::ShowHelp and its uses 2021-07-01 13:35:57 -04:00
Paul Licameli cfbdd2d22e Type alias ManualPageID for wxString used in many places...
... eliminating many direct mentions of wxString.  A real type distinction will
be made next.
2021-07-01 13:33:04 -04:00
Paul Licameli 3c50935484 A type distinction for strings that are URLs, and some Doxygen 2021-07-01 13:02:26 -04:00
Paul Licameli 6fe7a7dfa1 Fix case of complete URL with anchor given to HelpSystem::ShowHelp...
... but there were no examples of this anywhere.

The assignment to webHelpPage was just overridden a few lines later.
2021-07-01 13:02:26 -04:00
Paul Licameli d5a22dfb15 Eliminate last use of PluginManager by ModuleManager, breaking cycle 2021-06-30 21:15:20 -04:00
Paul Licameli 02b61532fe ModuleManager doesn't use PluginManager to initialize providers 2021-06-30 21:15:20 -04:00
Paul Licameli 2e7f7114d2 ModuleManager defines the ID strings for modules, not PluginManager 2021-06-30 21:15:19 -04:00
Paul Licameli 50b384adae Separate files for PluginRegistrationDialog...
... so that PluginManager can avoid using GUI
2021-06-30 21:15:19 -04:00
Paul Licameli 710ec976ff Move class PluginRegistrationDialog to a header file 2021-06-30 21:15:19 -04:00
Paul Licameli ff0dd1ea48 Duplicate PluginManager.cpp in PluginRegistrationDialog.* 2021-06-30 21:15:19 -04:00
Paul Licameli 2ffd9d84c8 Restrict access to mutating member functions of PluginDescriptor...
... just enough for the PluginRegistrationDialog to do its work
2021-06-30 21:15:19 -04:00
Paul Licameli 04a0292d1d Simplify iterations over PluginManager; remove a friend 2021-06-30 21:15:19 -04:00
Paul Licameli 731ab8d554 Simplify repeated lookups and iterations in PluginManager 2021-06-30 21:15:19 -04:00
Paul Licameli 8fda526577 Simplify memory management in PluginManager 2021-06-30 21:15:19 -04:00
MalevolentStrix 4770b1f0a4 Bug 2740 - Directories in Directories preferences can be set to unwritable locations
Add a new function WritableLocationCheck() for checking
the directory permissions before setting preferences for
Open, Save, Import, Export, Macro Output and
Temporary Files directory in Edit->Preferences->Directories
and delete the old block of the same test
2021-06-30 06:39:46 -07:00
Paul Licameli 8d0487ea85 Undo frozen string workaround in Application preferences 2021-06-27 13:02:17 -04:00
MalevolentStrix bf14b2bef8 Used IdDirWritable() for checking write permissions for Bug #2740 2021-06-27 00:48:04 -04:00
Paul Licameli 77dab158c3 Make Audacity build in C++17 ...
... Fixing many conditional operators with explicit construction of wxString
instead of simple string literals;

And fixing allocation of more strictly aligned structures on Mac, without need
for 10.14 as the minimum SDK, by means of some class-specific operators new
and delete.
2021-06-18 21:44:55 +03:00
Dmitry Vedenko e6e81399f7
Fixes alphabetical order in credits 2021-06-18 18:38:40 +03:00
Paul Licameli 6b82f43000 Additions to credits 2021-06-18 09:58:27 -04:00
gera 87d94fe249 Add new review recommendations.
Clean up extra code, remake static title, move settings to UpdateManager class.
2021-06-18 09:46:40 -04:00
gera 93b9bcf470 Add review recommendations. 2021-06-18 09:46:40 -04:00
gera d9ab95a4b2 Add application preferences with update checkbox. 2021-06-18 09:46:40 -04:00
gera d6f95c8575 Add Audacuty naming style and fix macOS assertion. 2021-06-18 09:46:40 -04:00
gera ec0554e131 Add some recommends and delete extra static methods. 2021-06-18 09:46:40 -04:00
gera d15d88af71 Add recommends from review. 2021-06-18 09:46:40 -04:00
gera c7a24df915 Add recommends from review. 2021-06-18 09:46:40 -04:00
gera 0ab6aefe11 Merge with master and resolve CI configure script conflict. 2021-06-18 09:46:40 -04:00
James Crook 183d3dd1d8 Bug 2807 - Error message for a failed import of malforned MP3 lacks a "?" help button 2021-06-17 17:45:27 +01:00
Dmitry Vedenko 045fcbf688 Fixes #984
Fix uses the approach proposed by David Bailes
2021-06-16 11:54:20 -04:00
Peter Jonas de2213ea2c Generate AppImage on GitHub Actions
Fixes #695. Supersedes #172. See https://appimage.org/.
2021-06-16 11:00:16 -04:00
Paul Licameli d167b0bc83 Correct Japanese strings for Linux destkop and Windows installer...
... as suggested by 森の子リスのミーコの大冒険 <phroneris@gmail.com>
2021-06-15 21:39:01 -04:00
Vitaly Sverchinsky e8b186a9b4 Crashreporting 2021-06-15 22:44:07 +03:00
dofuuz 060885c4f6 Changes to Spectrogram color scheme user-visible strings because of string freeze 2021-06-15 12:41:44 -04:00
dofuuz e9f0590c28 Add spectrogram preference migration from old 'Grayscale' checkbox to new 'Color Scheme' choice 2021-06-15 12:41:44 -04:00
dofuuz e135bcf16f Some more cleanup for new spectrogram color scheme
- Add some assertion
- Define spectrogram color scheme name using the two-argument constructor. (i18n)
2021-06-15 12:41:44 -04:00
dofuuz 474f05d414 New colormap for Spectrogram
- Add color scheme preference

Add 'Spectro. Color scheme' to 'Set Track Visuals' macro command
2021-06-15 12:41:44 -04:00
dofuuz ca58443644 Refactor AColor.cpp 2021-06-15 12:41:44 -04:00
Paul Licameli 5cf1d514f6 Made new strings agree with FutureStrings.h; removed from there 2021-06-13 19:24:12 -04:00
Paul Licameli bb907fca48 "Menu Tree" doesn't need to translate 2021-06-11 17:44:42 -04:00
James Crook 858517f404 Update credits
Buanzo, Leland and Bill move to 'Emeritus'.
2021-06-11 22:32:42 +01:00
Paul Licameli 2c4ed8b31f Bug2800: File>Open should allow non-project from a FAT drive...
... but still disallow it for .aup3 files.

The fix is a simple moving of the check for a FAT filesystem after several
other checks that distinguish types of imported files.
2021-06-10 17:13:45 -04:00
Peter Jonas 4b5c95d7fe Move GitHub Actions CI scripts into separate files
Break the workflow into smaller stages (Configure, Build, Install,
Package, etc.) so that you can see exactly which stage failed in the
GitHub Actions run log.

Create a separate Bash CI script for each job stage (configure.sh,
build.sh, install.sh, package.sh, etc.) to reduce the size of the main
YAML workflow file and enable Bash syntax highlighting.

Close #917
2021-06-10 10:09:49 -07:00
Paul Licameli 3ebebbb360 Add a string for after 3.0.3, to disambiguate "Recording"...
... as suggested by Sampo Hippeläinen.
2021-06-10 12:07:33 -04:00
Paul Licameli e2fda7df32 Better node names for 3p libraries in picture of dependencies 2021-06-09 15:06:21 -04:00
James Crook 404ad6ad8a Bug 2803 - Audacity unresponsive after 'Fit to Height'
a) Fixed root cause, which is conversion of a
negative integer to a large unsigned, leading to
a very tall track.
b) Improved mitigation (in projects that already
have over tall tracks) by setting a smaller minimum
for the allowed size.
2021-06-08 22:05:56 +01:00
James Crook 1b9e938869 Fix / workaround for bad track heights.
The root cause of the bad track height hasn't been tracked down
yet.  It  may be related to collapsing tracks as it was first seen with
all tracks collapsed.
2021-06-08 19:29:55 +01:00
Dmitry Vedenko 97914403f6 Updates Doxygen documentation 2021-06-08 08:08:26 -07:00