Commit Graph

19 Commits

Author SHA1 Message Date
Paul Licameli 9d6dd45973 More use of constSamplePtr instead of samplePtr 2020-11-29 19:45:18 -05:00
Paul Licameli 0d910bbe02 EnumSetting has a template parameter 2019-11-27 13:37:24 -05:00
Paul Licameli 9b67e7538f ChoiceSetting contains vectors; simplify constructions of it 2019-11-27 13:37:23 -05:00
Paul Licameli 82f4948360 Dither.cpp and SampleFormat.cpp have fewer dependencies...
... Notably they longer depend indirectly on AudioIO.cpp (via QualityPrefs)

This frees nine files from dependency cycles
2019-05-18 20:29:25 -04:00
Paul Licameli 5e7d41ec07 Each .cpp/.mm file includes corresponding header before any other...
... except Audacity.h

This forces us to make each header contain all forward declarations or nested
headers that it requires, rather than depend on context.
2019-03-17 22:54:52 -04:00
James Crook 5fd95dd131 Fix C4456 Warnings.
"C4456 declaration hides previous local declaration."
These arise from repeated declarations of the same name.
2018-10-10 17:28:50 +01:00
Paul Licameli a3d12e1658 Make enum class for dither type 2018-03-25 14:48:01 -04:00
Paul Licameli 7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
benjamin.drung@gmail.com 277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
martynshaw99 4ce2643d5f Remove the
// Indentation settings for Vim and Emacs
etc. lines from all files, as Campbell's patch (except for other changes to Languages.cpp)
2013-09-24 00:14:37 +00:00
lllucius abae5de768 Okay, try #3(!)
The problem from the beginning has been that some parts of the code expected to
receive interleaved buffers from Dither and some expected non-interleaved buffers.
I was trying to keep the changes to a minimum, but it just wasn't possible.

The result is that Dither can now accept any combination of non-interleaved and
interleaved source and destination buffers.

I still want to review every single usage of Dither (and all of the intermediaries)
because I've seen allowances here and there for the lack of Dither returning
interleaved buffers.  Since it can now return interleaved buffers, some of that
extra processing can be removed.
2013-09-19 07:30:58 +00:00
lllucius 3e8e94767c Just wanted to add a little doc to explain the parameters... 2013-09-18 13:26:20 +00:00
lllucius 4b23eb342d Partially revert R12560.
Changing the way interleaving was handled by Dither was not the right thing to do.  The actual fix for the original issue was fixed with the changes to Mix.cpp.
2013-09-18 04:49:52 +00:00
v.audacity 3fc912710b Leland's minimal_v2.patch for bug 650 2013-09-16 02:32:43 +00:00
martynshaw99 61410ebd79 In 'Shaped' dither, do the best we can with a NaN.
Reset the filter every time to prevent one conversion affecting the next.
2012-02-10 00:12:59 +00:00
mchinen de73791a79 revert 11465, going back to the original solution for clipping to prevent bad exports 2012-02-09 05:23:16 +00:00
martynshaw99 5b3f3f71ea Stop an overflow with large (>100dB) sample values. 2012-02-08 01:06:16 +00:00
mchinen 54f7e4590b Fix dithering for float to int case when float values are greater than 0db. Also made DITHER_LOOP macro more readable but did not change content 2012-02-05 10:31:18 +00:00
ra e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00