Leland Lucius
b1beb20ae9
AUP3: Remove obsolete audio file cache
2020-07-01 01:14:10 -05:00
Leland Lucius
cbf1bb558e
AUP3: Removes OD code related to project file handling
...
This removes all of the OnDemand code embedded throughout
the main codebase. Individual files related specifically
to OD have been left in place, but removed from the build.
2020-07-01 01:14:05 -05:00
Paul Licameli
4a56af43aa
Bug2442 residual: Review AudacityException classes...
...
... Have copy constructors only (no moves); disallow all assignments
2020-06-05 13:48:53 -04:00
Yuri Chornoivan
d1ada5f08c
Fix minor typos
2020-04-11 10:06:24 +01:00
Paul Licameli
2570b56176
Rename Maybe and its members more like std::optional of C++17
2020-01-19 11:38:12 -05:00
Paul Licameli
503ccabdd8
TranslatableString caption & message in MessageBoxException
2019-12-16 10:58:05 -05:00
Paul Licameli
586eb0d4cb
Break cycle of ODDecodeBlockFile and ODDecodeTask
2019-07-09 13:39:08 -04:00
Paul Licameli
0b85251885
Fewer inclusions of AudioIO.h and Import.h
2019-06-06 12:53:20 -04:00
Paul Licameli
ca0fb190e6
Register factory functions with DirManager to interpret XML tags...
...
... Removes direct dependency on ODManager.h and some BlockFile subclasses,
but does not yet break any dependency cycles
2019-05-18 20:32:19 -04:00
Paul Licameli
81d4c217e6
Rewrite DirManager::EnsureSafeFileName without downcasts...
...
... weakening but not yet eliminating dependency on BlockFile subclasses
2019-05-18 20:32:19 -04:00
Paul Licameli
2faa24c96b
Move ProjectFSCK out of DirManager...
...
... which makes DirManager.cpp not depend on MissingAliasFileDialog.cpp
2019-05-18 15:06:50 -04:00
Paul Licameli
6c57948d8f
Remove unnecessary #include-s from .cpp files...
...
... Unnecessary because transitively included.
But each .cpp file still includes its own .h file near the top to ensure
that it compiles indenendently, even if it is reincluded transitively later.
2019-05-16 17:21:00 -04:00
Paul Licameli
548192fcf3
Remove redundant #include-s from .h files...
...
Redundant, because transitively implied. But don't do this for inclusions of
Audacity.h or Experimental.h.
2019-05-16 14:58:34 -04:00
Paul Licameli
56f51d8176
Revert "Remove redundant #include-s from .h files..."
...
This reverts commit b7fe62d170
.
2019-05-16 14:33:55 -04:00
Paul Licameli
b7fe62d170
Remove redundant #include-s from .h files...
...
Redundant, because transitively implied. But don't do this for inclusions of
Audacity.h or Experimental.h.
2019-05-16 14:15:05 -04:00
Paul Licameli
d90a827e03
Remove unneeded #include-s of AudacityApp.h
2019-05-15 15:58:00 -04:00
Paul Licameli
f6adeed47b
Remove some unnecessary #include directives
2019-05-15 14:14:18 -04:00
Paul Licameli
4714d72b3f
Can't remove remaining wx headers from other headers, comment that
2019-03-31 01:41:16 -04:00
Paul Licameli
ec2f26e48c
Remove wx/pen.h, wx/thread.h from headers
2019-03-30 10:17:18 -04:00
Paul Licameli
3760db9dff
Remove wx/wxchar.h from headers
2019-03-29 15:56:54 -04:00
Paul Licameli
803d8b9559
Remove wx/filename.h, wx/choice.h, wxFileNameWrapper.h from headers
2019-03-28 03:12:42 -04:00
Paul Licameli
1d0247607a
Remove wx/string.h from headers
2019-03-26 11:33:55 -04:00
Paul Licameli
173a300427
Include nothing before Audacity.h, as comments say we should...
...
... and remove some duplicated inclusions
2019-03-17 21:41:39 -04:00
Paul Licameli
a30000cf74
Use type aliases FilePath, FilePaths...
...
... for wxString and wxArrayStringEx, holding file paths (absolute or relative,
directory or plain file); to be replaced later with different types
(not yet using std::vector, becase of some uses of wxArrayString::Index with
two arguments)
2019-03-15 15:18:11 -04:00
Paul Licameli
c68e336247
More use of std:: style members of wxString...
...
... replacing:
Length => length
Len => length
2019-03-10 14:44:54 -04:00
Paul Licameli
4ba373f2d9
Failed open of block file gives correct error message
2019-02-13 14:17:00 -05:00
Paul Licameli
ac373502a9
Don't need AudacityException::Move, use std::exception_ptr
2018-05-10 00:56:37 -04:00
James Crook
b60fae4470
Fix some warnings on mac
...
These are mostly missing 'overrides'
2018-04-07 20:28:27 +01:00
Paul Licameli
c6696f1b49
Move definition of _ and related into Internat.h
2018-01-06 21:03:32 -05:00
Paul Licameli
7fd78183d2
Remove needless uses of wxString::c_str() in wxString::Format...
...
... and similar wx "variadics," which all treat wxString smartly enough that
you don't need this.
Don't need c_str either to convert wxString to const wxChar * because
wxString has a conversion operator that does the same.
2018-01-01 20:34:33 -05:00
Paul Licameli
4d978bcefb
Use wxPrintf not printf
2017-12-16 11:54:32 -05:00
James Crook
f463eda36c
Clean up some dead code and MSVC warnings.
...
- Dead code from experiments in SelectionBar removed.
- Many warnings about unused parameters fixed with WXUNUSED()
- Many warnings about signed / unsigned comparisons cleaned up.
- Several 'local variable declared but not used' warnings fixed.
2017-12-08 15:20:39 +00:00
James Crook
c28be778e2
Linty fixes
...
This commit fixes a number of warnings shown in compilation with MSVC. No behavioral changes intended. I did not fix signed/unsigned warnings.
2017-11-07 14:23:30 +00:00
Paul Licameli
f0de38dec1
Scanned for bad naked new; found none; changed comments, used safenew
2017-07-23 09:35:01 -04:00
Paul Licameli
55439247ad
All the catches are in place for BlockFile and other errors, now throw.
2017-04-03 23:32:40 -04:00
Paul Licameli
987b038fd8
Exception safety in overrides of WriteSummary
2017-03-21 17:23:35 -04:00
Paul Licameli
98d1468a01
BlockFile::ReadData overrides: on failure, pad with 0s or throw...
...
... as the mayThrow argument directs.
2017-03-21 14:19:03 -04:00
Paul Licameli
70d9e4bdc7
GetMinMax, GetRMS functions take a mayThrow argument, return numbers
2017-03-21 14:19:02 -04:00
Paul Licameli
ed6f2ea80f
Exception safety in: locking of BlockFile for read
2017-03-21 14:11:27 -04:00
Paul Licameli
7159966eb4
Comment that cache-filling should be no-fail (we don't use it anyway)
2017-03-21 14:11:26 -04:00
Paul Licameli
664974d3ff
Exception safety in: ondemand
2017-03-21 14:11:20 -04:00
Paul Licameli
7927fe065f
Fix move constructors and assignments of AudacityException classes
2017-03-21 14:11:17 -04:00
Paul Licameli
2677796b0c
Zero and return false for all failures to read block file summary...
...
... Though in the only place where these summaries are used, which is
Sequence::GetWaveDisplay, we ignore the correctly reported error code anyway.
Also RAII in management of relevant memory buffers and mutexes.
2017-03-20 17:49:03 -04:00
Paul Licameli
b81cdee7e3
Comment where xml writing functions may throw
2017-03-18 11:45:05 -04:00
Paul Licameli
9fde75268f
Define an AudacityException subclass for unready on-demand data
2017-03-17 17:52:58 -04:00
Paul Licameli
5de19dc952
ODDecode task checks blockfile error, making no progress if so...
...
... also replace explicit mutex locking with RAII and atomics.
This is a part of the big project that handles failure to write block files, as
from disk exhaustion. ODDecodeBlockFile::WriteODDecodeBlockFile is the one
place calling WriteSimpleBlockFile but not (as in SimpleBlockFile constructor)
throwing an exception.
It is called only when attempting to recover files at open time, or in worker
threads in an EXPERIMENTAL code branch.
2017-03-17 17:52:55 -04:00
Paul Licameli
e6db1a57a3
Remove naked new[] in: blockfile and commands
2017-03-17 17:52:46 -04:00
Paul Licameli
aebaaf46a0
require unsigned arguments for Array(s)Of::reinit
2017-03-17 17:52:43 -04:00
Paul Licameli
38236a807c
More new -> NEW, delete -> DELETE in comments
2017-03-17 17:52:41 -04:00
Paul Licameli
a4a9df5c03
One function for the common parts of BlockFile::ReadData overrides
2017-03-17 17:52:27 -04:00