Commit Graph

48 Commits

Author SHA1 Message Date
Paul Licameli
4739f3e27b Compensate for wxW 3 tab navigation deficiencies on Mac...
... using char hook event handlers.  We don't need to go the extreme length
of patching wxWidgets source.
2016-06-25 19:14:05 -04:00
Paul Licameli
61177a15ad More consistent mutual exclusion in calls to certain sf_ functions; ...
... also SFCall to simplify thread-safe calls, and SFFile for RAII of SNDFILE
objects.
2016-04-14 15:20:37 -04:00
Paul Licameli
ff3e3d0e83 ExportPlugin::CreateMixer returns a smart pointer 2016-04-06 14:56:05 -04:00
Paul Licameli
456c8fb01e ExportPlugins managed with smart pointers 2016-04-06 14:08:42 -04:00
Paul Licameli
43790cfa56 std::vector for wave track pointers; remove deprecated TrackList function; ...
... and some more uses of const
2016-03-01 20:54:48 -05:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
a5b6c9fd8f Add some const qualifiers; define TrackListConstIterator 2016-02-24 19:10:39 -05:00
Paul Licameli
ffe9989f7c Don't use an internal iterator in Tags 2016-02-24 19:10:38 -05:00
Paul Licameli
83e8a80f61 Sweep unnecessary wxString copies: export 2016-02-22 22:22:25 -05:00
Paul Licameli
dbaa811577 Stack-allocate where possible! ...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
df6a7c5464 More uses of safenew for classes we derive from wxWindow classes...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
53a8b44f1d Bug1217: Export "other uncompressed files" now uses correct default extension...
... but there is this consequence:  If you do type an explicit extension,
which is one of the acceptable extensions though different from the
"Header:" chocie, then it is also corrected, silently.  This behavior is
different from other cases where the user types an inappropriate explicit
extension and is prompted to fix it.
2016-01-26 13:48:37 -05:00
Leland Lucius
9dd79c9f80 Remove flushing of preferences in ShuttlePrefs and only
flush when all settings have been written.
2015-12-21 20:07:24 -06:00
Leland Lucius
6a9dae20f5 Appearance on OSX is now back to normal or better
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Leland Lucius
617e0713df This should fix bug #1111
In addition it adds an option to open the full FFmpeg options
dialog.
2015-08-05 02:28:42 -05:00
Leland Lucius
37168ebbf6 Merge remote-tracking branch 'upstream/master' into wx3 2015-07-28 15:06:25 -05:00
Paul Licameli
51d7b3670c Remove LabelTrack.h from other headers 2015-07-28 10:02:07 -04:00
Paul Licameli
d39eaa4e65 Remove WaveTrack.h from other headers 2015-07-28 10:02:05 -04:00
Leland Lucius
3fe146f306 Merge remote-tracking branch 'upstream/master' into wx3 2015-07-19 18:00:02 -05:00
Paul Licameli
e70f91c64e Removed ShuttleGui.h from other headers 2015-07-19 12:31:03 -04:00
Leland Lucius
2f760c4bac Round 4 of wx3 changes
This gets FileDialog updated and working on Windows.  It also
removes removes the "wx3" build configurations and makes the default
Debug and Release builds wx3-only.

Still need to get VSTs updated.
2015-07-13 16:38:24 -05:00
Leland Lucius
4deccfc980 Round 3 retry...helps to add the changed files to the commit 2015-07-13 12:36:40 -05:00
Leland Lucius
0ef7ccb1d1 Fix permissions...not sure why this was happening though 2015-05-29 19:49:28 -05:00
Leland Lucius
e5f6a44656 Fix for bug #983
Now we know why the "automatically add extension" stuff was
commented on in the FileDialog at least.  :-)
2015-05-29 13:02:17 -05:00
Leland Lucius
9025831e64 Remove GSM from export types
It's still available in the "Other uncompressed files" item.
2015-05-26 07:09:05 -05:00
David Bailes
f458df1c7b Changes to a number of dialogs so that the NVDA screen reader can read the titles. Missed these in my last patch. The accessibility name of the dialog is set to the title. 2015-05-18 13:57:05 +01:00
Leland Lucius
f804e5049e Hyphenate all 8, 16, 24, 32 and 64 bit strings 2015-05-04 12:32:47 -05:00
Leland Lucius
287c649f4f Correct "float" entry to read "32 bit float" instead 2015-05-04 02:37:41 -05:00
Daniel Winzen
759ff8cd0d Performance improvements 2015-04-23 16:07:25 +02:00
Leland Lucius
41b8850f72 Correct and simplify format definition 2015-04-20 07:56:09 -05:00
Leland Lucius
d8c8ee3076 Added "WAV (Microsoft) float PCM" to the file types 2015-04-19 23:24:29 -05:00
lllucius
bdcefb4850 Preliminary changes for wxWidgets 3.0.1
We can't go to 3.0.1 yet as there are still build issues on
Linux and OSX.  You can get Windows to build, but there's
still some display issues.

These changes should work with wxWidgets 2.8.12 as well, so
we can take our time to get things working properly before
switching over.
2014-10-06 08:10:50 +00:00
benjamin.drung@gmail.com
277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
RichardAsh1981@gmail.com
6a7da21dec remove various unused #defines and bits of code, patch by Campbell Barton 2013-09-23 20:16:02 +00:00
RichardAsh1981@gmail.com
2b7863a133 commit the final version of Joel Bouchat's patch for WAV and AIFF format metadata improvements 2013-08-23 10:01:29 +00:00
v.audacity
51e0391b7d Campbell Barton's patch for mem leaks, http://www.graphicall.org/ftp/ideasman42/audacity_mem_leak_fix_r12450.diff 2013-08-03 00:24:26 +00:00
RichardAsh1981@gmail.com
d571ece7e6 Apply patch from Joel Bouchat to improve WAV tag importing and exporting for non-ASCII characters, making sure that it works in UTF-8 locales 2013-07-31 10:21:41 +00:00
v.audacity
8ad21677b8 Improve a comment. 2013-06-29 00:27:43 +00:00
v.audacity
75bbcc6884 BYTE is Windows only. Change it to unsigned char. 2013-06-28 22:34:58 +00:00
v.audacity
714049ffce 2013-06-28 03:41:14 +00:00
richardash1981
1fd52b3796 cleanup of exporters based on patch by Campbell Barton: Include headers into classes, remove tail comments, correct the factory method comments 2013-03-03 20:25:59 +00:00
v.audacity
ebb4f530bb Apparently, wxConfigBase::Write() does not update values for next access on all platforms unless Flush() method is called. Added many calls to wxConfigBase::Flush() to make sure the Rad() calls get the right values. 2012-08-02 06:03:19 +00:00
mchinen
a9a0d51454 Timetrack fixes and refactoring.
Possibly fixes:

Bug 206 - Time Tracks: Ruler warp goes in wrong direction
Bug 205 - Time Tracks that slow down the audio result in truncated exports
2010-10-07 23:01:49 +00:00
mchinen
ff7c013f16 fix clipping on export 24 bit signed pcm wav (bug 166) 2010-06-15 17:51:23 +00:00
richardash1981
430c64084f Add i18n hint for the libsndfile error message, in response to query from Atsushi YOSHIDA 2010-03-06 16:27:23 +00:00
richardash1981
68f7665a70 Commit an improved version of patch by Benjamin Drung to check if data is sucessfully being exported or not when saving files through libsndfile, and warn the user if the export fails. 2010-02-20 22:20:26 +00:00
ra
e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00