32f24eabb2
Review uses of safenew...
...
... add comments and assertions, and use make_unique instead where possible
2016-08-13 23:16:05 -04:00
e599cfa6fa
Effect::mOutputTracks is managed by smart pointer
2016-08-13 10:37:51 -04:00
11305b956f
Use make_unique for wxMenu objects
2016-08-10 11:05:52 -04:00
fec4069d9d
Some uses of Destroy_ptr let us remove some naked news
2016-08-10 11:05:51 -04:00
384fc4a4ae
Prefer Destroy() to deleting a window
2016-08-10 11:05:50 -04:00
6fec00149b
Remove some naked new amd delete in: Built-in Effects
2016-08-08 07:51:25 -04:00
e24d6d825f
Bug 858: Update recording error message too
...
Also remove redundant 'while' in the messages
2016-07-27 16:48:30 +01:00
6629733d35
Bug 858 - Update error message
...
Trying Gale's suggestion from
http://bugzilla.audacityteam.org/show_bug.cgi?id=858#c2
2016-07-24 16:35:17 +01:00
ab135ff478
Disallow enabling RT preview when setting invalid
2016-07-24 15:41:15 +01:00
84c0337aba
Fix TAB key navigation on Mac for all dialogs (not only for panels)
2016-07-10 17:12:27 -04:00
2a6a1b2679
Revert "Bug1329, partial: Enter invokes OK button again for effects on Mac"...
...
... because other fixes for Mac keyboard navigation have made this unnecessary.
2016-06-28 12:04:49 -04:00
4739f3e27b
Compensate for wxW 3 tab navigation deficiencies on Mac...
...
... using char hook event handlers. We don't need to go the extreme length
of patching wxWidgets source.
2016-06-25 19:14:05 -04:00
995db14fd9
Bug1329, partial fix: redo it as a Mac-only change
2016-06-14 15:31:29 -04:00
dfa91655d3
Bug1329, partial: Enter invokes OK button again for effects on Mac
2016-06-14 01:11:23 -04:00
36e5b4fbbc
AudioIOStartStreamOptions includes the sample rate
2016-05-22 15:27:35 -04:00
014d5ab93c
Type safety in the use of command flags, and make enum wide, allowing more bits
2016-05-05 20:02:13 -04:00
f2c6fbfc1b
Bug1318 fixed again so that generators and effects on Windows still work
2016-04-24 10:32:20 -04:00
879ecefdaa
Bug1318: ESC key or red close button should not leave the app unresponsive...
...
... I don't fully understand why this fixes it, but I could figure out what
was different between ESC and Cancel button which did not have the problem.
2016-04-23 08:49:11 -04:00
d5915491b3
Bug1342: Loop-play (and other things) before scrub (and other things)...
...
... should not disable auto-scrolling of the window during playback.
2016-04-18 17:50:17 -04:00
df45886d6b
Bug1340: sync-lock should work when generating audio
2016-04-05 17:06:24 -04:00
13595620cf
Fix mac build
2016-03-30 23:24:39 -04:00
a6ca36cdab
TrackList holds smart pointers to tracks, Add() only takes rvalue refs to such
2016-03-26 15:41:31 -04:00
c5a70126eb
TrackList always deletes tracks on destruction or when cleared
2016-03-26 15:41:29 -04:00
bc5519a0e2
TrackList::Remove and TrackListIterator::RemoveCurrent always delete the track
2016-03-26 15:41:26 -04:00
4edc960acd
Redo Effect::ReplaceProcessedTracks without RemoveCurrent
2016-03-26 15:41:25 -04:00
c4fc7e2bf0
MixAndRender returns unique_ptr results (in a std::pair)
2016-03-26 11:50:14 -04:00
3015a9c8d9
Track cut and copy functions return a unique_ptr argument...
...
... Because they are factory functions.
2016-03-26 11:50:13 -04:00
5ef4dd46a5
TrackFactory functions return std::unique_ptr, although some callers...
...
... release() them for now.
2016-03-26 11:50:12 -04:00
f42a953752
Track duplication methods return unique_ptr, although some callers...
...
... simply release() them for now.
2016-03-26 11:50:10 -04:00
311a471286
Less scary message if can't update effect settings
2016-03-09 21:20:54 +00:00
9dc9348127
Fixes bug #1344 (mac build)
...
In addition, the Xcode project can now build against the 10.6
or 10.7 SDKs. All that is needed is to change the SDK version
and the other settings will change automatically.
2016-03-07 00:29:26 -06:00
43790cfa56
std::vector for wave track pointers; remove deprecated TrackList function; ...
...
... and some more uses of const
2016-03-01 20:54:48 -05:00
7aee5d09d8
Move the recent const_casts elsewhere
2016-02-29 19:56:27 -05:00
0094c4f465
Bug1348, partial: Fix bad undo after cancelling Vamp or FindClipping analyzer
2016-02-27 18:12:36 -05:00
60bcd7aea2
Fix warnings for unused variables and functions
2016-02-26 14:56:26 -05:00
990080ae7d
Replace virtual with override wherever possible; eliminate needless virtual...
...
... for functions in final classes.
override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.
There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
7824e94030
Harmlessly qualify classes as final (or explicitly comment not)...
...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls. Mostly useful as documentation of design intent.
Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
99f161c36c
Sweep unnecessary wxString copies: effects
2016-02-22 22:31:47 -05:00
1c07741d57
Sizers are owned by wxWindow objects when added, so use safenew, or...
...
... use unique_ptr in the interim between building them and adding.
This checks eliminates some naked news, which were not paired with deletes.
2016-02-18 18:58:38 -05:00
4d78e353c3
Revert "sizers"
...
This reverts commit 84c0a0b666
2016-02-18 14:50:52 -05:00
84c0a0b666
sizers
2016-02-18 02:54:50 -05:00
dbaa811577
Stack-allocate where possible! ...
...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
df6a7c5464
More uses of safenew for classes we derive from wxWindow classes...
...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
3f237daddc
Use macro safenew for many allocations of wxWindow subclasses
2016-02-14 20:20:19 -05:00
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
56e7653343
"delete"->"DELETE" in comments, easier to find remaining naked operator delete
2016-02-14 18:50:45 -05:00
97e8fe3864
include <algorithm> to fix Windows build
2016-01-21 10:41:03 -05:00
46055cde25
Fix effect preview issues
...
Fixes bug 1274 and unblocks bug 995.
2016-01-20 18:19:11 +00:00
13f13490e6
Fix for Bug 1267 - Accessibility: some panels used for graphics are included in tab traversal
...
Bug due to update and wxWidgets bug 1267.
Fix is to add the override of AcceptsFocusFromKeyboard().
2015-11-26 15:21:48 +00:00
9c483e2e86
Add (redundant) #include "Experimental.h" in all .cpp files using the symbols
2015-08-31 17:56:10 -04:00
Paul Licameli
windinthew
Steve Daulton
Paul Licameli
Leland Lucius
David Bailes