Commit Graph

44 Commits

Author SHA1 Message Date
Paul Licameli f8fe26ca36 Add columns to Label editor for low and high spectral selection 2016-06-27 18:41:43 -04:00
Paul Licameli 9c687f055c Generalize TimeRenderer and TimeEditor to handle frequencies in grid 2016-06-27 18:41:42 -04:00
Paul Licameli c3b4ea165f Bug1428: Don't make negative label start time from label edit dialog 2016-06-27 17:40:49 -04:00
Paul Licameli 53e30e5533 Label context menu can bring up the edit dialog 2016-06-26 13:34:52 -04:00
Paul Licameli 42fcfdab98 Fewer naked news and deletes in Tags.cpp and LabelDialog.cpp 2016-04-08 21:16:18 -04:00
Paul Licameli c87eb0804b Unreported bugs: memory leaks, assertions dismissing Tags and Label editors...
Symptoms were:

Edit metadata; ESC; exit audacity -- memory leaks.

Edit metadata; single-click "Genre" field twice; ESC -- assertion violaion in
Windows debug build.

Make a label; Track > Edit Labels; single-click time field twice; esc -- also
caused assertions, then memory leak at exit.

However, there are still two small memory leaks at exit after using Label
editor, yet unexplained.
2016-04-08 20:48:58 -04:00
Paul Licameli a6ca36cdab TrackList holds smart pointers to tracks, Add() only takes rvalue refs to such 2016-03-26 15:41:31 -04:00
Paul Licameli 5ef4dd46a5 TrackFactory functions return std::unique_ptr, although some callers...
... release() them for now.
2016-03-26 11:50:12 -04:00
Paul Licameli 5162ab5c5b Use TrackFactory in more places...
... There should now be no direct allocation of Track subclasses with new,
except in those classes' own methods
2016-03-26 11:50:09 -04:00
Paul Licameli 9bf098c7d9 Sweep unnecessary wxString copies: rest 2016-02-23 02:15:56 -05:00
Paul Licameli 1c07741d57 Sizers are owned by wxWindow objects when added, so use safenew, or...
... use unique_ptr in the interim between building them and adding.

This checks eliminates some naked news, which were not paired with deletes.
2016-02-18 18:58:38 -05:00
Paul Licameli 4d78e353c3 Revert "sizers"
This reverts commit 84c0a0b666.
2016-02-18 14:50:52 -05:00
Paul Licameli 84c0a0b666 sizers 2016-02-18 02:54:50 -05:00
Paul Licameli dbaa811577 Stack-allocate where possible! ...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli 3f237daddc Use macro safenew for many allocations of wxWindow subclasses 2016-02-14 20:20:19 -05:00
Paul Licameli 7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli 56e7653343 "delete"->"DELETE" in comments, easier to find remaining naked operator delete 2016-02-14 18:50:45 -05:00
Paul Licameli d2a7f35f98 One less indirection accessing RowData 2016-02-03 22:14:30 -05:00
David Bailes 83830d52eb Fix for bug 1254
In LabelDialog::Show(bool show), only set initial row when show == true.
2015-11-25 09:20:24 +00:00
Leland Lucius 6a9dae20f5 Appearance on OSX is now back to normal or better
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Paul Licameli b89c2a130c Remove Track.h from other headers 2015-07-28 10:02:03 -04:00
Paul Licameli e70f91c64e Removed ShuttleGui.h from other headers 2015-07-19 12:31:03 -04:00
David Bailes 7b88005899 Change to the initial row selected in label editor. The initial row is the nearest previous label. If there is not one, then its the first label. 2015-05-21 14:16:06 +01:00
David Bailes 66084b65ef Changes to a number of dialogs so that the nvda screen reader can read their titles. The accessibility name of the dialog is set to the title of the dialog. 2015-05-16 09:35:21 +01:00
david avery 0319f6ea51 merging wx3 changes 2015-04-12 23:52:32 -06:00
james.k.crook@gmail.com 67d2b274e2 Frequency Selection toolbar from Paul Licameli.
Linux/Mac will need new files adding to project, SpectralSelectionBar.cpp, NumericTextCtrl.cpp.
2014-11-08 15:18:43 +00:00
lllucius bdcefb4850 Preliminary changes for wxWidgets 3.0.1
We can't go to 3.0.1 yet as there are still build issues on
Linux and OSX.  You can get Windows to build, but there's
still some display issues.

These changes should work with wxWidgets 2.8.12 as well, so
we can take our time to get things working properly before
switching over.
2014-10-06 08:10:50 +00:00
james.k.crook@gmail.com f5e593cc4c Paul L's new SelectedRegion class replacing use of t0 and t1. Also LabelTrack.h no longer in TrackPanel.h includes.
This change is believed to be a direct refactoring that does not change functionality.  It paves the way for more complex kinds of selection, such as selections involving frequency as well as time.  It also reduces risk of left and right edges being swapped in future code using SelectedRegion, as the default is to swap on assignment if needed.
2014-10-05 17:10:09 +00:00
RichardAsh1981@gmail.com a6150f3443 Commit Steve's patch for Bug 728 2014-10-02 21:34:01 +00:00
benjamin.drung@gmail.com 277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
martynshaw99 abcffe7593 Remove a couple of unused vars, and hence the warning count. 2013-09-27 00:18:45 +00:00
lllucius 5c4ac939db Allow blanks labels to be retained when leaving the Label Editor. 2013-09-24 05:29:37 +00:00
RichardAsh1981@gmail.com 238bb1594c Patch to avoid dereferences of invalid items by Campbell Barton, tested by Steve the Fiddle 2013-09-18 19:48:44 +00:00
james.k.crook@gmail.com dba81b3f1c Cleanup: Fixed lots of trivial MSVC warnings. 2013-08-25 21:51:26 +00:00
v.audacity 6182f9c33e Fix typo in r11998 2012-10-13 22:55:07 +00:00
v.audacity fd17ae3903 David Bailes patch for bug 577 2012-10-13 00:59:14 +00:00
v.audacity ebb4f530bb Apparently, wxConfigBase::Write() does not update values for next access on all platforms unless Flush() method is called. Added many calls to wxConfigBase::Flush() to make sure the Rad() calls get the right values. 2012-08-02 06:03:19 +00:00
v.audacity cff4cd3c2d Fixes Note 3 at http://bugzilla.audacityteam.org/show_bug.cgi?id=550#c0. 2012-08-01 03:09:11 +00:00
james.k.crook@gmail.com dd97cae3d9 Removed some (hidden) Cleanspeech cruft that had been used to disable effects. Made some static text open to translation. Added more i18n hints (thanks Thomas Breinstrup). 2012-04-05 11:21:15 +00:00
james.k.crook@gmail.com 69476e785c Fixed more internationalisation hints. 2012-03-20 15:36:02 +00:00
v.audacity f1fee888c2 Fix null pointer dereferences caught by Vigilant Sentry. Ask some questions about some code. 2011-11-24 23:12:52 +00:00
v.audacity 36d8d98546 small cleanup 2011-07-15 22:08:50 +00:00
lllucius@gmail.com 7d889359c5 Use currently selected timeformat (in SelectionBar) as default for Label dialog 2011-01-25 04:50:02 +00:00
ra e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00