Commit Graph

3052 Commits

Author SHA1 Message Date
Steve Daulton dad346ec23 Fix build for Debian Stable 2016-02-15 15:54:11 +00:00
Paul Licameli df6a7c5464 More uses of safenew for classes we derive from wxWindow classes...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli 3f237daddc Use macro safenew for many allocations of wxWindow subclasses 2016-02-14 20:20:19 -05:00
Paul Licameli 6052b5f9be Throw by value, catch by reference: don't use pointers...
... that's what the better books on C++ recommend.
2016-02-14 19:36:17 -05:00
Paul Licameli 7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli 56e7653343 "delete"->"DELETE" in comments, easier to find remaining naked operator delete 2016-02-14 18:50:45 -05:00
Paul Licameli 6706b19af8 Define macro safenew and template functions std::make_unique 2016-02-14 13:20:52 -05:00
James Crook 697d668d55 Merge pull request #100 from henricj/manifest
Update the manifest pragma to match the docs.

Using * for processorArchitecture should work on both 32 and 64 bit systems, with Audacity compiled for 32 bit.
2016-02-13 19:17:45 +00:00
Paul Licameli daa7617e88 auto_ptr (deprecated) -> unique_ptr (preferred in C++11) 2016-02-13 12:00:28 -05:00
Paul Licameli 6ec7c619fe Now let's try out a few new language features...
Rvalue refs, move ctor, =delete, range-for, auto, std:vector<>::emplace_back()

There are also performance improvements from eliminating an indirection and
using move of strings instead of copy.
2016-02-13 11:20:14 -05:00
Paul Licameli 575463252e Compile with gcc 4.8 and -std=c++11 2016-02-13 11:02:38 -05:00
Paul Licameli c4657a7b0e Use [] not at() -- avoid array bounds checking in release build! 2016-02-11 12:36:27 -05:00
Paul Licameli 5f76da4f5b Bug1321 (partial): Don't change output balance when closing Preferences unless...
... you really changed Device preferences.
2016-02-11 12:04:12 -05:00
James Crook 3f4a9191ec __WXMAC__ -> __APPLE__ in Theme.cpp #ifdef
This change helps macports and is (apparently) neutral for the platforms we build for.  See:
https://trac.macports.org/ticket/47189#comment:35
2016-02-08 21:47:59 +00:00
Paul Licameli dd3df60a83 Avoid repeated FindBlock call in Sequence::Get when we can 2016-02-04 09:31:39 -05:00
Paul Licameli dc599116f7 Use SampleBuffer in Sequence, reuse so there are fewer allocations of buffers 2016-02-04 09:31:38 -05:00
Paul Licameli ca56876aaf Various minor fixes in Sequence 2016-02-04 01:06:51 -05:00
Paul Licameli e6987284e3 Rewrote Sequence::FindBlock, without recursion, and with dictionary search 2016-02-04 00:53:55 -05:00
Paul Licameli 6c28276daf Use RAII idiom for lock and locking mutex in Sequence 2016-02-04 00:53:54 -05:00
Paul Licameli 13f7d0a81b Added consistency checks for Sequence, hoisted out of inner loops. 2016-02-04 00:53:27 -05:00
Paul Licameli 7be911b7fb Simplify the use of Sequence::Blockify() 2016-02-03 22:17:10 -05:00
Paul Licameli 51fbc697cf One less indirection accessing Sequence::mBlock 2016-02-03 22:17:08 -05:00
Paul Licameli 38ba19183d One less indirection accessing SeqBlock 2016-02-03 22:17:07 -05:00
Paul Licameli d2a7f35f98 One less indirection accessing RowData 2016-02-03 22:14:30 -05:00
Paul Licameli 5de27ac36f One less indirection accessing InvalidRegion 2016-02-02 11:49:54 -05:00
Paul Licameli 507cee7ee5 One less indirection accessing Region 2016-02-02 11:49:53 -05:00
Paul Licameli fbc75907dd One less indirection accessing EnvPoint 2016-02-02 11:49:52 -05:00
Paul Licameli 488ccf143e Fix small memory leak in Ruler.cpp 2016-02-02 11:47:58 -05:00
Paul Licameli a0d78b92cd Fix unreported memory leak in Import Raw 2016-02-01 20:49:35 -05:00
Paul Licameli 8e46ff48d5 Fix unreported memory leak in command-line export...
... Solution was to stack-allocate!

To make the leak happen, export with "external program" and edit the command to
"foobar" or other nonextistent program instead of lame.
2016-02-01 13:14:06 -05:00
Paul Licameli 321d5259a2 More uses of SampleBuffer, eliminating explicit DeleteSamples calls 2016-02-01 10:16:00 -05:00
Paul Licameli 508286661a Bug1104: If one stereo channel is shorter, don't buzz or stop playback short...
... A better fix this time!
2016-01-31 15:42:23 -05:00
Paul Licameli fd2e36b538 Revert "Bug1104: When one stereo channel is shorter, don't stop playback at its end."
This reverts commit 0b5e35003f.
2016-01-31 15:26:44 -05:00
Paul Licameli 0b5e35003f Bug1104: When one stereo channel is shorter, don't stop playback at its end. 2016-01-31 15:19:47 -05:00
Steve Daulton 76403ba5f9 Fix residual issue for bug 1313 2016-01-30 15:45:35 +00:00
Steve Daulton d6b8080a5d Fix for bug 1313 2016-01-29 22:12:41 +00:00
Paul Licameli eaccd490ec Bug1320: Correct contrast window miscalculations of RMS 2016-01-29 14:18:47 -05:00
Paul Licameli 3c2e88a6dc Fix compiler warning 2016-01-29 10:14:52 -05:00
Paul Licameli c9fa5000fc Merge branch 'bug1197' 2016-01-28 10:38:44 -05:00
Paul Licameli f47cb3d528 Bug1197, yet again: extreme zoom-in behavior, now Mac specific: ...
...fix differing results on Mac by calculating only in double, so that selection
remains centered at extreme zoom-in for long projects (about 20 min.) and
selection after about 15 min.
2016-01-28 10:36:48 -05:00
Paul Licameli aa63c19977 Bug1199: Export multiple by labels should not add silence to exported files...
... sorry, modifications to Mix.cpp had mistakes.
2016-01-27 22:51:38 -05:00
Paul Licameli 12a2d066ba Bug1306: Kestroke shortcuts for sub-menu entries now work again...
... for instance, Align sub-menu of Tracks.
2016-01-27 16:10:46 -05:00
Paul Licameli 08c27ad226 Bug1299 again: Better fix, to restore window focus after applying a chain. 2016-01-27 15:01:03 -05:00
Paul Licameli c7eca2c657 Bug1299 again: Better fix, to restore window focus after applying a chain. 2016-01-27 14:58:51 -05:00
Paul Licameli 074d0daf3d Revert "Bug1299: Shouldn't lose track focus after applying a chain."
This reverts commit a44ff801a6.
2016-01-27 14:55:49 -05:00
Steve Daulton 5c2fc5ff7d Fix bug 1317 2016-01-27 13:38:21 +00:00
Paul Licameli 1083c4a049 Bug1169 again: correct shuttling of spectrogram scale values with dialog on Apply 2016-01-26 23:57:32 -05:00
Paul Licameli a44ff801a6 Bug1299: Shouldn't lose track focus after applying a chain. 2016-01-26 20:49:59 -05:00
Paul Licameli 907c950a0e Bug1288: Don't crash when changing language to "Simplified"...
... but give a warning message about the unknown language.
2016-01-26 20:09:54 -05:00
Paul Licameli 2550a59c0e Bug1282: Hide "Stereo to Mono" from menu when disabled by plugin manager...
... so you can't crash by selecting it!
2016-01-26 19:38:04 -05:00