When compiling, I got this error:
/lib-src/libnyquist/nyquist/nyqsrc/sndread.c: In function 'snd_make_read':
/lib-src/libnyquist/nyquist/nyqsrc/sndread.c:169:30: error: invalid operands to binary | (have 'int' and 'long int *')
169 | susp->sf_info.format |= format;
| ^~
I would like to suggest this fix for this error.
* [NYQUIST] Fix build on CYGWIN
Cygwin requires to include unistd.h for building without errors.
* [NYQUIST] Fix build on CYGWIN.
Cygwin requires to include endian.h to build without errors.
... because the two macros have the same expansion, and are both checked for
in the --keyword arguments passed to msgfmt by locale/update_po_files.sh.
This commit makes ONLY such changes, and comments in Internat.h. It is big
but quite harmless.
The intention is to introduce a type distinction in a later release, by defining
XXO differently. XXO is used where & characters in strings (for hotkeys of menu
items or control prompts) are permitted, XO where not.
When compiling with CMake and MinGW, I got these two errors:
audacity/lib-src/mod-script-pipe/PipeServer.cpp:18:29: warning: ISO C++ forbids converting a string constant to 'LPTSTR' {aka 'char*'} [-Wwrite-strings]
18 | LPTSTR pipeNameToSrv= _T("\\\\.\\pipe\\ToSrvPipe");
audacity/lib-src/mod-script-pipe/PipeServer.cpp:32:32: warning: ISO C++ forbids converting a string constant to 'LPTSTR' {aka 'char*'} [-Wwrite-strings]
32 | LPTSTR pipeNameFromSrv= __T("\\\\.\\pipe\\FromSrvPipe");
The solution is to replace LPTSTR and convert these two pointers into two const objects.
Bug 2062 - Export as WAV does not remember the previously used setting
Bug 1355 - "Other uncompressed files" does not (visually) update target
file extension according to the chosen "Header" type
Bug 1356 - "Other uncompressed files" forces the default extension for
the format in the exported file
Bug 1381 - Export other uncompressed formats incorrectly assumes max 255
channels
(and possibly others...not the best bugzilla searcher)
When upgrading portaudio to the r1966 revision back in
March of 2016, the pa_unix_oss.h file was lost. This
is an Audacity specific/provided file.
Doubtful that the OSS interface is used on Linux much,
but it could be used on other Unix-like systems.
It's still has some work, but it successfully builds on
all 3 main platforms. Some of the outstanding items
include:
Install target testing (mostly important for Linux)
CMakeList clean up and comments
Debug and Release build verification
Audit of compile/link options
Need a Mac signed and notarized build
(and probably more)
These are ancient and "configunix.h" was being pulled in
via Types.h. Nothing major, but they were generated for
a 32-bit system and "may" cause problems when used on
64-bit systems.
(That's unlikely though since they haven't all this time.)
... Problem with static initialization order of ReservedCommandFlags, caused
wrong enablement of menu items (at least on Mac), such as Plot Spectrum or
Contrast enabled when there was no selection
Leland Lucius
Paul Licameli
Carlo Bramini
SteveDaulton
Raphael Graf