audacia/src/ondemand
james.k.crook@gmail.com 8a9987a0d9 From: martin@steghoefer.eu [PATCHES 02-15 of 15] Fix runtime problem with wxWidgets 3.0:
Correct string formatting for:
2/15  %d + enum => %d + int
3/15  %lld + int64_t => %lld + long long
4/15  %d + int64_t => %lld + long long
5/15  %d + double => %f + double
6/15  %d + int32_t => %d + int
7/15  %d + intptr_t => %p + void*
8/15  gint, guint
9/15  %d + long => %ld + long
10/15 %n + int => %d + int
11/15 %x + int => %x + unsigned int
12/15 %f + int => %d + int
13/15 %S + wxChar* => %s + wxChar*
14/15 %d + size_t => %d + int
15/15 %d + size_t => %lld + long long

"The functions wxString::Format, wxString::Printf (and others indirectly) have become stricter about parameter types that don't match (format specifier vs. function parameters). So the bugs (that were already present in audacity before) become visible in wx3.0 as error message dialogs. I've checked all occurrences of Printf, wxPrintf, PrintfV, Format, FormatV, wxLogDebug and wxLogError systematically and made the type match."

Note (9/15): In TrackPanel.cpp, ExportMP2.cpp and CompareAudioCommand.cpp this patch supersedes related change done in r13466 because the new solution requires fewer casts and therefore simplifies the code.

Note: Many .po files are affected, and we need to be very careful about this.  Incorrect "%d" and similar in translation files may lead to crashes in those languages (only).  This is something we should actually have been more careful about in the past.  We need to write a script to check that the "%d" and similar format specifiers match between English and translation.
2014-11-08 16:42:34 +00:00
..
ODComputeSummaryTask.cpp Commit a warnings removal patch from Benjamin Drung to correct a string of minor misdemeanors. 2011-02-07 20:24:04 +00:00
ODComputeSummaryTask.h Remove trailing spaces. 2014-06-03 20:30:19 +00:00
ODDecodeFFmpegTask.cpp Replace tabs by spaces. 2014-06-05 22:04:22 +00:00
ODDecodeFFmpegTask.h Remove trailing spaces. 2014-06-03 20:30:19 +00:00
ODDecodeFlacTask.cpp Remove trailing spaces. 2014-06-03 20:30:19 +00:00
ODDecodeFlacTask.h Remove trailing spaces. 2014-06-03 20:30:19 +00:00
ODDecodeTask.cpp Remove trailing spaces. 2014-06-03 20:30:19 +00:00
ODDecodeTask.h Remove trailing spaces. 2014-06-03 20:30:19 +00:00
ODManager.cpp Preliminary changes for wxWidgets 3.0.1 2014-10-06 08:10:50 +00:00
ODManager.h fix possible deadlock for OD. 2010-07-22 15:28:54 +00:00
ODTask.cpp Preliminary changes for wxWidgets 3.0.1 2014-10-06 08:10:50 +00:00
ODTask.h Remove trailing spaces. 2014-06-03 20:30:19 +00:00
ODTaskThread.cpp Remove trailing spaces. 2014-06-03 20:30:19 +00:00
ODTaskThread.h Remove trailing spaces. 2014-06-03 20:30:19 +00:00
ODWaveTrackTaskQueue.cpp From: martin@steghoefer.eu [PATCHES 02-15 of 15] Fix runtime problem with wxWidgets 3.0: 2014-11-08 16:42:34 +00:00
ODWaveTrackTaskQueue.h Remove trailing spaces. 2014-06-03 20:30:19 +00:00