From 314b10e3432cca5c4a888d1b89497941107414d4 Mon Sep 17 00:00:00 2001 From: Dionisio E Alonso Date: Sun, 7 Aug 2022 23:24:17 -0300 Subject: [PATCH 1/3] fix: Migrate config to the new option definition --- nvim/lsp_client_settings.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nvim/lsp_client_settings.vim b/nvim/lsp_client_settings.vim index ca03975..76109bd 100644 --- a/nvim/lsp_client_settings.vim +++ b/nvim/lsp_client_settings.vim @@ -46,7 +46,7 @@ lua << EOF local nvim_lsp = require("lspconfig") local on_attach = function(client, bufnr) - vim.api.nvim_command("autocmd CursorHoldI lua vim.diagnostic.open_float({show_header = false})") + vim.api.nvim_command("autocmd CursorHoldI lua vim.diagnostic.open_float({header = ''})") vim.lsp.handlers["textDocument/publishDiagnostics"] = vim.lsp.with( vim.lsp.diagnostic.on_publish_diagnostics, { update_in_insert = true, From 099f247c2e9b9d08f798b4313428febba31fcff6 Mon Sep 17 00:00:00 2001 From: Dionisio E Alonso Date: Sun, 7 Aug 2022 23:28:24 -0300 Subject: [PATCH 2/3] fix: Add diagnostic open_float focus option Made the floating window not focusable to avoid mistakes. --- nvim/lsp_client_settings.vim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nvim/lsp_client_settings.vim b/nvim/lsp_client_settings.vim index 76109bd..82fcf9e 100644 --- a/nvim/lsp_client_settings.vim +++ b/nvim/lsp_client_settings.vim @@ -46,11 +46,11 @@ lua << EOF local nvim_lsp = require("lspconfig") local on_attach = function(client, bufnr) - vim.api.nvim_command("autocmd CursorHoldI lua vim.diagnostic.open_float({header = ''})") + vim.api.nvim_command("autocmd CursorHoldI lua vim.diagnostic.open_float({focusable = false, header = ''})") vim.lsp.handlers["textDocument/publishDiagnostics"] = vim.lsp.with( vim.lsp.diagnostic.on_publish_diagnostics, { update_in_insert = true, - virtual_text = false + virtual_text = { spacing = 24 } } ) From 82697ea146e4b873460a5a87eb9fd4da57c9c17d Mon Sep 17 00:00:00 2001 From: Dionisio E Alonso Date: Sun, 7 Aug 2022 23:36:34 -0300 Subject: [PATCH 3/3] feat: Migrate autocmd in on_attach to pure Lua call Migrated, following TeeJ_Dv's advice, the auto-command creation to a Lua function. As this auto-command only cares for the on_attach Lua scope, it seems correct to have this one defined as a Lua function instead of the legacy Vimscript. --- nvim/lsp_client_settings.vim | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/nvim/lsp_client_settings.vim b/nvim/lsp_client_settings.vim index 82fcf9e..5aeebe0 100644 --- a/nvim/lsp_client_settings.vim +++ b/nvim/lsp_client_settings.vim @@ -46,7 +46,13 @@ lua << EOF local nvim_lsp = require("lspconfig") local on_attach = function(client, bufnr) - vim.api.nvim_command("autocmd CursorHoldI lua vim.diagnostic.open_float({focusable = false, header = ''})") + vim.api.nvim_create_autocmd("CursorHoldI", { + buffer = bufnr, + callback = function() + vim.diagnostic.open_float({ focusable = false, header = "" }) + end + }) + vim.lsp.handlers["textDocument/publishDiagnostics"] = vim.lsp.with( vim.lsp.diagnostic.on_publish_diagnostics, { update_in_insert = true,