cmccabe
/
linkulator2
4
10
Fork 4
Code Issues 21 Pull Requests 3 Releases Wiki Activity

Show new activity on all screens #101

Merged
cmccabe merged 5 commits from show_unread_replies into master 2021-07-27 14:40:07 +00:00
Conversation 2 Commits 5 Files Changed 4 +157 -38
asdf commented 2021-07-22 06:57:00 +00:00
Collaborator
Copy Link
  • New replies now indicated on category screen (fixed #98)
  • New replies now also indicated on category details screen
  • Fixed bug in get_parent_record function that prevented the function from working at all
  • Some new tests, but not all new functionality tested

I haven't done python in a while so this might not be the best, and may have issues. WIP for a little while as it needs further testing.

@cmccabe if you get a chance, would you mind trying this branch yourself?

- New replies now indicated on category screen (fixed #98) - New replies now also indicated on category details screen - Fixed bug in get_parent_record function that prevented the function from working at all - Some new tests, but not all new functionality tested I haven't done python in a while so this might not be the best, and may have issues. WIP for a little while as it needs further testing. @cmccabe if you get a chance, would you mind trying this branch yourself?
asdf added the
enhancement
 label 2021-07-22 06:57:00 +00:00
asdf self-assigned this 2021-07-22 06:57:00 +00:00
cmccabe was assigned by asdf 2021-07-22 06:57:00 +00:00
asdf added 4 commits 2021-07-22 06:57:00 +00:00
asdf force-pushed show_unread_replies from 589e52a466 to e500167d27 2021-07-25 02:05:09 +00:00 Compare
asdf added 1 commit 2021-07-25 03:21:06 +00:00
cmccabe commented 2021-07-26 21:53:18 +00:00
Owner
Copy Link

I tested a bit and it seems great. I'll pull it into the prod version on RTC and we can let everybody test it out.

I tested a bit and it seems great. I'll pull it into the prod version on RTC and we can let everybody test it out.
asdf changed title from WIP: show new activity on all screens to Show new activity on all screens 2021-07-27 01:44:28 +00:00
asdf commented 2021-07-27 01:45:33 +00:00
Author
Collaborator
Copy Link

OK sounds cool, I haven't seen any issues with my testing yet and don't think there are any further changes at this point. Let's see how it goes and we can merge this in if no issues.

OK sounds cool, I haven't seen any issues with my testing yet and don't think there are any further changes at this point. Let's see how it goes and we can merge this in if no issues.
cmccabe merged commit ecbf2b66d2 into master 2021-07-27 14:40:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
compatibility

Deals with compatibility issues

  
documentation

Deals with documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
future release

Lower priority, for a future release.

  
help wanted

Need some help

  
invalid

Something is wrong

  
non-code

For things that are not code themselves but do not fall into other categories cleanly

  
question

More information is needed

  
refactor

Deals with cleaning up or refactoring code

  
testing

Creates tests or investigates failures of tests

  
this release

To be done before this release is finished.

  
wontfix

This won't be fixed

No Label
bug
compatibility
documentation
duplicate
enhancement
future release
help wanted
invalid
non-code
question
refactor
testing
this release
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
asdf
cmccabe
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cmccabe/linkulator2#101
No description provided.
Delete Branch "show_unread_replies"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?