ignore category file #78

New Issue

cmccabe · 2020-01-16T03:54:58Z

cmccabe commented

2020-01-16 03:54:58 +00:00

Like the 'ignore' file, but allows a user to ignore categories of links.

cmccabe added the

enhancement

label 2020-01-16 03:54:58 +00:00

sloum commented

2020-01-16 17:35:37 +00:00

Interesting. That sounds in interesting idea. Would adding categories to this file be manual or something done through the tui?

cmccabe commented

2020-01-16 18:12:02 +00:00

Could be either. The simplest way would be just like the 'ignore' file. Just create a 'ignore-cat' (?) file and add names of categories you want to ignore, one category per line. If we were to add a TUI method for managing it, we could use the same approach for the user-ignore file too.

sloum commented

2020-01-16 18:37:06 +00:00

The benefit for using the tui to handle the categories vs users is that from the main category menu if ignore is an option then they can just enter the category number and not have to spell it out. It is only a small benefit, so if it added a lot of cruft tot he code may not be worth it. but it is a small convenience I think would be nice. I'm not sure that there is any equivalent benefit to doing so with users, as there is no page where users are numbered. So with categories that menu option should only appear on the category selection view. Whereas for users it might need to be in every menu, which starts to clutter things a tad. I could go either way on it though.

cmccabe commented

2020-01-16 21:08:30 +00:00

Agreed. A TUI for categories only makes sense.

What about un-ignoring categories? Would that still be manually editing the file? A TUI for adding and removing would be a lot more code.

Agreed. A TUI for categories only makes sense. What about un-ignoring categories? Would that still be manually editing the file? A TUI for adding and removing would be a lot more code.

asdf commented

2020-01-16 23:02:54 +00:00

Another option would be to store entries in the user configuration file.

It might be easiest to build the ignore functionality first before building any user interface.

Another option would be to store entries in the user configuration file. It might be easiest to build the ignore functionality first before building any user interface.

sloum commented

2020-01-17 00:28:17 +00:00

I agree with @asdf . Building the functionality first is the good call. Figuring out how people interact with it can come after. I really like configuration files (I know some people loathe them), so long as it is well commented for where and how to add things I think that sounds like a good idea that would meet user expectations.

cmccabe commented

2020-01-17 03:03:53 +00:00

The only concern I have about putting ignore in the config file just arose as I got a question about installation -- specifically a single central installation verses multiple installations by each user on a system. In the central install, the config file would not be writable by users, whereas the ignore file would still be in each user's ~/.linkulator/ directory.

So if we do go with a config file, we probably need to have two config files: one that stays next to the main linkulator.sh script and one that stays in each user's linkulator data directory. I.e. a main config file and a user config file.

The only concern I have about putting ignore in the config file just arose as I got a question about installation -- specifically a single central installation verses multiple installations by each user on a system. In the central install, the config file would not be writable by users, whereas the ignore file would still be in each user's ~/.linkulator/ directory. So if we do go with a config file, we probably need to have two config files: one that stays next to the main linkulator.sh script and one that stays in each user's linkulator data directory. I.e. a main config file and a user config file.

asdf commented

2020-01-18 03:25:35 +00:00

I think we might have that type of functionality already.

config.py is part of the application, and has some defaults stored in it, but they are intended as system-wide options.

linkulatorrc is a user specific configuration file, stored in the user's home directory. It's not tied to where linkulator is installed to. The current ignore file is a similar configuration file.

So to clarify my suggestion, a list of categories to ignore could be stored in linkulatorrc

Let me know if I've not understood this properly.

I think we might have that type of functionality already. config.py is part of the application, and has some defaults stored in it, but they are intended as system-wide options. linkulatorrc is a user specific configuration file, stored in the user's home directory. It's not tied to where linkulator is installed to. The current ignore file is a similar configuration file. So to clarify my suggestion, a list of categories to ignore could be stored in linkulatorrc Let me know if I've not understood this properly.

cmccabe commented

2020-01-19 02:05:07 +00:00

That makes sense to me and sounds good!

Sign in to join this conversation.