Refactor link/reply data structure #8

New Issue

cmccabe · 2019-11-21T13:20:32Z

cmccabe commented

2019-11-21 13:20:32 +00:00

Initial data model is not integrated and easy to use. Refactor into a more standard model.

cmccabe added the

future release

label 2019-11-21 13:20:32 +00:00

cmccabe referenced this issue

2019-11-25 02:50:58 +00:00

Adds visual/interactive changes to all menus #23

asdf commented

2019-12-05 02:31:51 +00:00

The structure suggested by Sloum was:

links = {
    "category1": [
        {
            "title": "Tildegit",
            "link": "https://tildegit.org",
            "user": "sloum",
            "time": 1574641578,
            "replies": [
                {"user": "asdf", "time": 1574328572, "reply": "Me too!"},
                {"user": "cmccabe", "time": 1575528561, "reply": "Me three!"}
            ]
        }
    ],
    "other category": [
        {
            "title": "Stuff",
            "link": "https://blah.com",
            "user": "someuser",
            "time": 1574641578,
            "replies": []
        }
    ]
}

I like this approach. Using a class or named tuples for the links might be lighter syntactically, with different pros and cons.

The structure suggested by Sloum was: ```python links = { "category1": [ { "title": "Tildegit", "link": "https://tildegit.org", "user": "sloum", "time": 1574641578, "replies": [ {"user": "asdf", "time": 1574328572, "reply": "Me too!"}, {"user": "cmccabe", "time": 1575528561, "reply": "Me three!"} ] } ], "other category": [ { "title": "Stuff", "link": "https://blah.com", "user": "someuser", "time": 1574641578, "replies": [] } ] } ``` I like this approach. Using a class or named tuples for the links might be lighter syntactically, with different pros and cons.

cmccabe commented

2019-12-05 02:41:33 +00:00

I think this data structure looks pretty good. Just to make sure I have it correct, would the following be the way a second link would be represented within the "category1" category?

links = {
    "category1": [
        {
            "title": "Tildegit",
            "link": "https://tildegit.org",
            "user": "sloum",
            "time": 1574641578,
            "replies": [
                {"user": "asdf", "time": 1574328572, "reply": "Me too!"},
                {"user": "cmccabe", "time": 1575528561, "reply": "Me three!"}
            ]
        },
        {
            "title": "Github",
            "link": "https://github.com",
            "user": "sloum",
            "time": 1574641578,
            "replies": [
                {"user": "asdf", "time": 1574328572, "reply": "Never heard of it!"},
                {"user": "cmccabe", "time": 1575528561, "reply": "Me either!"}
            ]
        }
    ],
    "other category": [
        {
            "title": "Stuff",
            "link": "https://blah.com",
            "user": "someuser",
            "time": 1574641578,
            "replies": []
        }
    ]
}

I think this data structure looks pretty good. Just to make sure I have it correct, would the following be the way a second link would be represented within the "category1" category? ```python links = { "category1": [ { "title": "Tildegit", "link": "https://tildegit.org", "user": "sloum", "time": 1574641578, "replies": [ {"user": "asdf", "time": 1574328572, "reply": "Me too!"}, {"user": "cmccabe", "time": 1575528561, "reply": "Me three!"} ] }, { "title": "Github", "link": "https://github.com", "user": "sloum", "time": 1574641578, "replies": [ {"user": "asdf", "time": 1574328572, "reply": "Never heard of it!"}, {"user": "cmccabe", "time": 1575528561, "reply": "Me either!"} ] } ], "other category": [ { "title": "Stuff", "link": "https://blah.com", "user": "someuser", "time": 1574641578, "replies": [] } ] } ```

Sign in to join this conversation.