Add readline functionality, modified input calls and updated styles #90

asdf · 2020-05-14T04:04:22Z

asdf commented

2020-05-14 04:04:22 +00:00

Fixes #64

Added readline library to allow better line editing when prompted for input
Moved newlines from input prompts in the controller components to the view components. Also fixes some issues with readline noted in #64
Updated styles to ensure the escape sequences are compatible with readline (as per this issue)

A view test was amended to support this change, however no new tests were created (although this would be a good idea at some stage).

Please review as readline has previously had issues (see #50).

Fixes #64 - Added readline library to allow better line editing when prompted for input - Moved newlines from input prompts in the controller components to the view components. Also fixes some issues with readline noted in #64 - Updated styles to ensure the escape sequences are compatible with readline (as per [this issue](https://bugs.python.org/issue20359)) A view test was amended to support this change, however no new tests were created (although this would be a good idea at some stage). Please review as readline has previously had issues (see #50).

sloum approved these changes 2020-05-14 06:06:05 +00:00

sloum left a comment

This looks good to me! Finding that readline fix has been relly helpful for my python projects (where I often use readline in conjunction with escape sequences and things have always been screwy).

cmccabe referenced this issue from a commit

2020-05-20 10:25:20 +00:00

Merge pull request 'Add readline functionality, modified input calls and updated styles' (#90) from readline_again into master

cmccabe closed this pull request

2020-05-20 10:25:22 +00:00

asdf deleted branch readline_again

2020-05-21 23:45:11 +00:00

Sign in to join this conversation.

No reviewers