Adds a fix to the readline issues we've been seeing #96

sloum · 2020-07-10T21:52:20Z

sloum commented

2020-07-10 21:52:20 +00:00

Readline recognizes \001 and \002 to designate beginning and ending of text that should be ignored by readline when calculating line length. We had been putting it around any text that had escape codes. This update adds a bool to the style_text() function to signify if the text will be part of an input or not. If not, we do not add the readline bytes (they technically arent escape codes they are just low bytes that it recognizes).

I tried it, but ahd not been experiencing the original issue. If you, @cmccabe , want to give it a try and post the results here that would be awesome.

Readline recognizes `\001` and `\002` to designate beginning and ending of text that should be ignored by readline when calculating line length. We had been putting it around any text that had escape codes. This update adds a bool to the `style_text()` function to signify if the text will be part of an input or not. If not, we do not add the readline bytes (they technically arent escape codes they are just low bytes that it recognizes). I tried it, but ahd not been experiencing the original issue. If you, @cmccabe , want to give it a try and post the results here that would be awesome.

sloum added the

bug

label 2020-07-10 21:52:20 +00:00

sloum self-assigned this 2020-07-10 21:52:20 +00:00

asdf was assigned by sloum

2020-07-10 21:52:20 +00:00

cmccabe was assigned by sloum

2020-07-10 21:52:20 +00:00

cmccabe referenced this issue from a commit

2020-07-11 21:01:20 +00:00

Merge pull request 'Adds a fix to the readline issues we've been seeing' (#96) from readline-escape-fix into master Reviewed-on: https://tildegit.org/cmccabe/linkulator2/pulls/96

cmccabe merged commit e408c3e1aa into master