exquisitecorp
/
bookmobile
2
1
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

reference error: property name is not defined #3

New Issue
Closed
opened 2022-08-06 09:10:19 +00:00 by satvika · 14 comments
satvika commented 2022-08-06 09:10:19 +00:00
Copy Link

epubmobile is giving following error :

Retrieving...
Processing...
file:///home/zenova/asdf/installs/nodejs/17.8.0/.npm/lib/node_modules/readability-cli/common.mjs:478
                        for (propertyName of wantedProperties)
                             ^

ReferenceError: propertyName is not defined
    at default (file:///home/zenova/asdf/installs/nodejs/17.8.0/.npm/lib/node_modules/readability-cli/common.mjs:478:9)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Node.js v17.8.0
Retrieving...
Processing...
Epub saved to  /home/murali/Downloads/
epubmobile is giving following error : ``` Retrieving... Processing... file:///home/zenova/asdf/installs/nodejs/17.8.0/.npm/lib/node_modules/readability-cli/common.mjs:478 for (propertyName of wantedProperties) ^ ReferenceError: propertyName is not defined at default (file:///home/zenova/asdf/installs/nodejs/17.8.0/.npm/lib/node_modules/readability-cli/common.mjs:478:9) at processTicksAndRejections (node:internal/process/task_queues:96:5) Node.js v17.8.0 Retrieving... Processing... Epub saved to /home/murali/Downloads/ ```
exquisitecorp commented 2022-08-08 10:51:18 +00:00
Owner
Copy Link

Hi, can you link me to the article you tried to download?

Hi, can you link me to the article you tried to download?
satvika commented 2022-08-08 13:23:51 +00:00
Author
Copy Link

epubmobile https://www.makeuseof.com/how-to-password-protect-files-folders-on-linux/

epubmobile https://www.makeuseof.com/how-to-password-protect-files-folders-on-linux/
exquisitecorp commented 2022-08-08 13:35:49 +00:00
Owner
Copy Link

Hmmm, I just tested and it worked okay for me! Are you able to download other articles with epubmobile?

Does the regular bookmobile program work for you?

Hmmm, I just tested and it worked okay for me! Are you able to download other articles with epubmobile? Does the regular bookmobile program work for you?
satvika commented 2022-08-08 14:08:45 +00:00
Author
Copy Link

i am able to get output as html or epub.

but it is showing error as mentioned above.

using bookmobile is also giving the same error.

i am able to get output as html or epub. but it is showing error as mentioned above. using bookmobile is also giving the same error.
exquisitecorp commented 2022-08-08 14:56:18 +00:00
Owner
Copy Link

ok, so it sounds like it's able to grab the article but it's not able to get/set the title correctly. if that's not correct, please let me know.

Can you try running this and letting me know what output you see?

readable 'https://www.makeuseof.com/how-to-password-protect-files-folders-on-linux/' --properties "title"
ok, so it sounds like it's able to grab the article but it's not able to get/set the title correctly. if that's not correct, please let me know. Can you try running this and letting me know what output you see? ``` readable 'https://www.makeuseof.com/how-to-password-protect-files-folders-on-linux/' --properties "title" ```
satvika commented 2022-08-08 15:35:15 +00:00
Author
Copy Link

got the following output with the given command :

$ readable 'https://www.makeuseof.com/how-to-password-protect-files-folders-on-linux/' --properties "title"

Retrieving...
Processing...
file:///home/zenova/asdf/installs/nodejs/17.8.0/.npm/lib/node_modules/readability-cli/common.mjs:478
                        for (propertyName of wantedProperties)
                             ^

ReferenceError: propertyName is not defined
    at default (file:///home/zenova/asdf/installs/nodejs/17.8.0/.npm/lib/node_modules/readability-cli/common.mjs:478:9)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Node.js v17.8.0
got the following output with the given command : ``` $ readable 'https://www.makeuseof.com/how-to-password-protect-files-folders-on-linux/' --properties "title" Retrieving... Processing... file:///home/zenova/asdf/installs/nodejs/17.8.0/.npm/lib/node_modules/readability-cli/common.mjs:478 for (propertyName of wantedProperties) ^ ReferenceError: propertyName is not defined at default (file:///home/zenova/asdf/installs/nodejs/17.8.0/.npm/lib/node_modules/readability-cli/common.mjs:478:9) at processTicksAndRejections (node:internal/process/task_queues:96:5) Node.js v17.8.0 ```
exquisitecorp commented 2022-08-09 14:54:46 +00:00
Owner
Copy Link

I can't seem to reproduce the problem on my machine.
Can you tell me what version of readability you have?

readable --version
I can't seem to reproduce the problem on my machine. Can you tell me what version of readability you have? ``` readable --version ```
satvika commented 2022-08-09 16:38:42 +00:00
Author
Copy Link
$ readable --version
readability-cli v2.4.0
Node.js v17.8.0
``` $ readable --version readability-cli v2.4.0 Node.js v17.8.0 ```
exquisitecorp commented 2022-08-10 11:00:15 +00:00
Owner
Copy Link

Thanks, I'm able to reproduce this now. It seems like an error introduced in the update from readability-cli from 2.3.0 to 2.4.0. I'll look into this.

Thanks, I'm able to reproduce this now. It seems like an error introduced in the update from readability-cli from 2.3.0 to 2.4.0. I'll look into this.
exquisitecorp commented 2022-08-10 11:27:44 +00:00
Owner
Copy Link

Looks like an issue in parent library. I'll file an issue there while looking further into it.

I see a backup library with python3-readability that I tested and was able to get to work but I'd prefer not to introduce a new language dependency. Will see what I can do. If you know how to roll back to version 2.3.0 of readability in the meantime, that can work while I look further into this. otherwise, hang tight? :)

Looks like an issue in parent library. I'll file an issue there while looking further into it. I see a backup library with python3-readability that I tested and was able to get to work but I'd prefer not to introduce a new language dependency. Will see what I can do. If you know how to roll back to version 2.3.0 of readability in the meantime, that can work while I look further into this. otherwise, hang tight? :)
exquisitecorp commented 2022-08-18 17:24:51 +00:00
Owner
Copy Link

@satvika patched! Thanks to upstream readability-cli who helped fix this.

satikva, you can update readability-cli like this:

npm install -g readability-cli@2.4.1
@satvika patched! Thanks to upstream readability-cli who helped fix this. satikva, you can update readability-cli like this: ``` npm install -g readability-cli@2.4.1 ```
exquisitecorp commented 2022-08-18 17:25:27 +00:00
Owner
Copy Link

I will close this, but please post or re-open if still causes you problems.

I will close this, but please post or re-open if still causes you problems.
satvika commented 2022-08-20 16:02:02 +00:00
Author
Copy Link

thanks

no errors after upgrading readability to readability-cli@2.4.1

thanks no errors after upgrading readability to readability-cli@2.4.1
exquisitecorp commented 2022-08-22 15:10:09 +00:00
Owner
Copy Link

Great to hear!

Great to hear!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
pulldown
Labels
Clear labels   
enhancement
No Label
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: exquisitecorp/bookmobile#3
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?