khuxkm
/
cosmicbot
2
2
Fork 4
Code Issues Pull Requests Releases Wiki Activity

Added plant name in output message #7

Merged
khuxkm merged 4 commits from aphelion/cosmicbot:master into master 2021-06-23 16:53:48 +00:00
Conversation 4 Commits 4 Files Changed 1 +9 -8
aphelion commented 2021-06-18 01:20:49 +00:00
Contributor
Copy Link
No description provided.
aphelion added 1 commit 2021-06-18 01:20:50 +00:00
aphelion started working 2021-06-18 01:24:26 +00:00
aphelion canceled time tracking 2021-06-18 01:24:35 +00:00
aphelion added 1 commit 2021-06-18 01:43:11 +00:00
khuxkm commented 2021-06-21 20:11:10 +00:00
Owner
Copy Link

I feel like (ab)using a global variable is the wrong way to go about this. Maybe something using a return value and the walrus (:=) operator?

I feel like (ab)using a global variable is the wrong way to go about this. Maybe something using a return value and the walrus (`:=`) operator?
aphelion commented 2021-06-21 23:33:25 +00:00
Author
Contributor
Copy Link

I can remove the global and return two values from the function in the form of a list or tuple.

I can remove the global and return two values from the function in the form of a list or tuple.
khuxkm commented 2021-06-22 16:34:31 +00:00
Owner
Copy Link

I feel like even that could be avoided with the use of some ingenuity.

>>> bool("nonempty string")
True
I feel like even that could be avoided with the use of some ingenuity. ```python >>> bool("nonempty string") True ```
👍 1
aphelion added 1 commit 2021-06-23 14:55:17 +00:00
aphelion added 1 commit 2021-06-23 15:04:09 +00:00
aphelion commented 2021-06-23 15:10:50 +00:00
Author
Contributor
Copy Link

Updated the code as per your suggestions. Removed the global variable and implemented the walrus operator := for ease.

Updated the code as per your suggestions. Removed the global variable and implemented the walrus operator `:=` for ease.
khuxkm merged commit 1cf36069c7 into master 2021-06-23 16:53:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: khuxkm/cosmicbot#7
No description provided.
Delete Branch "aphelion/cosmicbot:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?