From 4198415dbfecee63a5322eb7c58f5cc5cb196b95 Mon Sep 17 00:00:00 2001 From: mbuhl Date: Mon, 7 Nov 2022 22:48:35 +0000 Subject: [PATCH] Fix a memory leak in the error path of rde_dump_ctx_new. ctx is leaked in case of an allocation in prefix_dump_new, prefix_dump_subtree, rib_dump_new, or rib_dump_subtree fails. Found by CodeChecker. OK claudio@ --- usr.sbin/bgpd/rde.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usr.sbin/bgpd/rde.c b/usr.sbin/bgpd/rde.c index 95070004bb1..1d9730b9111 100644 --- a/usr.sbin/bgpd/rde.c +++ b/usr.sbin/bgpd/rde.c @@ -1,4 +1,4 @@ -/* $OpenBSD: rde.c,v 1.578 2022/09/23 15:49:20 claudio Exp $ */ +/* $OpenBSD: rde.c,v 1.579 2022/11/07 22:48:35 mbuhl Exp $ */ /* * Copyright (c) 2003, 2004 Henning Brauer @@ -2739,6 +2739,7 @@ rde_dump_ctx_new(struct ctl_show_rib_request *req, pid_t pid, error = CTL_RES_NOMEM; imsg_compose(ibuf_se_ctl, IMSG_CTL_RESULT, 0, pid, -1, &error, sizeof(error)); + free(ctx); return; }