41ce3b17e7
man pages: add missing commas between subordinate and main clauses
...
jmc@ dislikes a comma before "then" in a conditional, so leave those
untouched.
ok jmc@
2022-03-31 17:27:13 +00:00
08f6ba1906
Don't declare variables as "unsigned char *" that are passed to
...
functions that take "char *" arguments. Where such chars are
assigned to int or passed to ctype functions, explicitly cast them
to unsigned char.
For OpenBSD's clang, -Wpointer-sign has been disabled by default,
but when the parse.y code was built elsewhere, the compiler would
complain.
With help from millert@
ok benno@ deraadt@
2021-10-15 15:01:27 +00:00
7fec5ffcad
Document new reload behaviour. From Ashton Fagg
...
OK jmc@
2021-05-05 12:34:12 +00:00
2f8c4829bf
When loading a config poll iscsid for up to 10 seconds and check if the
...
sessions all managed to connect to the targets.
With this slow session establishment should not cause mount errors
during startup.
Initial version from Dr Ashton Fagg ashton (at) fagg id au
OK dlg@ deraadt@
2021-04-16 14:39:33 +00:00
48c01a1f20
ce examples of "Ar arg Ar arg" with "Ar arg arg" and stop the spread;
2020-04-23 21:28:08 +00:00
915c3f33d3
(unsigned) means (unsigned int) which on ptrdiff_t or size_t or other
...
larger types really is a range reduction...
Almost any cast to (unsigned) is a bug.
ok millert tb benno
2019-02-13 22:57:07 +00:00
a153335958
- odd condition/test in PF lexer
...
(and other lexers too)
This commit rectifies earlier change:
in the lex... even inside quotes, a \ followed by space or tab should
expand to space or tab, and a \ followed by newline should be ignored
(as a line continuation). compatible with the needs of hoststated
(which has the most strict quoted string requirements), and ifstated
(where one commonly does line continuations in strings).
OK deraadt@, OK millert@
2018-11-01 00:18:44 +00:00
b75abfe50e
struct sockaddr_storage is guaranteed to be large enough, no need to check
...
the size.
OK kn, deraadt
2018-10-15 11:30:01 +00:00
ed1b9eb881
replace malloc()+strlcpy() with strndup() in cmdline_symset().
...
"looks good" gilles@ halex@
2018-09-07 07:35:30 +00:00
a062aa9d6a
Do for most running out of memory err() what was done for most running
...
out of memory log_warn(). i.e. ("%s", __func__) instead of manual
function names and redundant verbiage about which wrapper detected the
out of memory condition.
ok henning@
2018-07-11 07:39:22 +00:00
6a3d55f939
No need to mention which memory allocation entry point failed (malloc,
...
calloc or strdup), we just need to log that we ran out of memory in a
particular function.
Recommended by florian@ and deraadt@
ok benno@ henning@ tb@
2018-07-09 12:05:10 +00:00
3c12ada049
Be consistent in warn() and log_warn() usage when
...
running out of memory.
Next step, be correct *and* consistent.
ok dennis@ tb@ benno@ schwarze@
2018-07-08 17:15:07 +00:00
1caaaac72f
remove the SECTIONS header, since a one line DESCRIPTION is a bit silly;
...
use a more general text for the sections, and avoid the catchup issue
that was trying to document how many there were;
ok benno rob
2018-06-18 06:04:25 +00:00
8ab2018ae2
Fix an off-by-one line count when using include statements.
...
Thanks to otto@ for the initial diff.
OK benno@
2018-06-11 09:39:58 +00:00
16a0a9064f
Plug leak in error case of the common 'varset' implementations.
...
ok benno@
2018-04-26 14:12:19 +00:00
46bca67b3a
Replace hand-rolled for(;;) emptying of 'symhead' TAILQ with more
...
modern TAILQ_FOREACH_SAFE().
No intentional functional change.
ok millert@ bluhm@ gilles@
2017-01-05 13:53:09 +00:00
54c95b7a05
Replace symset()'s hand-rolled for(;;) traversal of 'symhead' TAILQ
...
with more modern TAILQ_FOREACH(). This what symget() was already
doing.
Add paranoia '{}' around body of symget()'s TAILQ_FOREACH().
No intentional functional change.
ok bluhm@ otto@
2017-01-05 12:42:18 +00:00
f75ac03558
stop including sys/param.h for nitems. define locally as needed.
...
ok natano reyk
2016-08-16 18:41:57 +00:00
0c7b4ca6ee
do not allow whitespace in macro names, i.e. "this is" = "a variable".
...
change this in all config parsers in our tree that support macros.
problem reported by sven falempin.
feedback from henning@, stsp@, deraadt@
ok florian@ mikeb@
2016-06-21 21:35:24 +00:00
ed720fabf5
claudio twice told me pledge "stdio rpath dns" is probably enough.
...
He'll test it next time he builds...
2015-11-11 02:55:12 +00:00
b9170857bc
use file system path (.Pa) semantic markup macros where appropriate.
...
ok jmc@
2015-07-27 17:28:38 +00:00
b9fc9a728f
Replace <sys/param.h> with <limits.h> and other less dirty headers where
...
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)
2015-01-16 06:39:28 +00:00
41eef22fad
Don't allow embedded nul characters in strings.
...
Fixes a pfctl crash with an anchor name containing
an embedded nul found with the afl fuzzer.
pfctl parse.y patch from and ok deraadt@
2014-11-20 05:51:20 +00:00
7fe19e9c57
Add gcc format attributes to more warn/error functions in parse.y files.
...
Fix a few missing or incorrect format characters.
ok claudio@
2014-11-03 03:42:11 +00:00
2fe39d326d
Print bytes read and written in human readable form, like:
...
2849359 I2T calls (5 read, 2849352 writes)
5 data reads (2.3K bytes read)
2849352 data writes (43.5G bytes written)
2849358 T2I calls (2849358 done, 0 sense errors, 0 errors)
2014-04-21 20:20:37 +00:00
75b0049144
Document show summary
2014-04-21 18:05:45 +00:00
0ffafa029a
Print the target and initiator name in show command.
2014-04-21 18:01:08 +00:00
d9ff547311
Cope with the iscsid changes. Makes the msg handling a lot easier.
...
This also introduces some stuff that is work in progress.
2014-04-21 17:44:47 +00:00
7a1fddfcf6
It does not make sense to specify a port for the initiatoraddr.
2014-04-21 17:33:20 +00:00
a2db36bbfc
tweak previous;
2014-04-20 22:52:26 +00:00
cf4672e7b9
Add iscsictl bits to show the vscsi stats.
2014-04-20 22:22:18 +00:00
015d7b4d30
use u_char for buffers in yylex, for ctype calls
...
found by millert@, ok deraadt@
2013-11-25 12:51:10 +00:00
a2460a9953
There is no need to compile this with -Werror by default.
2012-09-13 05:50:15 +00:00
9b9a50231f
Define empty CDIAGFLAGS for programs that use Werror.
...
Makes "make build" build with WARNINGS=Yes on amd64.
ok espie
2012-09-12 09:19:54 +00:00
cbe25abe77
Long overdue addition of the iscsi.conf man page.
...
Help and OK jmc@, OK dlg@
2012-06-26 21:09:44 +00:00
761f0b5254
s/ospfd/iscsid/ in comment
...
sure claudio@
2012-05-02 18:02:45 +00:00
3471b91252
Implement "log verbose|brief" and allow the configuratuin of the
...
initiatior config which is just the ISID in case someone needs
to fix them to a specific value.
2011-04-27 19:20:01 +00:00
7aed54e162
spacing, no binary changes.
2010-09-25 16:20:06 +00:00
211ccd835e
basic manpage for iscsictl. we wont do an iscsi.conf manpage until the
...
syntax has settled down.
2010-09-24 12:31:35 +00:00
208af72238
Import iscsictl -- the control tool for iscsid.
...
Currently only discovery and reload work.
OK dlg@, matthew@, deraadt@
2010-09-24 09:45:17 +00:00
naddy
claudio
jmc
deraadt
sashan
florian
miko
krw
denis
tedu
benno
sobrado
jsg
doug
haesbaert
gsoares
dlg