feat: migrate tslint noUnusedLocals to eslint rule as it is annoying

.eslintrc.json

@@ -18,6 +18,7 @@
       "rules": {
         "prettier/prettier": "error",
         "@angular-eslint/component-selector": ["off"],
+        "no-unused-vars": [2, { "args": "none" }],
         "@typescript-eslint/explicit-member-accessibility": [
           "off",
           {

src/app/core/data-repair/data-repair.util.ts

@@ -209,7 +209,7 @@ const _removeMissingTasksFromListsOrRestoreFromArchive = (
   return data;
 };
 
-const _resetEntityIdsFromObjects = <T>(
+const _resetEntityIdsFromObjects = (
   data: AppBaseDataEntityLikeStates,
 ): AppBaseDataEntityLikeStates => {
   return {

src/app/core/migration/legacy-models.ts

@@ -64,6 +64,7 @@ export interface LegacyPersistenceBaseModel<T> {
   save(state: T, isForce?: boolean): Promise<unknown>;
 }
 
+// eslint-disable-next-line no-unused-vars
 export interface LegacyPersistenceForProjectModel<S, M> {
   appDataKey: keyof LegacyAppDataForProjects;
 

src/app/core/persistence/persistence.model.ts

@@ -33,6 +33,7 @@ export interface PersistenceBaseEntityModel<S, M> extends PersistenceBaseModel<S
   execAction(action: Action): Promise<S>;
 }
 
+// eslint-disable-next-line no-unused-vars
 export interface EntityModelHelpers<S, M> {
   getById(projectId: string, id: string): Promise<M>;
 }

src/app/features/tasks/migrate-task-state.util.ts

@@ -107,7 +107,9 @@ const _convertToWesternArabicDateKeys = (task: Task) => {
 const _deleteUnusedFields = (task: Task): Task => {
   const {
     // legacy
+    // eslint-disable-next-line no-unused-vars
     _isAdditionalInfoOpen,
+    // eslint-disable-next-line no-unused-vars
     _currentTab,
     // the rest
     ...cleanTask

src/app/ui/duration/input-duration.directive.ts

@@ -47,7 +47,7 @@ export const INPUT_DURATION_VALIDATORS: any = {
     INPUT_DURATION_VALIDATORS,
   ],
 })
-export class InputDurationDirective<D>
+export class InputDurationDirective
   implements ControlValueAccessor, Validator, AfterViewChecked {
   @Input() isAllowSeconds: boolean = false;
   @Input() isValidate: boolean = true;

tsconfig.base.json

@@ -12,19 +12,12 @@
     "strictNullChecks": true,
     "forceConsistentCasingInFileNames": true,
     "noImplicitReturns": true,
-    "noUnusedLocals": true,
+    "noUnusedLocals": false,
     "strictPropertyInitialization": true,
     "target": "ES2015",
     "resolveJsonModule": true,
-    "typeRoots": [
-      "node_modules/@types"
-    ],
-    "types": [
-      "@types/moment-duration-format"
-    ],
-    "lib": [
-      "es2017",
-      "dom"
-    ]
+    "typeRoots": ["node_modules/@types"],
+    "types": ["@types/moment-duration-format"],
+    "lib": ["es2017", "dom"]
   }
 }