From 34fcea0b20d58dbf0fd091a864db4ee8aa5d554c Mon Sep 17 00:00:00 2001
From: Aidan MacDonald <amachronic@protonmail.com>
Date: Wed, 4 Aug 2021 20:22:37 +0100
Subject: [PATCH] Fix path buffer overflow in screendump

Overflow is due to a hidden assumption in create_datetime_filename()
and create_numbered_filename() where buffer must be >= MAX_PATH bytes.

Change-Id: I9d36517d861b6925352380d551afc5439edbb340
---
 firmware/screendump.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/firmware/screendump.c b/firmware/screendump.c
index 1acaaafba6..7d09b0cd5e 100644
--- a/firmware/screendump.c
+++ b/firmware/screendump.c
@@ -102,7 +102,7 @@ static void (*screen_dump_hook)(int fh) = NULL;
 void screen_dump(void)
 {
     int fd, y;
-    char filename[32];
+    char filename[MAX_PATH];
 
     fb_data *src;
 #if LCD_DEPTH == 1
@@ -306,7 +306,7 @@ static const unsigned char rbmpheader[] =
 void remote_screen_dump(void)
 {
     int fd, y;
-    char filename[32];
+    char filename[MAX_PATH];
 
     fb_remote_data *src;
 #if LCD_REMOTE_DEPTH == 1