nihilazo/rockbox
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Increase set_time_screen() buffer size for hosted to keep the compiler happy.

Browse Source 
The format strings in the snprintf can in theory need 60 characters
This will not happen in practice (because seconds are 0..60 and not
full-range integers etc.), but -D_FORTIFY_SOURCE will still warn
about it, so we use 60 characters for HOSTED to make the compiler
happy. Native builds still use 20, which is enough in practice.

Change-Id: I22a2bab8134442e531a10bf883f3a369ade0fdc3
This commit is contained in:
Frank Gevaerts 2019-07-20 17:11:32 +02:00
parent 3cb272c97a
commit 3665eecf47
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apps/screens.c
View File

@ -374,7 +374,16 @@ bool set_time_screen(const char* title, struct tm *tm)
int button;
unsigned int i, realyear, min, max;
unsigned char *ptr[6];
#if (CONFIG_PLATFORM & PLATFORM_HOSTED)
/* The format strings in the snprintf can in theory need 60 characters
This will not happen in practice (because seconds are 0..60 and not
full-range integers etc.), but -D_FORTIFY_SOURCE will still warn
about it, so we use 60 characters for HOSTED to make the compiler
happy. Native builds still use 20, which is enough in practice. */
unsigned char buffer[60];
#else
unsigned char buffer[20];
#endif
int *valptr = NULL;
static unsigned char daysinmonth[] =
{31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};