nihilazo
/
rockbox
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Handle EOF properly in get_flac_metadata 

Change-Id: I5e581990046a9f4a0859787aff2fd6fc06fbf7f5
This commit is contained in:
Yuxuan Shui 2019-05-12 15:36:52 +01:00 committed by Solomon Peachy
parent e4ccd23bac
commit 5758a055fb
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/CREDITS
View File

@ -697,6 +697,7 @@ Boris Kovačević
Stéphane Moutard-Martin
Rune Pade
Michael Rey
Yuxuan Shui
The libmad team
The wavpack team

4
lib/rbcodec/metadata/flac.c
View File

@ -59,7 +59,7 @@ bool get_flac_metadata(int fd, struct mp3entry* id3)
unsigned long i;
int type;
if (read(fd, buf, 4) < 0)
if (read(fd, buf, 4) != 4)
{
return rc;
}
@ -73,7 +73,7 @@ bool get_flac_metadata(int fd, struct mp3entry* id3)
{
unsigned long totalsamples;
if (i >= sizeof(id3->path) || read(fd, buf, i) < 0)
if (i >= sizeof(id3->path) || read(fd, buf, i) != i)
{
return rc;
}