nihilazo
/
rockbox
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

timefuncs.c valid_time() should return false if tm == NULL and not try to deref 

luckily no one has
yet..

Change-Id: I4117db84b013fa826958aea635daa0a24ee534b6
This commit is contained in:
William Wilgus 2021-07-20 00:04:36 -04:00 committed by Solomon Peachy
parent 966e210e6d
commit b91ad60d63
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/common/timefuncs.c
View File

@ -86,13 +86,13 @@ static inline int rtc_read_datetime(struct tm *tm)
#if CONFIG_RTC
bool valid_time(const struct tm *tm)
{
if (tm->tm_hour < 0 || tm->tm_hour > 23 ||
if (!tm || (tm->tm_hour < 0 || tm->tm_hour > 23 ||
tm->tm_sec < 0 || tm->tm_sec > 59 ||
tm->tm_min < 0 || tm->tm_min > 59 ||
tm->tm_year < 100 || tm->tm_year > 199 ||
tm->tm_mon < 0 || tm->tm_mon > 11 ||
tm->tm_wday < 0 || tm->tm_wday > 6 ||
tm->tm_mday < 1 || tm->tm_mday > 31)
tm->tm_mday < 1 || tm->tm_mday > 31))
return false;
else
return true;