ee6b737b65
pcm_record.c iAudioM5 FixRed
...
Share a bit of code in order to free up iRam for the iAudio M5
Change-Id: Ief05d2614a203df17821ed32b04f5c75a53ca08b
2021-08-10 07:56:33 -04:00
4fb5aeb096
recorder/pcm_record.c cleanup copy function
...
re: coverity
write_write_order: In long(*s++) + *s++,
s is written in *s++ and written in long(*s++)
but the order in which the side effects take place is undefined because
there is no intervening sequence point.
Change-Id: I2911c240f3e85fcfbf77297e8579e02e217c5af5
2021-08-10 11:22:13 +00:00
2f0fd66e44
re-synchronize english-us "translation"
...
Change-Id: I21035cda0617e74283e4b30557783d297d8dfcd0
2021-08-09 22:18:43 +00:00
e4c5b082e8
inflate: fix public function pointers
...
Change-Id: I7f1273b832a04a7d7c1b386c08c17438e3d93fc2
2021-08-09 16:25:43 +00:00
275c762bb2
As3525 wavpack_enc document some intentional switch fall through
...
Change-Id: I56bf439df2c05653d65f49238e886e4ef2291176
2021-08-08 09:27:27 -04:00
0a6d7abd13
metadata/asap.c consolidate read char function and check return values
...
and a bit of cleanup using macros to make the code easier to follow
Change-Id: I2c5953a68a9f415453e508c14a9c1a5a1e84e6b5
2021-08-07 17:13:09 -04:00
da778a1783
metadata/asap.c WS cleanup
...
Change-Id: Id3bc053a45eeea107a54dd47640fa3ceb4b04498
2021-08-07 17:07:32 -04:00
5311ff0173
tagcache: Don't treat tag_virt_basename as a numeric tag
...
Change-Id: I88fe17466b606a1f60a4c823214edd9766deb260
2021-08-07 16:03:21 +00:00
cf3fa437fc
Remove unhelpful unsigned casting trick
...
Change-Id: Ice86f060974c51bbaf051ed8c5a369ce80ecfe15
2021-08-07 15:52:18 +00:00
39fff5cb53
move PCM_NATIVE_BITDEPTH definiton into global config code
...
Change-Id: I391bcffca670916c2c88426e2ba2603351326cee
2021-08-07 11:18:19 -04:00
eeb0aaf36f
fiiom3k: Add bookmark screen keymapping
...
Forgot to commit this back around the time I did the manual
Change-Id: I8fafeec5105b4bee3380779f4cc86d3e73459cf2
2021-08-07 15:04:23 +00:00
a2bbd1a549
Fix warnings from 56b0dde545
...
Need a default bit depth in pcm-x1000.c
Change-Id: I2c6af227975d2f47609b51090638012d8406ec1e
2021-08-07 09:43:17 -05:00
56b0dde545
Higher bitdepth software volume scaling
...
Operates between 0 and -74 dB (mute) without issue
Change-Id: I497e002bd8db43833a09ebbc29212fbb6cc8ebfd
2021-08-07 14:21:47 +00:00
16b0098256
ErosQ Native: Add DC Offset to PCM data
...
A small negative offset seems to silence all
play/pause clicking on the PCM5102A.
Also adding PCM soft muting, and muting the headphone amp
when the headphones are detected as removed. This has been
tested to not cause any unintended side effects on the
line out.
Also confirmed the numerical dB values are (approx.) correct.
Change-Id: I689d68887c86add9cc5e0ccb0c7de01aaa69b4d9
2021-08-07 14:21:47 +00:00
57293f1fd9
metadata/vfx.c cleanup string and character handling
...
Change-Id: I7550d6db05b0d31a1433d0af9b2233f9dc3f5ee2
2021-08-07 04:50:14 +00:00
60933d98c6
inflate: import initial module for deflate decompression
...
This will eventually be used by the ZIP module and other things
that support DEFLATE based streams.
Change-Id: I4acc9561eb56c9c368d1defab9c14e0454d105e1
2021-08-07 03:03:27 +00:00
603e749c1d
metadata/smaf.c handle read errors
...
Change-Id: I450f1fc8e1b69ce09f9888f5384c3e23a93822a1
2021-08-07 02:53:28 +00:00
8a8fd3d4a3
metadata/mp3data.c set data to 0 in case of read error
...
Change-Id: I15d4e3d3be4bf4531c892f4351355b0b2e8e0ca9
2021-08-06 20:55:11 -04:00
2008b7d1b0
Fix yellow from d541a72a
...
Change-Id: I9c539035544d285da1941d2c1954cf2aa4d00087
2021-08-06 19:59:33 +01:00
257ba1d2e0
Fix possible negative fd in playlist.c
...
Change-Id: I59d88609ec3f20ec9f482a777396cd72be23a35b
2021-08-06 19:38:06 +01:00
02b940396b
Be sure to wipe id3 tag after failed parse in playback.c
...
Change-Id: I000c78e913ab80afa9b82cae937afb5255831b79
2021-08-06 18:34:04 +00:00
d541a72a0e
Bugfixes in eq_menu.c
...
Change-Id: Ibf754554f685d13ac00a49694fcecee459ff838f
2021-08-06 18:23:57 +00:00
1a9a5fc279
Fix wrong printf format in system-hosted.c
...
Change-Id: I73722f0711a295152a98ab784cd6cf76379ef52e
2021-08-06 18:23:17 +00:00
b8b195a296
Fix hosted glibc backtrace
...
According to backtrace(3) man page, the string returned from
backtrace_symbols() contains the return address so we shouldn't
need to print it ourselves.
Change-Id: Ia779207285c9ea0052b9aee3d84ee8380bf46d82
2021-08-06 18:54:34 +01:00
6b1b7b6016
Fix use of uninitialized variable in mp4 metadata parser
...
Change-Id: Idca69e7429af13609785755d4e152d87f471c462
2021-08-06 16:10:41 +00:00
34fcea0b20
Fix path buffer overflow in screendump
...
Overflow is due to a hidden assumption in create_datetime_filename()
and create_numbered_filename() where buffer must be >= MAX_PATH bytes.
Change-Id: I9d36517d861b6925352380d551afc5439edbb340
2021-08-06 15:46:53 +00:00
835d0c737a
logf: Fix two issues with logf_panic_dump()
...
* It had a (read) buffer overflow when dumping the stuff on the back half of the buffer
* a highly questionable code construct was nuked
Change-Id: I7f6f119524fc2095f788fc9b3d356459955d3ace
2021-08-06 10:08:00 -04:00
da45b37fac
tools/iriver: fix resource management in encode/decode functions
...
Change-Id: Ib0b38378c66d5902694d9af9fd0271d616101660
2021-08-06 03:08:10 +00:00
a20755e9ef
test_disk: Minor fix in an error path
...
...Log the variable containing the actual error
Change-Id: If22e6b684f2e213bc45c8ca95295936ba8e09895
2021-08-05 14:22:53 +00:00
9f0f2c6658
metadata: Fix sign extension in get_uint64_le() routine
...
Change-Id: Ibd85cf72ac1babd1fa636c341b90b76bdfc0491b
2021-08-05 13:44:39 +00:00
566d836ac6
mikmod: Uninitialized variable used in a control flow decision
...
Change-Id: I6df903399361f1df7ca0f766fff4062a984e2ba8
2021-08-05 13:44:33 +00:00
f3010c6a8e
hosted: Fix rtc_write_datetime() error handling
...
(if mktime() fails, don't attempt to write its result to the RTC)
Change-Id: Ib09b8dccafdef032119db76f10af74dfc220cc21
2021-08-05 13:44:11 +00:00
cb6b0d2c0e
disk.c ensure a valid volume is returned from get_free_volume()
...
volume is used for element math and indexing into buffers
-1 volume is bad
Change-Id: I1ec75ef3a848c154ea80905224ea9a3a14bf8151
2021-08-05 11:01:29 +00:00
d57900ae12
misc.c format_sound_value guard division by zero
...
Change-Id: I7085cb34d2258aa5fc7e04fc0e73d6f733810038
2021-08-05 11:00:47 +00:00
848633f921
lib/skin_parser check that malloc succeeded
...
Change-Id: I32db233a53b0f693f815cf96bcbe6711c366e5b3
2021-08-05 10:38:18 +00:00
03a6eb63f1
Simplify clamp_component
...
Surprise surprise: the compiler generates shorter, branch-free code
if we don't try to be clever with signed/unsigned casting tricks.
Change-Id: I93d2020b6127e7d43feee394b06a52aaeddf3b79
2021-08-05 10:26:50 +00:00
429a7e2c0a
Avoid buffer overflow when generating bookmark file name
...
Change-Id: I14f3d83a8089d33f4e900a1d5f965e67082a07ea
2021-08-04 19:04:48 +00:00
bdd9c8dfc8
plugins: Fix issues in 2048
...
One of these was an unintentional fallthrough -- if you said no to
'quit without saving' it would save and quit.
Change-Id: I33828b58962a05adab65ac5f71dd0e2b1e07001b
2021-08-04 19:04:37 +00:00
005c414e5f
Document intentional fallthroughs + fix harmless unintended ones
...
Change-Id: I1ca5b1027ec30cbf61093bab35b980196ed14e6b
2021-08-04 18:59:46 +00:00
ef41cc6623
Revert "rbutil: Remove done() signal from Themes Install window."
...
The done() signal is acutally needed to indicate the installation being
finished. Fixes installation being stuck after themes install.
This reverts commit fb6840e572
2021-08-04 19:10:34 +02:00
c522917644
plugins/resistor: Fix incorrect check for a valid 4th band value
...
Change-Id: I499bcd6d2d6fd5dd92c184cc1ec014e62f0441fa
2021-08-04 14:56:20 +00:00
37bfcab23f
powermgmt: Clean up some convoluted #ifdefs
...
Makes it more explicit what code is used under which circumstances.
Change-Id: I0a482dd48e1eb4b119ca6d8dca2b8aa450445fd1
2021-08-04 09:39:37 -04:00
0d0640e57a
menu.c guard against NULL menu, list, setting pointers
...
Change-Id: Id45d9ac3b88571cb3927ca29314f997d5cbfd598
2021-08-03 11:43:53 +00:00
074daea51f
lua fix potential null warning
...
I'm not sure this would happen but I suspect its possible to get malformed
data back from lineinfo as this is how the error system tracks code flow
and this is a hacked add-on to allow RLE (run length encoding) of
said code flow data
Change-Id: I4b914c632935f8b1a9fa960212c58e810b2db738
2021-08-03 11:02:15 +00:00
1fd190d02d
mask_select guard against null pointers
...
Change-Id: I83d246c13d22c1e76a55cbfdd20dcc955eb556ec
2021-08-03 11:00:59 +00:00
36e48a8bb2
icon.c guard against negative error values bytesread is copied to an unsigned int for core_shrink
...
Change-Id: Iff93397e7d6fae8936ef0fdbb1e71df63bcf6531
2021-08-02 23:06:40 -04:00
93c9d675af
folder_select prevent directory handle leak on error
...
Change-Id: If1617dc92683d7de3d7709b363a593e40fbc5bc8
2021-08-03 03:01:14 +00:00
429eedf49e
list-skinned.c check label pointer for validity
...
Change-Id: I993ff4a2d5d1c46bad46aae7f46fa4996e67481a
2021-08-03 02:49:17 +00:00
382b52b120
filetypes.c filesize() guard against negative error values
...
buffer size is copied to an unsigned int for core_alloc
Change-Id: I7b9ccab79554e55b22d39501ccb779036913258a
2021-08-02 22:32:15 -04:00
1fc4a17e1c
language.c fix possible buffer overrun
...
ensure zero termination regardless of data read from lang file
Change-Id: I0da0e787ffb10c9268557812b061cc3c452fbd0a
2021-08-03 00:57:35 +00:00
William Wilgus
Solomon Peachy
James Buren
Aidan MacDonald
Dana Conrad
Dominik Riebeling