raidancampbell
  • Joined on
Loading Heatmap…

raidancampbell commented on pull request sloum/bombadillo#214

Better word wrapping

I got a chance to play around with this for a couple hours today and couldn't find any obvious issues. Code-wise it's not amazingly performant or clean: it gets the job done, but I'm happy to…

1 year ago

raidancampbell commented on pull request sloum/bombadillo#214

Better word wrapping

> Ok. I have built this. Looks great! Updating the width with `:set maxwidth 60` or the like works well and the word wrapping is great! > > I don't want to put more work on you, but if you…

1 year ago

raidancampbell pushed to master at raidancampbell/bombadillo

  • 1bef2e51a1 when wrapping, omit leading whitespace created if the wrap occurs at a space char

1 year ago

raidancampbell commented on pull request sloum/bombadillo#214

Better word wrapping

`070f7eb6ba261866395706f709d12dff3ead2e74` contains a first pass on this. Since `c.Options` is both a field on the struct and altered by reading in the configuration after instantiating the…

1 year ago

raidancampbell pushed to master at raidancampbell/bombadillo

  • 070f7eb6ba extract logic for reading maxwidth config into a function: now safely handles fallbacks for missing or malformed configuration

1 year ago

raidancampbell commented on pull request sloum/bombadillo#214

Better word wrapping

> I'm definitely interested in the changes. I have not had a chance to pull, build, and test... but would like to do so soon. > > Thanks for taking this on! While breaking in a word has never…

1 year ago

raidancampbell commented on pull request sloum/bombadillo#214

Better word wrapping

The intent here was to catch malformed / missing configuration entries: your suggestion of wrapping the logic into a `getMaxWidth` function will solve this problem and remove the need here. Much…

1 year ago

raidancampbell created pull request sloum/bombadillo#214

WIP: Better word wrapping

1 year ago

raidancampbell pushed to master at raidancampbell/bombadillo

1 year ago

raidancampbell pushed to master at raidancampbell/bombadillo

1 year ago

raidancampbell pushed to master at raidancampbell/bombadillo

1 year ago

raidancampbell pushed to master at raidancampbell/bombadillo

  • a5f6c22c54 soft wrap between words
  • 984fb4eb2f max width for softwraping now configured via maxwidth configuration item: default or invalid value falls back to previous 100 column
  • Compare 2 commits »

1 year ago

raidancampbell created repository raidancampbell/bombadillo

1 year ago