Makes the first history position reloadable #116

sloum · 2019-12-07T06:22:47Z

sloum commented

2019-12-07 06:22:47 +00:00

As stated in issue #109 , if a user is on the first history location (whatever their home page is set to most likely) reload was not working. This is because as part of reload it navigates backward and does a little trick to load the page again without losing forward history. However, moving backward into nothing is not possible.

To fix this I manually check to see that we are on the first history location, then manually move the location backward by one in order to make it possible to visit the url again and have it load to the same history slot. It sounds more complicated than it is.

As stated in issue #109 , if a user is on the first history location (whatever their home page is set to most likely) reload was not working. This is because as part of reload it navigates backward and does a little trick to load the page again without losing forward history. However, moving backward into nothing is not possible. To fix this I manually check to see that we are on the first history location, then manually move the location backward by one in order to make it possible to visit the url again and have it load to the same history slot. It sounds more complicated than it is.

sloum added this to the 2.1.0 milestone 2019-12-07 06:22:47 +00:00

sloum added the

bug

label 2019-12-07 06:22:47 +00:00

asdf commented

2019-12-08 03:08:23 +00:00

It does sound complicated!

I've checked this now and found that it is still possible to get the message "You are already at the beginning of history" when reloading a page.

Load bombadillo
Navigate to a new page - follow a link on the homepage, or load a new URL
Go back to homepage
Refresh homepage

It is working correctly otherwise. For example, the following succeeds:

load bombadillo
refresh homepage

I might get a chance to look deeper in to this later on.

It does sound complicated! I've checked this now and found that it is still possible to get the message "You are already at the beginning of history" when reloading a page. 1. Load bombadillo 2. Navigate to a new page - follow a link on the homepage, or load a new URL 3. Go back to homepage 4. Refresh homepage It is working correctly otherwise. For example, the following succeeds: 1. load bombadillo 2. refresh homepage I might get a chance to look deeper in to this later on.

sloum commented

2019-12-08 06:22:42 +00:00

Good catch! I hadnt thought about that. I was using the history length (as defined by the pages struct) as the guide-point for when to do a special handling case. I really needed to do it based on position within history instead. I have updated the code. Initial testing seems to show it working right, but I would appreciate it if you dont mind rerunning yours again just to double check.