RFC: Gemini link numbering #133

New Issue

sloum · 2020-03-04T17:34:50Z

sloum commented

2020-03-04 17:34:50 +00:00

Currently the gemini module does not do what gopher does: provide a left hand gutter for link numbers. Should we add a gutter on the left hand side for gemini? It is a minor code update to do so... but I am not sure what the merits and flaws of doing so are.

sloum added the

non-urgent

question

labels 2020-03-04 17:35:42 +00:00

sloum commented

2020-03-17 05:46:54 +00:00

I am leaning toward adding this in. If only for consistency with how gopher is displayed in Bombadillo.

It has the additional bonus that any link lines that are part of ascii art (not recommended, but definitely possible) will align properly with the art the comes before and/or after them. I'll work something up and get a PR together.

I am leaning toward adding this in. If only for consistency with how gopher is displayed in Bombadillo. It has the additional bonus that any link lines that are part of ascii art (not recommended, but definitely possible) will align properly with the art the comes before and/or after them. I'll work something up and get a PR together.

👍 3

sloum self-assigned this 2020-03-17 05:47:00 +00:00

sloum commented

2020-04-14 18:46:55 +00:00

So, this has proved to be trickier than initially thought. I'm going to keep playing with it, but wanted to update that I had been working on it.

sloum added the

gemini

label 2020-05-18 23:50:13 +00:00

sloum commented

2020-09-09 04:33:28 +00:00

It has taken forever (sorry!) but I think I have a working version of the numbering gutter working for gemini. Any that want to check it out can see the code in PR #188 . The branch is listed and can be pulled. If this seems good we'll move it into a release branch and close this issue. Otherwise I'll comment here with an update.

sloum commented

2020-11-02 03:08:06 +00:00

This was merged into a release branch with #188

Gopher's link numbering was also modified as a part of that PR. I will keep this open until the release is done.

This was merged into a release branch with #188 Gopher's link numbering was also modified as a part of that PR. I will keep this open until the release is done.

👍 1

sloum closed this issue

2021-01-22 06:02:29 +00:00

Sign in to join this conversation.