webmode settings in source code not honored #151

Closed
opened 1 year ago by tidux · 4 comments
tidux commented 1 year ago

I've tried setting "webmode": "lynx", and "webmode": "w3m" in defaults.go but neither setting is used in the resulting binaries. I still get a "Current 'webmode' setting does not allow http/https" error despite both lynx and w3m existing in /usr/bin/. Test system is Debian 10, with Go 1.14.3. There is no INI file.

I've tried setting `"webmode": "lynx",` and `"webmode": "w3m"` in defaults.go but neither setting is used in the resulting binaries. I still get a "Current 'webmode' setting does not allow http/https" error despite both lynx and w3m existing in /usr/bin/. Test system is Debian 10, with Go 1.14.3. There is no INI file.
Owner

@tidux

That is very strange that it is not compilling correctly for you. A few questions:

  • Are you building off of master or develop?
  • When you launch bombadillo what is the response when you enter the following:
    • :check webmode
  • Seems silly to ask, but always good to sanity check: are you sure you have saved defaults.go with the updated value before compiling?
  • After lanching Bombadillo does the following command update the value and then work for viewing web links:
    • :set webmode lynx

I just pulled master and changed the "webmode" in defaults.go to "lynx" and had no issues (compiled with 1.14.2 on Arch).

Let me know the above when you get a chance. I use a Debian based system as my main system and the Arch system I just used as a secondary and have not run into this issue so I do not think it is a platform issue.

Oh! One more question:

  • After you compile and run Bombadillo, has a .bombadillo.ini file been created?
@tidux That is very strange that it is not compilling correctly for you. A few questions: - Are you building off of `master` or `develop`? - When you launch bombadillo what is the response when you enter the following: - `:check webmode` - Seems silly to ask, but always good to sanity check: are you sure you have saved `defaults.go` with the updated value _before_ compiling? - After lanching Bombadillo does the following command update the value and then work for viewing web links: - `:set webmode lynx` I just pulled `master` and changed the `"webmode"` in `defaults.go` to `"lynx"` and had no issues (compiled with `1.14.2` on Arch). Let me know the above when you get a chance. I use a Debian based system as my main system and the Arch system I just used as a secondary and have not run into this issue so I do not think it is a platform issue. Oh! One more question: - After you compile and run Bombadillo, has a `.bombadillo.ini` file been created?
sloum added the
bug
label 1 year ago
asdf commented 1 year ago
Collaborator

Just a quick note: it sticks out that the report states there is no INI file.

Changes to defaults.go, followed by a recompile, will not have an impact on settings for a user who already has an ini file (with the exception of the configlocation setting that changes where the ini file is stored).

Could it be that there is an existing configuration file with a different webmode setting in an unexpected location? The actual location can be checked in Bombadillo using the command :check configlocation.

By the way thanks @tidux for the report!

Just a quick note: it sticks out that the report states there is no INI file. Changes to defaults.go, followed by a recompile, will not have an impact on settings for a user who already has an ini file (with the exception of the `configlocation` setting that changes where the ini file is stored). Could it be that there is an existing configuration file with a different webmode setting in an unexpected location? The actual location can be checked in Bombadillo using the command `:check configlocation`. By the way thanks @tidux for the report!
Owner

You are very right @asdf . Good thinking! That may be a simple fix here. Hopefully checking the config location that is being used by the binary and then deleting a config if it exists will do the job.

If there is no config at that location, that would definitely be a weird issue. I look forward to hearing back about this one!

You are very right @asdf . Good thinking! That may be a simple fix here. Hopefully checking the config location that is being used by the binary and then deleting a config if it exists will do the job. If there is no config at that location, that would definitely be a weird issue. I look forward to hearing back about this one!
sloum added the
needs-info
label 1 year ago
sloum added the
blocked
label 1 year ago
Owner

I am closing this as a stale issue with not enough info to replicate. @tidux feel free to resubmit if you end up with more info.

I am closing this as a stale issue with not enough info to replicate. @tidux feel free to resubmit if you end up with more info.
sloum closed this issue 1 year ago
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.