Replace calls to stty with syscalls #158

dancek · 2020-05-24T06:29:07Z

dancek commented

2020-05-24 06:29:07 +00:00

Move termios-related functionality to its own package
Reimplement stty calls using ioctl calls
Add per-platform constants for linux and non-linux because the ioctl
enums are different. The enums in Darwin seem to come from BSD and so
I'm assuming they might also work for other operating systems. If not,
we'll need to add other build-constrained const files.

This code has been tested on Darwin and will be tested on Linux before
merging.

Note that this PR was discussed in length in #154, #155 and #156.

- Move termios-related functionality to its own package - Reimplement stty calls using ioctl calls - Add per-platform constants for linux and non-linux because the ioctl enums are different. The enums in Darwin seem to come from BSD and so I'm assuming they might also work for other operating systems. If not, we'll need to add other build-constrained const files. This code has been tested on Darwin and will be tested on Linux before merging. --- Note that this PR was discussed in length in #154, #155 and #156.

dancek referenced this pull request

2020-05-24 06:30:15 +00:00

replace calls to `stty` with syscalls #155

sloum commented

2020-05-24 14:22:02 +00:00

Approved! This is really great and I am excited to include these changes. I have verified that this builds and functions as expected on both Linux and FreeBSD. Merging in to the releas branch now and will hopefully merge in that release today or tomorrow.

sloum referenced this issue from a commit

2020-05-24 14:23:18 +00:00

Merge pull request 'Replace calls to `stty` with syscalls' (#158) from dancek/bombadillo:replace-stty into release-2.3.0

sloum closed this pull request

2020-05-24 14:23:21 +00:00

Sign in to join this conversation.

No reviewers