Adds in the correct variable when checking for existing querystring value #166

sloum · 2020-05-26T02:16:18Z

sloum commented

2020-05-26 02:16:18 +00:00

During the rush up to 2.3.0 this was supposedly fixed, but I did not have a good test case. Since I do not have access to a server with cgi enabled I was not able to create a functional test for this. In theory I suppose this could have been split into its own method and then unit tested. That actually may be the way to go.

In any event, this should solve the immediate issue. To test/verify the fix:

go build
./bombadillo gemini://gemini.conman.org:1965/hilo/

You should be able to play the game without Sean's server sending you an error page.

This is in reference to issue #157

This PR also adds in query string escaping. Originally, using golang's QueryEscape spaces were being encoded as +. Which seemed... not wrong in the eyes of RFCs, but not workable for how many gemini servers are interested. It turns out using PathEscape will use %20, so hopefully this works well.

This second fix is in reference to issue #161

During the rush up to `2.3.0` this was supposedly fixed, but I did not have a good test case. Since I do not have access to a server with cgi enabled I was not able to create a functional test for this. In theory I suppose this could have been split into its own method and then unit tested. That actually may be the way to go. In any event, this should solve the immediate issue. To test/verify the fix: ``` go build ./bombadillo gemini://gemini.conman.org:1965/hilo/ ``` You should be able to play the game without Sean's server sending you an error page. This is in reference to issue #157 This PR also adds in query string escaping. Originally, using golang's `QueryEscape` spaces were being encoded as `+`. Which seemed... not wrong in the eyes of RFCs, but not workable for how many gemini servers are interested. It turns out using `PathEscape` will use `%20`, so hopefully this works well. This second fix is in reference to issue #161

👍 1

sloum referenced this pull request

2020-05-26 02:19:56 +00:00

Repeated queries are not handled correctly #157

sloum added the

bug

label 2020-05-26 02:21:42 +00:00

sloum referenced this pull request

2020-05-26 02:46:23 +00:00

Query strings are not being escaped for gemini status 1x requests #161

asdf commented

2020-05-26 03:12:59 +00:00

Confirmed working using that test. Plus did the other checks like make test and it was fine. Cool! Bombadillo's prompt when playing that game works really well.

👍 1

makeworld commented

2020-05-26 18:51:32 +00:00

First-time contributor

It turns out using PathEscape will use %20, so hopefully this works well.

It looks like that will be the way the spec goes for sure, so it sounds like this is the right path! See this email.

> It turns out using PathEscape will use `%20`, so hopefully this works well. It looks like that will be the way the spec goes for sure, so it sounds like this is the right path! See [this email](https://lists.orbitalfox.eu/archives/gemini/2020/001069.html).

sloum referenced this issue from a commit

2020-05-28 04:49:29 +00:00

Merge pull request 'Adds in the correct variable when checking for existing querystring value' (#166) from fix-repeated-query into release-2.3.1 Since this has been reviewed as functional I am merging into the release branch. There will be another opportunity to review, if need be, for the release branch when a PR is made into `develop`.

sloum closed this pull request

2020-05-28 04:49:30 +00:00

Sign in to join this conversation.

No reviewers