WIP Initial support for some unicode line endings #200

asdf · 2020-11-05T10:26:12Z

asdf commented

2020-11-05 10:26:12 +00:00

Fixes #199

Handle unicode line terminators to avoid rendering issues identified in #199.

NEL, Next Line, U+0085
LS, Line Separator, U+2028
PS, Paragraph Separator, U+2029

Each item will be identified as a line ending and rendered as appropriate.

Fixes #199 Handle unicode line terminators to avoid rendering issues identified in #199. - NEL, Next Line, U+0085 - LS, Line Separator, U+2028 - PS, Paragraph Separator, U+2029 Each item will be identified as a line ending and rendered as appropriate.

asdf self-assigned this 2020-11-05 10:26:13 +00:00

sloum commented

2020-11-05 15:44:28 +00:00

This seems solid to me. THinking about wha tyou said regarding \v... that makes sense. I've never seen a \v in the wild (not even sure how to input it out of a code situation), but doing either two or three newlines seems reasonable if we wanted to add that here (though I am not sure it is necessary).

I approve this as is if we want to merge in.

This seems solid to me. THinking about wha tyou said regarding `\v`... that makes sense. I've never seen a `\v` in the wild (not even sure how to input it out of a code situation), but doing either two or three newlines seems reasonable if we wanted to add that here (though I am not sure it is necessary). I approve this as is if we want to merge in.

asdf referenced this issue from a commit

2020-11-06 02:34:10 +00:00

Merge pull request 'WIP Initial support for some unicode line endings' (#200) from unicode-line-endings into release2.3.3 Reviewed-on: https://tildegit.org/sloum/bombadillo/pulls/200

asdf merged commit 8c838ce491 into release2.3.3

2020-11-06 02:34:11 +00:00

asdf deleted branch unicode-line-endings

2020-11-06 02:34:21 +00:00

asdf commented

2020-11-06 02:34:40 +00:00

Thanks for the feedback.

By the way, you can do a vertical tab with CTRL+K. Easiest way to see it is to run cat, then type aaaa^Kaaaa followed by enter. It's the first I've actually seen it too.

Thanks for the feedback. By the way, you can do a vertical tab with CTRL+K. Easiest way to see it is to run `cat`, then type `aaaa^Kaaaa` followed by enter. It's the first I've actually seen it too.

sloum commented

2020-11-06 03:27:38 +00:00

Thanks for your work on this issue! Much appreciated :-D

Interesting. I had no idea ctrl-k would give you a vertical tab. I wonder if cat just treats it as two newlines or if it is outputting an actual vertical tab that the terminal renders?

Thanks for your work on this issue! Much appreciated :-D Interesting. I had no idea ctrl-k would give you a vertical tab. I wonder if cat just treats it as two newlines or if it is outputting an actual vertical tab that the terminal renders?

Sign in to join this conversation.

No reviewers