Makefile uses GNU-specific gzip flag -k #211

New Issue

jaywilliams · 2021-05-14T17:14:02Z

jaywilliams commented

2021-05-14 17:14:02 +00:00

The current Makefile uses the gzip -k flag which is only implemented on GNU implementations of gzip. Using the -c flag along with redirection achieves the same thing and works on both gnu and bsd implementations.

diff --git a/Makefile b/Makefile
index cca7657..b3fd661 100644
--- a/Makefile
+++ b/Makefile
@@ -22,7 +22,7 @@ install: install-bin install-man install-desktop clean

 .PHONY: install-man
 install-man: bombadillo.1
-   gzip -k ./bombadillo.1
+   gzip -c ./bombadillo.1 > ./bombadillo.1.gz
    install -d ${DESTDIR}${MAN1DIR}
    install -m 0644 ./bombadillo.1.gz ${DESTDIR}${MAN1DIR}

The current Makefile uses the gzip `-k` flag which is only implemented on GNU implementations of gzip. Using the `-c` flag along with redirection achieves the same thing and works on both gnu and bsd implementations. ```diff diff --git a/Makefile b/Makefile index cca7657..b3fd661 100644 --- a/Makefile +++ b/Makefile @@ -22,7 +22,7 @@ install: install-bin install-man install-desktop clean .PHONY: install-man install-man: bombadillo.1 - gzip -k ./bombadillo.1 + gzip -c ./bombadillo.1 > ./bombadillo.1.gz install -d ${DESTDIR}${MAN1DIR} install -m 0644 ./bombadillo.1.gz ${DESTDIR}${MAN1DIR} ```

jaywilliams referenced this issue

2021-05-14 17:19:52 +00:00

Don't use GNU-specific gzip -k flag #212

Sign in to join this conversation.